Fix: Empty transaction data on log in #31302

tienifr · 2023-11-14T10:43:29Z

Details

OpenApp API does not return transaction data thus on first load, transaction reports show 0.00 in title. This PR sets fallback title if transaction data has not been loaded yet.

Fixed Issues

$ #30687
PROPOSAL: #30687 (comment)

Tests

Send a money request in the workspace chat
Open transaction report
Send message to another chat and stay there
Log out
Log in
Verify that in LHN, the correct amount is shown in transaction report title

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Send a money request in the workspace chat
Open transaction report
Send message to another chat and stay there
Log out
Log in
Verify that in LHN, the correct amount is shown in transaction report title

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2023-11-14.at.19.56.37-compressed.mov

Android: mWeb Chrome

Screen.Recording.2023-11-14.at.20.04.47-compressed.mov

iOS: Native

Screen.Recording.2023-11-14.at.19.49.41-compressed.mov

iOS: mWeb Safari

Screen.Recording.2023-11-14.at.19.52.29-compressed.mov

MacOS: Chrome / Safari

Screen.Recording.2023-11-14.at.19.45.22-compressed.mov

MacOS: Desktop

Screen.Recording.2023-11-14.at.19.54.37-compressed.mov

melvin-bot · 2023-11-14T13:06:26Z

@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tienifr · 2023-11-17T08:20:04Z

@fedirjh Can you check?

fedirjh · 2023-11-17T14:33:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

CleanShot.2023-11-20.at.02.23.16.mp4

Android: mWeb Chrome

CleanShot.2023-11-20.at.01.59.21.mp4

iOS: Native

CleanShot.2023-11-20.at.01.46.13.mp4

iOS: mWeb Safari

CleanShot.2023-11-20.at.01.49.58.mp4

MacOS: Chrome / Safari

CleanShot.2023-11-19.at.23.04.48.mp4

MacOS: Desktop

CleanShot.2023-11-20.at.02.05.56.mp4

fedirjh · 2023-11-17T15:02:47Z

@tienifr it Looks we have a bug: The currency changes after opening older requests

CleanShot.2023-11-17.at.15.58.20.mp4

fedirjh · 2023-11-20T02:14:38Z

src/libs/ReportUtils.js

+    if (_.isEmpty(transaction)) {
+        return lodashGet(reportAction, ['message', 0, 'text'], '').replace(/(\r\n|\n|\r)/gm, ' ');
+    }


Let's add a comment to the code.

tienifr · 2023-11-22T09:24:05Z

The currency changes after opening older requests

@fedirjh I can't reproduce the issue. Can you verify if it also happens on staging or prod?

fedirjh · 2023-11-22T14:39:20Z

Can you verify if it also happens on staging or prod?

On staging I get the initial bug, the amount is displayed as $0 request:

CleanShot.2023-11-22.at.15.35.09.mp4

fedirjh · 2023-11-22T15:33:52Z

@tienifr I think I found the problem. It may be related to the backend?

Steps to reproduce :

Open report with a user or workspace.
Send new money request with currency USD and amount
Open money request report
Update the money request amount and currency to a different one
Navigate to another report and send a message
Log out
Login again
Check LHN, the money request report created in step 2 is displayed with the initial currency and amount.
Open the money request report
Check LHN and header are updated with the new currency and amount selected in step 4

Expected: LHN and money request header should display the correct data on the first load.

CleanShot.2023-11-22.at.16.24.43.mp4

fedirjh · 2023-11-22T23:50:48Z

@tienifr were you able to replicate the issue with these steps ?

tienifr · 2023-11-23T03:51:33Z

Thanks, working on it.

tienifr · 2023-11-24T16:19:58Z

Root cause is the changes in transaction details are not reflected in parent report action. There's no way we can retrieve them unless we open the transaction. I'm not sure if this is a BE bug. But if it's ok, I think it's safe just to fallback to Money request or TBD in any case.

fedirjh · 2023-11-24T18:17:59Z

Thank you @tienifr. It seems that we have limited options in this case.

cc @puneetlath I'd like your opinion on this. Currently, when a money request is updated (amount, date, etc.), the parentReportActionMessage doesn't reflect the changes, and this seems to be the intended behavior. Using the parentReportActionMessage as a fallback may show outdated data until the money request report is opened. Given our limited options, should we:

Use parentReportActionMessage as a fallback and accept that old data might be displayed.
Use Money request text as a fallback when the transaction is empty.

puneetlath · 2023-11-27T20:38:31Z

I think I prefer 2. It will be more consistent.

fedirjh

@tienifr Let's move it forward.

src/libs/ReportUtils.ts

Co-authored-by: Fedi Rajhi <fedirjh@gmail.com>

…0687

fedirjh · 2023-11-29T01:22:58Z

@tienifr Could you please merge main. It seems something was broken :

tienifr · 2023-11-29T06:54:16Z

@fedirjh Things work fine now!

fedirjh · 2023-11-29T14:32:34Z

Updated Screenshots/Videos

Android: Native

CleanShot.2023-11-29.at.15.26.48.mp4

Android: mWeb Chrome

CleanShot.2023-11-29.at.15.29.33.mp4

iOS: Native

CleanShot.2023-11-29.at.02.13.25.mp4

iOS: mWeb Safari

CleanShot.2023-11-29.at.14.25.13.mp4

MacOS: Chrome / Safari

CleanShot.2023-11-29.at.14.26.35.mp4

MacOS: Desktop

CleanShot.2023-11-29.at.14.28.57.mp4

fedirjh

Looks good to me and tests well.

OSBotify · 2023-11-30T16:36:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-01T12:56:37Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.4.7-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-05T02:27:00Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.7-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

tienifr added 2 commits November 14, 2023 17:39

fix: empty transaction data on open app

33b048d

get message from parent report action

bbe5c52

tienifr marked this pull request as ready for review November 14, 2023 13:06

tienifr requested a review from a team as a code owner November 14, 2023 13:06

melvin-bot bot requested review from fedirjh and removed request for a team November 14, 2023 13:06

tienifr mentioned this pull request Nov 14, 2023

[HOLD for payment 2023-12-12] [$500] Expense - Expense details report on LHN shows $0.00 request after logging out and logging in #30687

Closed

6 tasks

fedirjh reviewed Nov 20, 2023

View reviewed changes

tienifr added 2 commits November 22, 2023 00:33

Merge branch 'main' of https://github.com/tienifr/App into fix/30687

7c2efa5

Merge branch 'main' of https://github.com/tienifr/App into fix/30687

44179cc

add comment

4deb7a4

tienifr added 2 commits November 28, 2023 02:12

Merge branch 'main' into fix/30687

e9ab87d

fix typescript lint

6478fc5

shubham1206agra mentioned this pull request Nov 28, 2023

Distance - IOU report for changed details, title is not shown in LHN when user re-login #32111

Closed

6 tasks

fedirjh suggested changes Nov 28, 2023

View reviewed changes

src/libs/ReportUtils.ts Outdated Show resolved Hide resolved

tienifr and others added 3 commits November 29, 2023 03:34

Merge branch 'main' of https://github.com/tienifr/App into fix/30687

57b3f6b

Fallback to Request for empty transaction

e9fa9ff

Co-authored-by: Fedi Rajhi <fedirjh@gmail.com>

Merge branch 'fix/30687' of https://github.com/tienifr/App into fix/3…

63c40d5

…0687

modify comment

ad6fb76

Merge branch 'main' of https://github.com/tienifr/App into fix/30687

fb5e067

This comment was marked as outdated.

Sign in to view

This comment was marked as resolved.

Sign in to view

Merge branch 'main' of https://github.com/tienifr/App into fix/30687

9a1a91f

fedirjh approved these changes Nov 29, 2023

View reviewed changes

melvin-bot bot requested a review from puneetlath November 29, 2023 14:34

puneetlath approved these changes Nov 30, 2023

View reviewed changes

puneetlath merged commit 9d0de25 into Expensify:main Nov 30, 2023
16 checks passed

github-actions bot mentioned this pull request Dec 1, 2023

Deploy Checklist: New Expensify 2023-12-01 #32342

Closed

53 tasks

lanitochka17 mentioned this pull request Dec 1, 2023

[$500] LHN - Expense details report title does not show the amount in LHN after relogin #32382

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Empty transaction data on log in #31302

Fix: Empty transaction data on log in #31302

tienifr commented Nov 14, 2023 •

edited

Loading

melvin-bot bot commented Nov 14, 2023

tienifr commented Nov 17, 2023

fedirjh commented Nov 17, 2023 •

edited

Loading

fedirjh commented Nov 17, 2023

fedirjh Nov 20, 2023

tienifr commented Nov 22, 2023 •

edited

Loading

fedirjh commented Nov 22, 2023

fedirjh commented Nov 22, 2023

fedirjh commented Nov 22, 2023

tienifr commented Nov 23, 2023

tienifr commented Nov 24, 2023

fedirjh commented Nov 24, 2023

puneetlath commented Nov 27, 2023

fedirjh left a comment

fedirjh commented Nov 29, 2023

This comment was marked as outdated.

This comment was marked as resolved.

tienifr commented Nov 29, 2023

fedirjh commented Nov 29, 2023

fedirjh left a comment

OSBotify commented Nov 30, 2023

OSBotify commented Dec 1, 2023

OSBotify commented Dec 5, 2023

Fix: Empty transaction data on log in #31302

Fix: Empty transaction data on log in #31302

Conversation

tienifr commented Nov 14, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 14, 2023

tienifr commented Nov 17, 2023

fedirjh commented Nov 17, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

fedirjh commented Nov 17, 2023

fedirjh Nov 20, 2023

Choose a reason for hiding this comment

tienifr commented Nov 22, 2023 • edited Loading

fedirjh commented Nov 22, 2023

fedirjh commented Nov 22, 2023

fedirjh commented Nov 22, 2023

tienifr commented Nov 23, 2023

tienifr commented Nov 24, 2023

fedirjh commented Nov 24, 2023

puneetlath commented Nov 27, 2023

fedirjh left a comment

Choose a reason for hiding this comment

fedirjh commented Nov 29, 2023

This comment was marked as outdated.

This comment was marked as resolved.

tienifr commented Nov 29, 2023

fedirjh commented Nov 29, 2023

Updated Screenshots/Videos

fedirjh left a comment

Choose a reason for hiding this comment

OSBotify commented Nov 30, 2023

OSBotify commented Dec 1, 2023

OSBotify commented Dec 5, 2023

tienifr commented Nov 14, 2023 •

edited

Loading

fedirjh commented Nov 17, 2023 •

edited

Loading

tienifr commented Nov 22, 2023 •

edited

Loading