Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/30868: Incorrect group displayed #31424

Conversation

DylanDylann
Copy link
Contributor

@DylanDylann DylanDylann commented Nov 16, 2023

Details

  • Web - Chat- A different group chat appears when refreshing the page

Fixed Issues

$ #30868
PROPOSAL: #30868 (comment)

Tests

  1. Create a group conversation
  2. Type something
  3. Clicking on a profile
  4. Refresh the page
  5. The same group chat appears when refreshing the page
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  1. Create a group conversation
  2. Type something
  3. Clicking on a profile
  4. Refresh the page
  5. The same group chat appears when refreshing the page
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
  • Cannot test in Android Native
Android: mWeb Chrome
Screencast.from.23-11-2023.11.09.57.webm
iOS: Native
  • Cannot test in IOS native
iOS: mWeb Safari
Screencast.from.23-11-2023.11.14.36.webm
MacOS: Chrome / Safari
Screencast.from.23-11-2023.11.13.18.webm
MacOS: Desktop
Screencast.from.23-11-2023.19.01.40.webm

@shubham1206agra
Copy link
Contributor

@DylanDylann Can you post a video demo for the issue?

@DylanDylann
Copy link
Contributor Author

@DylanDylann Can you post a video demo for the issue?

Sure. Please wait a minute

@DylanDylann
Copy link
Contributor Author

@shubham1206agra Added video demo in MacOS: Chrome / Safari section. Please help check

@DylanDylann DylanDylann marked this pull request as ready for review November 23, 2023 09:10
@DylanDylann DylanDylann requested a review from a team as a code owner November 23, 2023 09:10
@melvin-bot melvin-bot bot requested review from shubham1206agra and removed request for a team November 23, 2023 09:11
Copy link

melvin-bot bot commented Nov 23, 2023

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@shubham1206agra
Copy link
Contributor

Hey
Can you confirm this problem?
When I go back, openReport is triggered again.
Doesn't seems to be happening on main

@DylanDylann
Copy link
Contributor Author

@shubham1206agra Just checked, I see that in staging, the API 'OpenReport' still called when clicking on "Back".
Screencast from 30-11-2023 02:15:30.webm

@shubham1206agra
Copy link
Contributor

shubham1206agra commented Nov 30, 2023

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

NA

Android: mWeb Chrome

NA

iOS: Native

NA

iOS: mWeb Safari
Screen.Recording.2023-11-30.at.8.11.31.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2023-11-30.at.8.02.45.PM.mov
MacOS: Desktop
Screen.Recording.2023-11-30.at.8.25.35.PM.mov

@melvin-bot melvin-bot bot requested a review from MonilBhavsar November 30, 2023 16:00
@shubham1206agra
Copy link
Contributor

@getusha Do you also want to soft review this?

@shubham1206agra
Copy link
Contributor

@DylanDylann Can you resolve conflicts quickly?

@DylanDylann
Copy link
Contributor Author

@shubham1206agra I just fixed

@shubham1206agra
Copy link
Contributor

@DylanDylann Steps to repro the error

  1. Log out
  2. Log in with different account
  3. See the skeleton infinitely

DylanDylann and others added 3 commits December 21, 2023 11:07
Co-authored-by: Shubham Agrawal <58412969+shubham1206agra@users.noreply.github.com>
Co-authored-by: Shubham Agrawal <58412969+shubham1206agra@users.noreply.github.com>
@shubham1206agra
Copy link
Contributor

@MonilBhavsar Now, you can proceed with final review.
I have rechecked and it works fine now

Copy link
Contributor

@MonilBhavsar MonilBhavsar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, else looks good!

src/libs/Navigation/AppNavigator/ReportScreenIDSetter.ts Outdated Show resolved Hide resolved
src/types/onyx/ReportMetadata.ts Outdated Show resolved Hide resolved
src/types/onyx/Report.ts Show resolved Hide resolved
@DylanDylann
Copy link
Contributor Author

@MonilBhavsar I just updated the PR

@MonilBhavsar
Copy link
Contributor

@DylanDylann the PR author checklist has been updated and you also need to update it

@DylanDylann
Copy link
Contributor Author

@MonilBhavsar I updated

@MonilBhavsar
Copy link
Contributor

PR Reviewer checklist also needs to be updated now cc @shubham1206agra

@shubham1206agra
Copy link
Contributor

Done

Copy link
Contributor

@MonilBhavsar MonilBhavsar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks all 🚀

@MonilBhavsar MonilBhavsar merged commit bcf6197 into Expensify:main Dec 29, 2023
16 of 17 checks passed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.4.20-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 cancelled 🔪
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Jan 2, 2024

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.20-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@@ -499,6 +499,7 @@ function openReport(
isLoadingInitialReportActions: true,
isLoadingOlderReportActions: false,
isLoadingNewerReportActions: false,
lastVisitTime: DateUtils.getDBTime(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of comments on this PR, I couldn't summarize all of them. Can anyone of you please help me understand why we are setting the lastVisitTime here in OpenReport? @shubham1206agra @DylanDylann @getusha

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MonilBhavsar! Just wanted to bump this question in case you know the answer or if you think anyone above would know the answer.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This proposal explains it #30868 (comment)
tldr; If user visits a chat and refereshes it, we want to display last visited chat and not some random chat. Last visited chat is determined by report.lastVisitTime. So whenever user opens the report, we update that property.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we are updating this in ReportScreen which loads the report. Question is why are we doing this in openAPI call?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be for somecase where that hook in ReportScreen is not trigerred. @DylanDylann could you please answer this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parasharrajat @MonilBhavsar

When I created this PR, setting lastVisitTime: DateUtils.getDBTime() in the openReport function did not cause any side effects. It was added to ensure that lastVisitTime is always updated whenever a report is opened but I also find any issue if we remove that line.

I just reviewed the code, I found that calling Report.updateLastVisitTime(reportID) alone is sufficient. Therefore, we can safely remove the lastVisitTime: DateUtils.getDBTime() parameter from openReport.

Copy link
Member

@parasharrajat parasharrajat Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Thanks. Let's try to cover these cases with code comments so that we don't have to go through this Q&A session. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants