Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextInput numberOfLines/maxNumberOfLines workaround (manually calculating maxHeight of TextInput #31483

Merged
merged 55 commits into from
Jan 25, 2024
Merged

TextInput numberOfLines/maxNumberOfLines workaround (manually calculating maxHeight of TextInput #31483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
2e421c7
Merge branch 'main' into @chrispader/number-of-lines-workaround
chrispader Nov 28, 2023
2a09811
update import
chrispader Nov 28, 2023
db57bf3
simplify android and ios implementations
chrispader Nov 28, 2023
170729c
Update Introducing-Expensify-Chat.md
MitchExpensify Nov 21, 2023
bbafbea
start migrating PlaidLink to TypeScript
JKobrynski Nov 3, 2023
231211a
migrate PlaidLinks native module to TypeScript, create a file for types
JKobrynski Nov 3, 2023
a88d047
migrate native PlaidLink to TypeScript
JKobrynski Nov 6, 2023
eacebd2
make onEvent a required prop to avoid optional chaining
JKobrynski Nov 7, 2023
8e62b62
remove unused nativeModule
JKobrynski Nov 17, 2023
a966eb3
pass event to Log.info
JKobrynski Nov 27, 2023
d755308
allow metadata to be undefined in onEvent
JKobrynski Nov 27, 2023
624875c
make publicToken required param
JKobrynski Nov 27, 2023
a8af74a
change eventName type to string
JKobrynski Nov 27, 2023
019cd14
Correct return types
MonilBhavsar Nov 27, 2023
b2f9eab
Fix lint
MonilBhavsar Nov 27, 2023
54b2c9b
fix type for activate card flow
pasyukevich Nov 22, 2023
c5584ec
removed an extra space
waterim Nov 28, 2023
dcc202a
update patches
chrispader Nov 28, 2023
09e2c45
fix ios
chrispader Nov 28, 2023
47318dc
update the comment
chrispader Nov 28, 2023
786a859
simplify ios implementation
chrispader Nov 28, 2023
3938bb6
simplify composer
chrispader Nov 28, 2023
a065840
Merge branch 'main' into @chrispader/number-of-lines-workaround
chrispader Nov 28, 2023
88ad1d9
remove unused changes
chrispader Nov 28, 2023
cbf1e66
remove empty line
chrispader Nov 28, 2023
d784b64
Merge branch 'main' into @chrispader/number-of-lines-workaround
chrispader Nov 30, 2023
42bf5bc
Merge branch 'main' into @chrispader/number-of-lines-workaround
Dec 2, 2023
8d44ecd
remove unused style
Dec 2, 2023
cb7785b
don't build android from source
Dec 3, 2023
558dbee
remove patch
Dec 5, 2023
d5af3c9
Merge branch 'main' into @chrispader/number-of-lines-workaround
Dec 5, 2023
76b981c
Merge branch 'main' into @chrispader/number-of-lines-workaround
Dec 8, 2023
58f8ce0
Merge branch 'main' into @chrispader/number-of-lines-workaround
Dec 14, 2023
e77ccd0
Merge branch 'main' into @chrispader/number-of-lines-workaround
hannojg Jan 4, 2024
fe1aaf6
Merge branch 'main' into @chrispader/number-of-lines-workaround
chrispader Jan 9, 2024
e9f6632
Merge branch '@chrispader/number-of-lines-workaround' of github.com:m…
chrispader Jan 9, 2024
bd00372
remove empty line
chrispader Jan 9, 2024
0384181
add back empty lien at EOF
chrispader Jan 9, 2024
0ae5f90
Merge branch 'main' into @chrispader/number-of-lines-workaround
Jan 12, 2024
ec6515b
Merge branch 'main' into @chrispader/number-of-lines-workaround
Jan 12, 2024
d872300
remove empty line
Jan 12, 2024
0bb8337
add empty line
Jan 12, 2024
c3676a7
rename prop
Jan 12, 2024
7b24b41
Merge branch 'main' into @chrispader/number-of-lines-workaround
Jan 18, 2024
f2fc0de
revert rows prop change
chrispader Jan 18, 2024
5369db0
Merge branch 'main' into @chrispader/number-of-lines-workaround
chrispader Jan 19, 2024
c526fd3
Merge branch '@chrispader/number-of-lines-workaround'
Jan 19, 2024
8f5f879
fix: prop
Jan 19, 2024
87c1110
Merge branch 'main' into @chrispader/number-of-lines-workaround
Jan 19, 2024
55c795d
Merge branch 'main' into @chrispader/number-of-lines-workaround
Jan 23, 2024
7c0c1d3
Merge branch 'main' into @chrispader/number-of-lines-workaround
chrispader Jan 23, 2024
8ac8717
Merge branch 'main' into @chrispader/number-of-lines-workaround
chrispader Jan 23, 2024
706336a
update Podfile.lock
chrispader Jan 23, 2024
0302070
Merge branch 'main' into @chrispader/number-of-lines-workaround
chrispader Jan 24, 2024
b96878c
Merge branch 'main' into @chrispader/number-of-lines-workaround
Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions android/settings.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,5 @@ apply from: file("../node_modules/@react-native-community/cli-platform-android/n
include ':app'
includeBuild('../node_modules/@react-native/gradle-plugin')

includeBuild('../node_modules/react-native') {
dependencySubstitution {
substitute(module("com.facebook.react:react-android")).using(project(":packages:react-native:ReactAndroid"))
substitute(module("com.facebook.react:react-native")).using(project(":packages:react-native:ReactAndroid"))
substitute(module("com.facebook.react:hermes-android")).using(project(":packages:react-native:ReactAndroid:hermes-engine"))
substitute(module("com.facebook.react:hermes-engine")).using(project(":packages:react-native:ReactAndroid:hermes-engine"))
}
}

apply from: new File(["node", "--print", "require.resolve('expo/package.json')"].execute(null, rootDir).text.trim(), "../scripts/autolinking.gradle")
useExpoModules()
useExpoModules()
2 changes: 1 addition & 1 deletion ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1967,7 +1967,7 @@ SPEC CHECKSUMS:
SocketRocket: f32cd54efbe0f095c4d7594881e52619cfe80b17
Turf: 13d1a92d969ca0311bbc26e8356cca178ce95da2
VisionCamera: 7d13aae043ffb38b224a0f725d1e23ca9c190fe7
Yoga: e64aa65de36c0832d04e8c7bd614396c77a80047
Yoga: 13c8ef87792450193e117976337b8527b49e8c03
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAB: this change is irrelevant to this PR


PODFILE CHECKSUM: 0ccbb4f2406893c6e9f266dc1e7470dcd72885d2

Expand Down
Loading
Loading