Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONSTS to direct developers to use role instead of accessibilityRole #31590

Merged
merged 28 commits into from
Dec 12, 2023
Merged

Update CONSTS to direct developers to use role instead of accessibilityRole #31590

merged 28 commits into from
Dec 12, 2023

Commits on Nov 17, 2023

  1. fix(ACCESSIBILITY_ROLE): Deprecate ACCESSIBLITY_ROLE

    @trevor-coleman
    trevor-coleman committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    977257a View commit details
    Browse the repository at this point in the history

  2. fix(ACCESSIBILITY_ROLE): Add CONST.ROLE

    @trevor-coleman
    trevor-coleman committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    0b1c973 View commit details
    Browse the repository at this point in the history

  3. fix(ACCESSIBILITY_ROLE): fix formatting in JSDoc comment

    @trevor-coleman
    trevor-coleman committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    9fbda55 View commit details
    Browse the repository at this point in the history

  4. fix(ACCESSIBILITY_ROLE): redirect role props that point to `ACCESSI… 

    …BLITY_ROLE.TEXT` to point to `ROLE.PRESENTATION`
    @trevor-coleman
    trevor-coleman committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    7743c4c View commit details
    Browse the repository at this point in the history

  5. fix(ACCESSIBILITY_ROLE): fix role attributes being passed invalid `im… 

    …g button` value by reverting them to `accessibilityRole`
    @trevor-coleman
    trevor-coleman committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    30335de View commit details
    Browse the repository at this point in the history

  6. fix(ACCESSIBILITY_ROLE): reset ADJUSTABLE TO 'adjustable'

    @trevor-coleman
    trevor-coleman committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    ce403f1 View commit details
    Browse the repository at this point in the history

  7. fix(ACCESSIBILITY_ROLE): set role prop to use CONST.ROLE instead of d… 

    …eprecatd CONST.ACCESSIBLITY_ROLE
    @trevor-coleman
    trevor-coleman committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    b72ac43 View commit details
    Browse the repository at this point in the history

  8. fix(ACCESSIBILITY_ROLE): set role prop to use CONST.ROLE instead of d… 

    …eprecatd CONST.ACCESSIBLITY_ROLE
    @trevor-coleman
    trevor-coleman committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    5811816 View commit details
    Browse the repository at this point in the history

  9. fix(ACCESSIBILITY_ROLE): set role prop to use CONST.ROLE instead of d… 

    …eprecatd CONST.ACCESSIBLITY_ROLE
    @trevor-coleman
    trevor-coleman committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    911c4b3 View commit details
    Browse the repository at this point in the history

  10. fix(ACCESSIBILITY_ROLE): set role props to use CONST.ROLE instead of … 

    …deprecatd CONST.ACCESSIBLITY_ROLE
    @trevor-coleman
    trevor-coleman committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    f3a8a4e View commit details
    Browse the repository at this point in the history

  11. fix(ACCESSIBILITY_ROLE): replace reference to deprecatd CONST.ACCESSI… 

    …BLITY_ROLE with CONST.ROLE
    @trevor-coleman
    trevor-coleman committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    c2892ec View commit details
    Browse the repository at this point in the history

  12. fix(ACCESSIBILITY_ROLE): replace accessibilityRole with role

    @trevor-coleman
    trevor-coleman committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    6931552 View commit details
    Browse the repository at this point in the history

  13. fix(ACCESSIBILITY_ROLE): replace accessibilityRole with role

    @trevor-coleman
    trevor-coleman committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    35eae47 View commit details
    Browse the repository at this point in the history

  14. fix(ACCESSIBILITY_ROLE): replace accessibilityRole with role

    @trevor-coleman
    trevor-coleman committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    de4b4c0 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. prettier

    @trevor-coleman
    trevor-coleman committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    b60079b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into trevorcoleman/accessibility-role 

    Signed-off-by: Trevor Coleman <trevor@trevorcoleman.design>
    @trevor-coleman
    trevor-coleman authored Nov 20, 2023
    Configuration menu
    Copy the full SHA
    0639e66 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #74 from infinitered/trevorcoleman/accessibility-role 

    Update CONSTS to direct developers to use role instead of accessibilityRole (Expensify#31500)
    @trevor-coleman
    trevor-coleman authored Nov 20, 2023
    Configuration menu
    Copy the full SHA
    2336f3b View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Merge remote-tracking branch 'upstream/main' into accessibility-role 

    # Conflicts:
#	src/components/AvatarWithImagePicker.js
#	src/components/Banner.tsx
#	src/components/Checkbox.js
#	src/components/ParentNavigationSubtitle.tsx
#	src/components/ReportHeaderSkeletonView.tsx
#	src/pages/ReimbursementAccount/BankAccountManualStep.js
#	src/pages/settings/Profile/PersonalDetails/AddressPage.js
    @trevor-coleman
    trevor-coleman committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    244f634 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. fix: remove empty checkbox.js

    @trevor-coleman
    trevor-coleman committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    5da2a42 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into accessibility-role 

    # Conflicts:
#	src/components/RadioButton.tsx
#	src/pages/settings/Wallet/AddDebitCardPage.js
    @trevor-coleman
    trevor-coleman committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    c21a9c7 View commit details
    Browse the repository at this point in the history

  3. fix: remove accessibilityLabel

    @trevor-coleman
    trevor-coleman committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    a4f0762 View commit details
    Browse the repository at this point in the history

  4. fix: remove accessibilityLabel

    @trevor-coleman
    trevor-coleman committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    cc18c93 View commit details
    Browse the repository at this point in the history

  5. test commit

    @trevor-coleman
    trevor-coleman committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    0c8e6b4 View commit details
    Browse the repository at this point in the history

  6. revert test commit

    @trevor-coleman
    trevor-coleman committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    1214c03 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. Merge branch 'main' into accessibility-role

    @trevor-coleman
    trevor-coleman authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    fe947d3 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. Merge remote-tracking branch 'origin/main' into accessibility-role 

    # Conflicts:
#	src/components/DatePicker/index.android.js
#	src/components/DatePicker/index.ios.js
#	src/components/DatePicker/index.js
#	src/components/HTMLEngineProvider/HTMLRenderers/MentionUserRenderer.js
#	src/components/RoomNameInput/index.native.js
    @trevor-coleman
    trevor-coleman committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    6aff307 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into accessibility-role 

    # Conflicts:
#	src/components/ReportActionItem/ReportActionItemImage.js
#	src/pages/settings/Security/CloseAccountPage.js
    @trevor-coleman
    trevor-coleman committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    054eb86 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. Merge branch 'main' of github.com:Expensify/App into accessibility-role

    @trevor-coleman
    trevor-coleman committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    4ad45b3 View commit details
    Browse the repository at this point in the history