-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS migration] Migrate 'TaskHeaderActionButton.js' component to TypeScript #31910
[TS migration] Migrate 'TaskHeaderActionButton.js' component to TypeScript #31910
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
isDisabled={!Task.canModifyTask(report, session?.accountID ?? 0)} | ||
medium | ||
text={translate(ReportUtils.isCompletedTaskReport(report) ? 'task.markAsIncomplete' : 'task.markAsComplete')} | ||
onPress={() => (ReportUtils.isCompletedTaskReport(report) ? Task.reopenTask(report) : Task.completeTask(report))} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please apply changes from #31527
Also add anonymous user case in Tests/QA step
And pull main |
@aimane-chnaif Thank you, done! I've updated the test steps and recordings as well |
@aimane-chnaif kind bump 🙂 |
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid.movAndroid: mWeb Chromemchrome.moviOS: Nativeios.moviOS: mWeb Safarimsafari.movMacOS: Chrome / Safariweb.movMacOS: Desktopdesktop.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
We did not find an internal engineer to review this PR, trying to assign a random engineer to #25087 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/NikkiWines in version: 1.4.9-0 🚀
|
1 similar comment
🚀 Deployed to staging by https://github.com/NikkiWines in version: 1.4.9-0 🚀
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.9-5 🚀
|
Details
[TS migration] Migrate 'TaskHeaderActionButton.js' component to TypeScript
Fixed Issues
$ #25087
PROPOSAL: N/A
Tests
First test case:
2.1 FAB button -> Assign Task
2.2 Enter any task title
2.3 Add any user as an assignee
2.4 Confirm task
Second test case:
Offline tests
N/A
QA Steps
First test case:
2.1 FAB button -> Assign Task
2.2 Enter any task title
2.3 Add any user as an assignee
2.4 Confirm task
Second test case:
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mp4
android.mp4
Android: mWeb Chrome
android.web.mp4
android_web.mp4
iOS: Native
ios.mp4
ios.mp4
iOS: mWeb Safari
ios.web.mp4
ios_web.mp4
MacOS: Chrome / Safari
web.mp4
web.mp4
MacOS: Desktop
desktop.mp4
desktop.mp4