-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS migration] Migrate 'BigNumberPad.js' component to TypeScript #32117
[TS migration] Migrate 'BigNumberPad.js' component to TypeScript #32117
Conversation
src/components/BigNumberPad.tsx
Outdated
// eslint-disable-next-line react/no-array-index-key | ||
key={`NumberPadRow-${rowIndex}`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can get rid of the index in the key, for example, by using the first value of the row
// eslint-disable-next-line react/no-array-index-key | |
key={`NumberPadRow-${rowIndex}`} | |
key={`NumberPadRow-${row[0]}`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2023-12-04.at.2.07.24.AM.movAndroid: mWeb ChromeScreen.Recording.2023-12-04.at.2.06.49.AM.moviOS: NativeScreen.Recording.2023-12-04.at.2.05.48.AM.moviOS: mWeb SafariScreen.Recording.2023-12-04.at.2.05.10.AM.movMacOS: Chrome / SafariScreen.Recording.2023-12-04.at.1.57.29.AM.movMacOS: DesktopScreen.Recording.2023-12-04.at.1.59.44.AM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
We did not find an internal engineer to review this PR, trying to assign a random engineer to #25032 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 1.4.7-4 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to staging by https://github.com/joelbettner in version: 1.4.8-0 🚀
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.8-3 🚀
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.8-3 🚀
|
Details
Fixed Issues
$ #25032
PROPOSAL: N/A
Tests
Offline tests
Same as above.
QA Steps
Same as above.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2023-11-28.at.10.12.52.mov
Android: mWeb Chrome
Screen.Recording.2023-11-28.at.10.15.36.mov
iOS: Native
Screen.Recording.2023-11-28.at.10.16.34.mov
iOS: mWeb Safari
Screen.Recording.2023-11-28.at.10.17.21.mov
MacOS: Chrome / Safari
MacOS: Desktop