Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add full screen engagement modal to NewDot #32154
Add full screen engagement modal to NewDot #32154
Changes from all commits
71aaa5a
38f9c59
d387417
94aa8f8
01629a2
96dc71e
2e6ab73
39b3593
2c21559
cc9aead
7f32222
1d2ff01
5fb78b8
877efb9
5f921af
cfad7cc
0ef6e32
d31d697
6ac457b
91120f9
0def96f
e5ef2b4
9e49cee
73fb919
01ce5e3
e8296c4
60c13dc
6855f21
bb36f6e
f7dcb5e
9abcb6d
dabb866
a1e53cc
0a81573
0773d9e
e52c81e
08e8843
14f532a
4d70303
c68d728
17dbbe6
7b31ef9
356db31
2ba2966
1f3420c
874543f
728e215
30ea7b5
ca904e0
489b148
4de8c5b
d6d06ce
cf1a9ec
82b26ad
30f88f8
4e0eb0d
37e1e78
fdf8429
23b3f89
6176876
9adf07d
daf05b6
998c2e9
8f15ee3
eb0d5cc
3ca872a
5bdc2c6
cf23709
4df4d3a
8ac48cb
6cc3f5c
aa6398a
37ff12a
c0a737b
cbd3db5
69ccc51
a02c8ae
a248b46
6d260df
1569ef6
d571914
50ce52a
f216232
6f8ccf0
bca21af
0055dee
8c59d64
6ca99b0
58a4e52
4e9d290
b41489d
fe2625e
189bae9
9e86e8e
7edb569
9ec0c2a
0b6bf56
eda0fe7
47c32f4
82b5552
a526027
cf5f181
2502778
49b6915
9bd6e2e
5fa2403
a313c40
da884be
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add context behind this logic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is a route, we don't want to show the modal unless the page we're on is home or the central pane navigator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok so #32154 (review) is correct. Just wanted to confirm 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep that's correct! Thanks for double checking :)