-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS migration] Migrate 'ReportActionItemDraft.js' component to TypeScript #32194
[TS migration] Migrate 'ReportActionItemDraft.js' component to TypeScript #32194
Conversation
df4c3d9
to
c5cf590
Compare
c5cf590
to
d3b47a3
Compare
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2023-12-06.at.12.10.34.PM.movAndroid: mWeb ChromeScreen.Recording.2023-12-06.at.12.15.44.PM.moviOS: NativeScreen.Recording.2023-12-06.at.12.29.58.PM.moviOS: mWeb SafariScreen.Recording.2023-12-06.at.12.19.36.PM.movMacOS: Chrome / SafariScreen.Recording.2023-12-06.at.11.51.49.AM.movMacOS: DesktopScreen.Recording.2023-12-06.at.11.56.15.AM.mov |
We did not find an internal engineer to review this PR, trying to assign a random engineer to #31930 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/johnmlee101 in version: 1.4.9-0 🚀
|
1 similar comment
🚀 Deployed to staging by https://github.com/johnmlee101 in version: 1.4.9-0 🚀
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.9-5 🚀
|
Details
Fixed Issues
$ #31930
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android-native-converted.webm
Android: mWeb Chrome
android-web-converted.webm
iOS: Native
ios-native-converted.mp4
iOS: mWeb Safari
ios-web-converted.mp4
MacOS: Chrome / Safari
desktop-web-converted.mov
MacOS: Desktop
desktop-native-converted.mov