[TS migration] Migrate 'BlockingViews' component to TypeScript #32253

cdOut · 2023-11-30T11:28:17Z

Details

Fixed Issues

$ #25133

Tests

Log into the app, click through main flows to see whether they are performing as expected, since components migrated here are used all throughout the app as a wrapper to other screens / modals.
FullPageNotFoundView can be checked when going into Settings > Profile, that view is based on it.
FullPageOfflineBlockingView can be checked when going into Settings > Wallet and pressing Enable wallet.
BlockingView is part of the two others so if these work then this base component also works.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Log into the app, click through main flows to see whether they are performing as expected, since components migrated here are used all throughout the app as a wrapper to other screens / modals.
FullPageNotFoundView can be checked when going into Settings > Profile, that view is based on it.
FullPageOfflineBlockingView can be checked when going into Settings > Wallet and pressing Enable wallet.
BlockingView is part of the two others so if these work then this base component also works.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

ANDROID-NATIVE.mov

Android: mWeb Chrome

ANDROID-CHROME.mov

iOS: Native

IOS-NATIVE.mov

iOS: mWeb Safari

IOS-SAFARI.mov

MacOS: Chrome / Safari

CHROME.mov

MacOS: Desktop

DESKTOP.mov

cdOut · 2023-11-30T11:30:08Z

Text and TextLink are here temporarily, they were migrated in another issue. Will remove them after the referenced issue PR gets merged.

src/components/Text.tsx

src/components/BlockingViews/FullPageOfflineBlockingView.tsx

src/components/TextLink.tsx

src/components/BlockingViews/FullPageNotFoundView.tsx

merge main into ts-migration/blocking-view

cdOut · 2023-12-12T18:58:40Z

Text and TextLink are here temporarily, they were migrated in another issue. Will remove them after the referenced issue PR gets merged.

All files related to the TS migration of TextLink were migrated from main since the blocking issue was merged.

blazejkustra

LGTM, please update tests and QA sections in the description 😄

src/components/BlockingViews/BlockingView.tsx

src/components/BlockingViews/FullPageNotFoundView.tsx

merge main into ts-migration/blocking-view

VickyStash

LGTM 👍, please don't forget to add test steps/screenshots

melvin-bot · 2023-12-15T12:09:15Z

@0xmiroslav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

cdOut · 2023-12-19T03:09:14Z

cc: @0xmiroslav

0xmiros · 2023-12-21T10:08:34Z

reviewing today

0xmiros · 2023-12-25T17:45:31Z

Code looks good. But there's conflict

cdOut · 2023-12-28T07:26:46Z

@0xmiroslav merged and fixed conflicts

0xmiros · 2023-12-29T06:32:38Z

@cdOut Tests/QA Steps is not clear. It would be good to add example case where not found page shows.
i.e. https://staging.new.expensify.com/test, https://staging.new.expensify.com/statements/202312 (for offline blocking)

0xmiros · 2023-12-29T07:11:34Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2023-12-29T07:11:49Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #25133 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

0xmiros

@joelbettner all yours

joelbettner

👍 LGTM

rayane-djouah · 2023-12-30T14:43:57Z

Type check related to this PR is failing on main @cdOut @0xmiroslav @joelbettner
https://github.com/Expensify/App/actions/runs/7361091320/job/20038029363

OSBotify · 2024-01-02T23:51:04Z

🚀 Deployed to staging by https://github.com/joelbettner in version: 1.4.21-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-01-04T18:53:40Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-01-04T19:18:30Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-01-04T20:15:57Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

migrate BlockingView and associated components to ts

2b40a50

blazejkustra suggested changes Dec 4, 2023

View reviewed changes

cdOut added 3 commits December 7, 2023 15:21

fix review suggestions

618b949

remove files from another PR

0fe0448

Merge branch 'main' into ts-migration/blocking-view

57bebf0

merge main into ts-migration/blocking-view

blazejkustra approved these changes Dec 13, 2023

View reviewed changes

VickyStash reviewed Dec 13, 2023

View reviewed changes

cdOut added 2 commits December 13, 2023 19:54

add review suggested changes

53ce402

Merge branch 'main' into ts-migration/blocking-view

2fffff7

merge main into ts-migration/blocking-view

VickyStash approved these changes Dec 14, 2023

View reviewed changes

cdOut marked this pull request as ready for review December 15, 2023 12:09

cdOut requested a review from a team as a code owner December 15, 2023 12:09

melvin-bot bot requested review from 0xmiros and removed request for a team December 15, 2023 12:09

cdOut added 2 commits December 28, 2023 08:11

Merge branch 'main' into ts-migration/blocking-view

d109836

fix typescript errors

ad34368

0xmiros approved these changes Dec 29, 2023

View reviewed changes

melvin-bot bot requested a review from joelbettner December 29, 2023 07:14

joelbettner approved these changes Dec 30, 2023

View reviewed changes

joelbettner merged commit 8cb48e4 into Expensify:main Dec 30, 2023
17 checks passed

fedirjh mentioned this pull request Dec 30, 2023

[TS migration] Migrate 'TextInput' component to TypeScript #31356

Merged

50 tasks

rayane-djouah mentioned this pull request Dec 30, 2023

[TS migration] Migrate 'ReportActionItemSingle.js' component to TypeScript #33552

Merged

52 tasks

github-actions bot mentioned this pull request Jan 2, 2024

Deploy Checklist: New Expensify 2024-01-02 #33855

Closed

58 tasks

kbecciv mentioned this pull request Jan 3, 2024

[$500] Web - Wallet - BlockingViews component has grey background and another animation #33905

Closed

6 tasks

melvin-bot bot mentioned this pull request Jan 4, 2024

[$500] [HOLD for payment 2024-01-11] [TS migration] Migrate 'BlockingViews' component to TypeScript #25133

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TS migration] Migrate 'BlockingViews' component to TypeScript #32253

[TS migration] Migrate 'BlockingViews' component to TypeScript #32253

cdOut commented Nov 30, 2023 •

edited

Loading

cdOut commented Nov 30, 2023

cdOut commented Dec 12, 2023

blazejkustra left a comment

VickyStash left a comment

melvin-bot bot commented Dec 15, 2023

cdOut commented Dec 19, 2023

0xmiros commented Dec 21, 2023

0xmiros commented Dec 25, 2023

cdOut commented Dec 28, 2023

0xmiros commented Dec 29, 2023

0xmiros commented Dec 29, 2023

melvin-bot bot commented Dec 29, 2023

0xmiros left a comment

joelbettner left a comment

rayane-djouah commented Dec 30, 2023

OSBotify commented Jan 2, 2024

OSBotify commented Jan 4, 2024

OSBotify commented Jan 4, 2024

OSBotify commented Jan 4, 2024

[TS migration] Migrate 'BlockingViews' component to TypeScript #32253

[TS migration] Migrate 'BlockingViews' component to TypeScript #32253

Conversation

cdOut commented Nov 30, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

cdOut commented Nov 30, 2023

cdOut commented Dec 12, 2023

blazejkustra left a comment

Choose a reason for hiding this comment

VickyStash left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Dec 15, 2023

cdOut commented Dec 19, 2023

0xmiros commented Dec 21, 2023

0xmiros commented Dec 25, 2023

cdOut commented Dec 28, 2023

0xmiros commented Dec 29, 2023

0xmiros commented Dec 29, 2023

Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented Dec 29, 2023

0xmiros left a comment

Choose a reason for hiding this comment

joelbettner left a comment

Choose a reason for hiding this comment

rayane-djouah commented Dec 30, 2023

OSBotify commented Jan 2, 2024

OSBotify commented Jan 4, 2024

OSBotify commented Jan 4, 2024

OSBotify commented Jan 4, 2024

cdOut commented Nov 30, 2023 •

edited

Loading