fix: prevent default action of Enter key when selecting an emoji #32324

s-alves10 · 2023-12-01T00:43:21Z

Details

Prevent default action of Enter key event when selecting an emoji by Enter

Fixed Issues

$ #31210
PROPOSAL: #31210 (comment)

Tests

Open ND and log in with any account
Go to any chat
[WEB AND DESKTOP]Tap on the Emoji button to open the EmojiPicker
[WEB AND DESKTOP]Navigate to an emoji with Tab key
[WEB AND DESKTOP]Press Enter
[WEB AND DESKTOP]Verify that a new line isn't created in the main composer

Verify that no errors appear in the JS console

Offline tests

Open ND and log in with any account
Go to any chat
Tap on the Emoji button to open the EmojiPicker
Navigate to an emoji with Tab key
Press Enter
Verify that a new line isn't created in the main composer

QA Steps

Open ND and log in with any account
Go to any chat
Tap on the Emoji button to open the EmojiPicker
Navigate to an emoji with Tab key
Press Enter
Verify that a new line isn't created in the main composer

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

31210_android_native.mp4

Android: mWeb Chrome

31210_android_chrome.mp4

iOS: Native

31210_ios_native.mp4

iOS: mWeb Safari

31210_ios_safari.mp4

MacOS: Chrome / Safari

31210_mac_chrome.mp4

MacOS: Desktop

31210_mac_desktop.mp4

melvin-bot · 2023-12-01T01:05:38Z

@ntdiary Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

s-alves10 · 2023-12-04T18:35:17Z

@ntdiary

Will you take a look at the PR?

ntdiary · 2023-12-05T02:48:11Z

@ntdiary

Will you take a look at the PR?

@s-alves10, yeah, will review soon. :)

ntdiary · 2023-12-05T02:54:31Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

32324-adnroid-app.mp4

Android: mWeb Chrome

32324-android-chrome.mp4

iOS: Native

32324-ios-app.mp4

iOS: mWeb Safari

32324-ios-safari.mp4

MacOS: Chrome / Safari

32324-web.mp4

MacOS: Desktop

32324-desktop.mp4

ntdiary · 2023-12-05T04:45:40Z

test.mp4

Well, the same test steps yield different behavior on Android chrome. Pressing Enter will input two same emojis.
If we use the second solution in my comment, this problem will also be fixed.
@s-alves10, @flodnv, do you have any different thoughts on this problem? 🤔

s-alves10 · 2023-12-05T09:38:49Z

@ntdiary

The root cause of the issue you mentioned looks like the keyboard event is propagated. So I suggest to add the following code

        keyBoardEvent.stopPropagation();

This works fine as well. I updated the PR. Please check again

ntdiary

Let's add some comments to explain these changes. :)

src/components/EmojiPicker/EmojiPickerMenu/index.js

s-alves10 · 2023-12-06T11:19:07Z

@ntdiary

Comments were added. Please take a look.
Thanks

ntdiary

LGTM. :)

flodnv

Not A Blocker - we usually add empty lines before our comments

OSBotify · 2023-12-06T15:08:30Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-06T22:18:31Z

🚀 Deployed to staging by https://github.com/flodnv in version: 1.4.9-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-06T23:12:42Z

🚀 Deployed to staging by https://github.com/flodnv in version: 1.4.9-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-08T01:09:48Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.9-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

sangar-1028 added 3 commits November 30, 2023 16:33

fix: prevent default action of Enter key when selecting an emoji

299876d

fix: wrong spelling

8048ccf

fix: unit-test for calendar picker

9a3bb74

s-alves10 marked this pull request as ready for review December 1, 2023 01:05

s-alves10 requested a review from a team as a code owner December 1, 2023 01:05

melvin-bot bot requested review from ntdiary and removed request for a team December 1, 2023 01:05

s-alves10 mentioned this pull request Dec 1, 2023

[HOLD for payment 2023-12-15] [$500] Chat - A new line is created in the composer after emoji selection with Tab key #31210

Closed

6 tasks

fix: conflicts

48fbb67

sangar-1028 added 2 commits December 5, 2023 03:40

merge with main

79eb8bc

fix: stop propagation of keyboard enter event

8405c18

ntdiary reviewed Dec 6, 2023

View reviewed changes

src/components/EmojiPicker/EmojiPickerMenu/index.js Show resolved Hide resolved

src/components/EmojiPicker/EmojiPickerMenu/index.js Show resolved Hide resolved

fix: add comments

b9ac193

ntdiary approved these changes Dec 6, 2023

View reviewed changes

melvin-bot bot requested a review from flodnv December 6, 2023 14:36

flodnv approved these changes Dec 6, 2023

View reviewed changes

flodnv merged commit 2feaac8 into Expensify:main Dec 6, 2023
16 of 18 checks passed

github-actions bot mentioned this pull request Dec 6, 2023

Deploy Checklist: New Expensify 2023-12-06 #32589

Closed

74 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: prevent default action of Enter key when selecting an emoji #32324

fix: prevent default action of Enter key when selecting an emoji #32324

s-alves10 commented Dec 1, 2023

melvin-bot bot commented Dec 1, 2023

s-alves10 commented Dec 4, 2023

ntdiary commented Dec 5, 2023

ntdiary commented Dec 5, 2023 •

edited

Loading

ntdiary commented Dec 5, 2023

s-alves10 commented Dec 5, 2023 •

edited

Loading

ntdiary left a comment

s-alves10 commented Dec 6, 2023

ntdiary left a comment

flodnv left a comment

OSBotify commented Dec 6, 2023

OSBotify commented Dec 6, 2023

OSBotify commented Dec 6, 2023

OSBotify commented Dec 8, 2023

fix: prevent default action of Enter key when selecting an emoji #32324

fix: prevent default action of Enter key when selecting an emoji #32324

Conversation

s-alves10 commented Dec 1, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 1, 2023

s-alves10 commented Dec 4, 2023

ntdiary commented Dec 5, 2023

ntdiary commented Dec 5, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

ntdiary commented Dec 5, 2023

s-alves10 commented Dec 5, 2023 • edited Loading

ntdiary left a comment

Choose a reason for hiding this comment

s-alves10 commented Dec 6, 2023

ntdiary left a comment

Choose a reason for hiding this comment

flodnv left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 6, 2023

OSBotify commented Dec 6, 2023

OSBotify commented Dec 6, 2023

OSBotify commented Dec 8, 2023

ntdiary commented Dec 5, 2023 •

edited

Loading

s-alves10 commented Dec 5, 2023 •

edited

Loading