[Wave8] Create a Workspace Card #32339

MaciejSWM · 2023-12-01T11:51:58Z

Details

This PR introduces new Ideal Nav component: WorkspaceCardCreateAWorkspace.tsx.

It's just the component for further use in Ideal Nav project. To render it somewhere, add the code below to SidebarLinks.js:

// Import
import PressableWithFeedback from '@components/Pressable/PressableWithFeedback';
import Text from '@components/Text';
import WorkspaceCardCreateAWorkspace from '@pages/workspace/card/WorkspaceCardCreateAWorkspace';
// Import

            <View style={[styles.mh4, styles.flexRow, styles.justifyContentBetween, styles.alignItemsCenter, styles.mb3]}>
                <Text
                    style={styles.label}
                    color={theme.textSupporting}
                >
                    Workspace
                </Text>
                <PressableWithFeedback accessibilityRole={CONST.ACCESSIBILITY_ROLE.BUTTON}>
                    {({hovered}) => (
                        <Icon
                            src={Expensicons.Plus}
                            width={12}
                            height={12}
additionalStyles={[styles.buttonDefaultBG, styles.borderRadiusNormal, styles.p2, hovered && styles.buttonHoveredBG]}
                        />
                    )}
                </PressableWithFeedback>
            </View>
            <WorkspaceCardCreateAWorkspace />

// themes.js update so that the sidebar BG is consistent with Figma
+ change `sidebar: colors.productDark200,` to `sidebar: sidebar: colors.productDark100,`
+ change `sidebar: colors.productLight200,`, to `sidebar: colors.productLight100,`
// themes.js update

Fixed Issues

$ #31766
PROPOSAL:

Tests

Verify that no errors appear in the JS console
Plus icon and the Get Started button should have Touchable effects on them. On press behaviour is not part of this PR though - clicking them won't do anything so far.

Offline tests

Same as Tests

QA Steps

Verify that no errors appear in the JS console
Check the margins and paddings and sizes against Figma designs.
Click on Plus icon and the Get Started buttons - validate that Touchable effects are visible.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2023-12-04T09:58:12Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MaciejSWM · 2023-12-04T10:07:27Z

Slack discussion: https://swmansion.slack.com/archives/C036QM0SLJK/p1701684433873469

MaciejSWM · 2023-12-04T15:39:05Z

Conclusions from slack discussion: For now two variants are OK - so iconPosition should stay. In the future cards will be unified to only have a single style.

MaciejSWM · 2023-12-04T17:11:31Z

Spanish translations slack thread: https://expensify.slack.com/archives/C01GTK53T8Q/p1701709855624649

MaciejSWM · 2023-12-05T12:16:28Z

@dannymcclain @shawnborton ready for your design check

shawnborton · 2023-12-05T13:27:01Z

For the small button here:

Can we confirm that it is using our standard button styles? It seems like the background color is incorrect. Also to confirm, it should be 28x28.

shawnborton · 2023-12-05T13:27:56Z

@dannymcclain @dubielzyk-expensify does the space between the headline and the text look right to you?

I think I was imagining those would be closer. Here is what we had in Figma:

shawnborton · 2023-12-05T13:28:20Z

I think that means we want a "normal" sized button in that card too, which is 40px tall

dubielzyk-expensify · 2023-12-06T04:10:08Z

Looks good to me!

MaciejSWM · 2023-12-13T11:26:04Z

@shawnborton thanks, I adjusted and double checked everything you mentioned. Result:

src/components/Section.js

src/pages/workspace/card/WorkspaceCardCreateAWorkspace.tsx

src/components/Section.js

MaciejSWM · 2023-12-18T16:44:19Z

aimane-chnaif · 2023-12-20T08:12:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

aimane-chnaif

LGTM 🎉

mountiny

thanks, seems like @shawnborton has agreed with the design here too so just one question

mountiny · 2023-12-20T12:28:31Z

src/components/Section/IconSection.js

+import PropTypes from 'prop-types';
+import React from 'react';
+import {View} from 'react-native';
+import Icon from '@components/Icon';
+import useThemeStyles from '@hooks/useThemeStyles';


Does this have some dependency which is not migrated to TS or can we make this in TS now?

Maybe at the time of Section/index.js (originally Section.js) migration

OSBotify · 2023-12-20T13:59:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-21T05:30:38Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.15-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kavimuru · 2023-12-21T11:26:53Z

@MaciejSWM could you help with QA steps?

Check the margins and paddings and sizes against Figma designs.

Click on Plus icon and the Get Started buttons - validate that Touchable effects are visible.

We don't have access to Figma designs. Also which plus icon to click?

mountiny · 2023-12-21T12:06:51Z

@kavimuru you can chrck it off we will qa this in future prs once used

OSBotify · 2023-12-22T05:19:21Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.4.15-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

aimane-chnaif · 2023-12-26T04:41:27Z

src/components/Section/IconSection.js

+    icon: PropTypes.icon,
+    IconComponent: PropTypes.IconComponent,
+    iconContainerStyles: PropTypes.iconContainerStyles,


@MaciejSWM would you mind working on #25024?
As these are wrong prop types, we have console warning. TS migration should fix it.

Bumped that issue

I fixed that here @aimane-chnaif, funny enough you where chosen for C+ review 😸

MaciejSWM added 2 commits December 1, 2023 12:50

Create a Workspace card

d254e4f

Workspace title and icon

fa86c13

MaciejSWM marked this pull request as ready for review December 4, 2023 09:58

MaciejSWM requested a review from a team as a code owner December 4, 2023 09:58

melvin-bot bot requested review from aimane-chnaif and removed request for a team December 4, 2023 09:58

MaciejSWM added 4 commits December 4, 2023 12:38

Merge branch 'main' into wave8/create-a-workspace-card

957cab8

Let Icon be at the top or on the right

294bca6

Add muted subtitle

79fbdb1

Remove Create a Workspace card

0f16ecf

Drop unused imports

2122277

MaciejSWM added 4 commits December 4, 2023 18:27

Add Hotdog stand icon

8aea9bb

Merge branch 'main' into wave8/create-a-workspace-card

4526678

Approved spanish translations

bf42670

Revert color changes

d76eeef

MaciejSWM added 5 commits December 13, 2023 10:23

Merge branch 'main' into wave8/create-a-workspace-card

74dc5cc

Make styles naming more general

9146059

Card layout as const

73721d1

Medium sized button

7178306

Empty workspace translations

04d59f3

Change import path

cd85712

BartoszGrajdek approved these changes Dec 15, 2023

View reviewed changes

aimane-chnaif reviewed Dec 18, 2023

View reviewed changes

src/components/Section.js Outdated Show resolved Hide resolved

src/pages/workspace/card/WorkspaceCardCreateAWorkspace.tsx Outdated Show resolved Hide resolved

aimane-chnaif reviewed Dec 18, 2023

View reviewed changes

src/components/Section.js Outdated Show resolved Hide resolved

src/components/Section.js Outdated Show resolved Hide resolved

aimane-chnaif reviewed Dec 18, 2023

View reviewed changes

src/components/Section.js Outdated Show resolved Hide resolved

MaciejSWM added 5 commits December 18, 2023 17:24

Only apply mh1 on single layout

9da1c8e

Bool instead of boolean

5d3d93a

Use useLocalize instead of withLocalize

0cc848e

Spread array of styles

91b8e91

Split Section to index.js and IconSection.js

5e800a2

Drop Section.js after pushing it to a separate directory

6fd3b5a

MaciejSWM requested a review from aimane-chnaif December 19, 2023 19:02

Merge branch 'main' into wave8/create-a-workspace-card

0ea0c16

aimane-chnaif approved these changes Dec 20, 2023

View reviewed changes

melvin-bot bot requested a review from mountiny December 20, 2023 08:12

mountiny assigned MaciejSWM Dec 20, 2023

mountiny approved these changes Dec 20, 2023

View reviewed changes

mountiny merged commit 249096e into Expensify:main Dec 20, 2023
18 checks passed

github-actions bot mentioned this pull request Dec 21, 2023

Deploy Checklist: New Expensify 2023-12-21 #33391

Closed

51 tasks

melvin-bot bot mentioned this pull request Dec 22, 2023

[HOLD for payment 2023-12-29] [HOLD for payment 2023-12-28] [Ideal Nav] Create components for the ideal nav #31766

Closed

10 tasks

aimane-chnaif reviewed Dec 26, 2023

View reviewed changes

ishpaul777 mentioned this pull request Dec 26, 2023

[HOLD for payment 2024-01-04] [$250] Android - Workspace - Card icon is shown as a green square icon #33594

Closed

6 tasks

blazejkustra mentioned this pull request Dec 27, 2023

[TS migration] Migrate 'Section.js' component to TypeScript #33645

Merged

48 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Wave8] Create a Workspace Card #32339

[Wave8] Create a Workspace Card #32339

MaciejSWM commented Dec 1, 2023 •

edited

Loading

melvin-bot bot commented Dec 4, 2023

MaciejSWM commented Dec 4, 2023

MaciejSWM commented Dec 4, 2023

MaciejSWM commented Dec 4, 2023

MaciejSWM commented Dec 5, 2023

shawnborton commented Dec 5, 2023

shawnborton commented Dec 5, 2023

shawnborton commented Dec 5, 2023

dubielzyk-expensify commented Dec 6, 2023

MaciejSWM commented Dec 13, 2023

MaciejSWM commented Dec 18, 2023

aimane-chnaif commented Dec 20, 2023

aimane-chnaif left a comment

mountiny left a comment

mountiny Dec 20, 2023

aimane-chnaif Dec 20, 2023

OSBotify commented Dec 20, 2023

OSBotify commented Dec 21, 2023

kavimuru commented Dec 21, 2023

mountiny commented Dec 21, 2023

OSBotify commented Dec 22, 2023

aimane-chnaif Dec 26, 2023

mountiny Dec 26, 2023

blazejkustra Dec 27, 2023

[Wave8] Create a Workspace Card #32339

[Wave8] Create a Workspace Card #32339

Conversation

MaciejSWM commented Dec 1, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 4, 2023

MaciejSWM commented Dec 4, 2023

MaciejSWM commented Dec 4, 2023

MaciejSWM commented Dec 4, 2023

MaciejSWM commented Dec 5, 2023

shawnborton commented Dec 5, 2023

shawnborton commented Dec 5, 2023

shawnborton commented Dec 5, 2023

dubielzyk-expensify commented Dec 6, 2023

MaciejSWM commented Dec 13, 2023

MaciejSWM commented Dec 18, 2023

aimane-chnaif commented Dec 20, 2023

Reviewer Checklist

Screenshots/Videos

aimane-chnaif left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

mountiny Dec 20, 2023

Choose a reason for hiding this comment

aimane-chnaif Dec 20, 2023

Choose a reason for hiding this comment

OSBotify commented Dec 20, 2023

OSBotify commented Dec 21, 2023

kavimuru commented Dec 21, 2023

mountiny commented Dec 21, 2023

OSBotify commented Dec 22, 2023

aimane-chnaif Dec 26, 2023

Choose a reason for hiding this comment

mountiny Dec 26, 2023

Choose a reason for hiding this comment

blazejkustra Dec 27, 2023

Choose a reason for hiding this comment

MaciejSWM commented Dec 1, 2023 •

edited

Loading