Personal bank account option is not present in Pay with Expensify menu #32423

dukenv0307 · 2023-12-04T09:24:46Z

Details

The Bank account option should present in the Pay with Expensify menu when sending money in USD

Fixed Issues

$ #32228
PROPOSAL: #32228 (comment)

Tests

Go to 1:1 DM
Click + > Send money
Select USD currency and enter an amount > Click Next
Click Pay with Expensify
Verify that the Bank account option will be present in the Pay with Expensify menu

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to 1:1 DM
Click + > Send money
Select USD currency and enter an amount > Click Next
Click Pay with Expensify
Verify that the Bank account option will be present in the Pay with Expensify menu

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-resize.mov

Android: mWeb Chrome

chrome-resize.mov

iOS: Native

ios-resize.mov

iOS: mWeb Safari

safari-resize.mov

MacOS: Chrome / Safari

web-resize.mov

MacOS: Desktop

desktop-resize.mov

melvin-bot · 2023-12-04T10:45:40Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aimane-chnaif · 2023-12-05T15:01:37Z

src/components/AddPaymentMethodMenu.js

@@ -70,6 +75,8 @@ function AddPaymentMethodMenu({isVisible, onClose, anchorPosition, anchorAlignme
        ReportUtils.isExpenseReport(iouReport) ||
        (ReportUtils.isIOUReport(iouReport) && !ReportActionsUtils.hasRequestFromCurrentAccount(lodashGet(iouReport, 'reportID', 0), lodashGet(session, 'accountID', 0)));

+    const canUsePersonalBankAccount = iou.id === CONST.IOU.TYPE.SEND;


Suggested change

const canUsePersonalBankAccount = iou.id === CONST.IOU.TYPE.SEND;

const canUsePersonalBankAccount = iou.id === CONST.IOU.TYPE.SEND || ReportUtils.isIOUReport(iouReport);

Was there any discussion that we should disable personal bank account on IOU (1:1) report?

Before:

After:

The IOU report should also include the Personal Bank Account option

@aimane-chnaif Updated

aimane-chnaif · 2023-12-06T16:18:57Z

src/components/AddPaymentMethodMenu.js

@@ -122,5 +129,8 @@ export default compose(
        session: {
            key: ONYXKEYS.SESSION,
        },
+        iou: {
+            key: ONYXKEYS.IOU,
+        },


This is not correct check of IOU type.
There's case when iou.type is undefined

bug.mov

@dukenv0307 bump ^
I see you're currently working on lots of issues.
If you're not able to prioritize, we can open back to proposals

mountiny · 2023-12-08T15:40:58Z

@dukenv0307 I agree with Aimane, please prioritize your PRs over making new proposals

dukenv0307 · 2023-12-11T09:04:52Z

@aimane-chnaif Code updated. Thanks for your patience

mountiny · 2023-12-11T11:25:01Z

@aimane-chnaif let me know when this is ready, thank you 🙇

dukenv0307 · 2023-12-13T04:51:30Z

@aimane-chnaif Friendly bump to review the PR again. Thanks

aimane-chnaif · 2023-12-14T09:25:46Z

@dukenv0307 please merge main.

aimane-chnaif · 2023-12-14T09:26:37Z

After money request refactor, I think there should be solution without introducing new flag

aimane-chnaif

I see send money is still using old flow, so I think your approach is fine for now

aimane-chnaif · 2023-12-14T09:33:04Z

src/components/MoneyRequestConfirmationList.js

@@ -517,6 +517,7 @@ function MoneyRequestConfirmationList(props) {
                    horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.RIGHT,
                    vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.BOTTOM,
                }}
+                shouldShowPersonalBankAccountOption={shouldShowSettlementButton}


Suggested change

shouldShowPersonalBankAccountOption={shouldShowSettlementButton}

shouldShowPersonalBankAccountOption

dukenv0307 · 2023-12-14T10:40:42Z

@aimane-chnaif Code updated

aimane-chnaif · 2023-12-14T12:17:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

aimane-chnaif

LGTM 🎉

mountiny

Thanks everyone!

OSBotify · 2023-12-14T15:29:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-19T02:43:09Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.14-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-12-19T03:46:30Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.14-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-21T05:14:05Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.4.14-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Bank account option is not present in Pay with Expensify menu

b75b477

dukenv0307 marked this pull request as ready for review December 4, 2023 10:45

dukenv0307 requested a review from a team as a code owner December 4, 2023 10:45

melvin-bot bot requested review from aimane-chnaif and removed request for a team December 4, 2023 10:45

mountiny changed the title ~~Bank account option is not present in Pay with Expensify menu~~ Personal bank account option is not present in Pay with Expensify menu Dec 4, 2023

mountiny assigned dukenv0307 Dec 4, 2023

aimane-chnaif reviewed Dec 5, 2023

View reviewed changes

dukenv0307 added 2 commits December 6, 2023 18:15

Merge branch 'main' into fix/32228

578ede3

add Personal bank account option to the IOU report

380f563

aimane-chnaif reviewed Dec 6, 2023

View reviewed changes

dukenv0307 added 2 commits December 11, 2023 14:55

Merge branch 'main' into fix/32228

1bf2f26

pass iouType to SettlementButton

ca929fb

aimane-chnaif reviewed Dec 14, 2023

View reviewed changes

dukenv0307 added 2 commits December 14, 2023 17:08

Merge branch 'main' into fix/32228

5e49d8b

clean code

eaf6d53

aimane-chnaif approved these changes Dec 14, 2023

View reviewed changes

melvin-bot bot requested a review from mountiny December 14, 2023 12:17

mountiny approved these changes Dec 14, 2023

View reviewed changes

mountiny merged commit 78ad3f9 into Expensify:main Dec 14, 2023
16 checks passed

tienifr mentioned this pull request Dec 19, 2023

[HOLD for payment 2024-01-25] [$500] Web - "Bank account" option does not appear in "Wallet" #32079

Closed

6 tasks

github-actions bot mentioned this pull request Dec 19, 2023

Deploy Checklist: New Expensify 2023-12-19 #33264

Closed

98 tasks

melvin-bot bot mentioned this pull request Dec 21, 2023

[HOLD for payment 2023-12-28] [$500] Send money - Bank account option is not present in Pay with Expensify menu #32228

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Personal bank account option is not present in Pay with Expensify menu #32423

Personal bank account option is not present in Pay with Expensify menu #32423

dukenv0307 commented Dec 4, 2023 •

edited

Loading

melvin-bot bot commented Dec 4, 2023

aimane-chnaif Dec 5, 2023

mountiny Dec 5, 2023

dukenv0307 Dec 6, 2023

aimane-chnaif Dec 6, 2023

aimane-chnaif Dec 8, 2023

mountiny commented Dec 8, 2023

dukenv0307 commented Dec 11, 2023

mountiny commented Dec 11, 2023

dukenv0307 commented Dec 13, 2023

aimane-chnaif commented Dec 14, 2023 •

edited

Loading

aimane-chnaif commented Dec 14, 2023

aimane-chnaif left a comment

aimane-chnaif Dec 14, 2023

dukenv0307 commented Dec 14, 2023

aimane-chnaif commented Dec 14, 2023

aimane-chnaif left a comment

mountiny left a comment

OSBotify commented Dec 14, 2023

OSBotify commented Dec 19, 2023

OSBotify commented Dec 19, 2023

OSBotify commented Dec 21, 2023

	const canUsePersonalBankAccount = iou.id === CONST.IOU.TYPE.SEND;
	const canUsePersonalBankAccount = iou.id === CONST.IOU.TYPE.SEND \|\| ReportUtils.isIOUReport(iouReport);

	shouldShowPersonalBankAccountOption={shouldShowSettlementButton}
	shouldShowPersonalBankAccountOption

Personal bank account option is not present in Pay with Expensify menu #32423

Personal bank account option is not present in Pay with Expensify menu #32423

Conversation

dukenv0307 commented Dec 4, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 4, 2023

aimane-chnaif Dec 5, 2023

Choose a reason for hiding this comment

mountiny Dec 5, 2023

Choose a reason for hiding this comment

dukenv0307 Dec 6, 2023

Choose a reason for hiding this comment

aimane-chnaif Dec 6, 2023

Choose a reason for hiding this comment

aimane-chnaif Dec 8, 2023

Choose a reason for hiding this comment

mountiny commented Dec 8, 2023

dukenv0307 commented Dec 11, 2023

mountiny commented Dec 11, 2023

dukenv0307 commented Dec 13, 2023

aimane-chnaif commented Dec 14, 2023 • edited Loading

aimane-chnaif commented Dec 14, 2023

aimane-chnaif left a comment

Choose a reason for hiding this comment

aimane-chnaif Dec 14, 2023

Choose a reason for hiding this comment

dukenv0307 commented Dec 14, 2023

aimane-chnaif commented Dec 14, 2023

Reviewer Checklist

Screenshots/Videos

aimane-chnaif left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 14, 2023

OSBotify commented Dec 19, 2023

OSBotify commented Dec 19, 2023

OSBotify commented Dec 21, 2023

dukenv0307 commented Dec 4, 2023 •

edited

Loading

aimane-chnaif commented Dec 14, 2023 •

edited

Loading