Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tooltip doesn't show on a mention with a user we never chat before #32632

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Fix tooltip doesn't show on a mention with a user we never chat before #32632

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2db0df3
use display name fallback
bernhardoj Dec 7, 2023
1935d99
Merge branch 'main' into fix/31720-mention-tooltip
bernhardoj Dec 8, 2023
a0b4d1c
Merge branch 'main' into fix/31720-mention-tooltip
bernhardoj Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/UserDetailsTooltip/BaseUserDetailsTooltip.web.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ function BaseUserDetailsTooltip(props) {
const personalDetails = usePersonalDetails();

const userDetails = lodashGet(personalDetails, props.accountID, props.fallbackUserDetails);
let userDisplayName = ReportUtils.getDisplayNameForParticipant(props.accountID);
let userDisplayName = ReportUtils.getDisplayNameForParticipant(props.accountID) || (userDetails.displayName ? userDetails.displayName.trim() : '');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to fallback to the previous logic as displayName can be undefined.

Screenshot 2023-12-07 at 13 17 01

let userLogin = (userDetails.login || '').trim() && !_.isEqual(userDetails.login, userDetails.displayName) ? Str.removeSMSDomain(userDetails.login) : '';
let userAvatar = userDetails.avatar;
let userAccountID = props.accountID;
Expand Down
Loading