Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP Staging + Prod] Revert "Image Web/Desktop: Add support for http headers" #32700

Merged

Conversation

blimpich
Copy link
Contributor

@blimpich blimpich commented Dec 7, 2023

Reverts #13036

@blimpich blimpich requested a review from a team as a code owner December 7, 2023 23:24
Copy link
Contributor

github-actions bot commented Dec 7, 2023

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@melvin-bot melvin-bot bot requested review from hayata-suenaga and removed request for a team December 7, 2023 23:25
Copy link

melvin-bot bot commented Dec 7, 2023

@hayata-suenaga Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@yuwenmemon yuwenmemon merged commit c1877ed into main Dec 7, 2023
12 of 15 checks passed
@yuwenmemon yuwenmemon deleted the revert-13036-kidroca/feature/react-native-web-image-headers branch December 7, 2023 23:46
@melvin-bot melvin-bot bot added the Emergency label Dec 7, 2023
Copy link

melvin-bot bot commented Dec 7, 2023

@yuwenmemon looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@yuwenmemon
Copy link
Contributor

Revert, don't need the checklists.

@OSBotify
Copy link
Contributor

OSBotify commented Dec 7, 2023

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Dec 7, 2023
…/react-native-web-image-headers

 [CP Staging + Prod] Revert "Image Web/Desktop: Add support for http headers"

(cherry picked from commit c1877ed)
@OSBotify
Copy link
Contributor

OSBotify commented Dec 8, 2023

🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 1.4.9-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 cancelled 🔪
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

OSBotify commented Dec 8, 2023

🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 1.4.9-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

OSBotify commented Dec 8, 2023

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.9-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants