Fix tall emojis are chopped off from top #32818

rezkiy37 · 2023-12-11T15:15:22Z

Details

Fixed Issues

Tests

Note: the bug happens on native Android and IOS.

Device settings:
IOS: Settings > Accessibility > Display & Text Size > Larger Text > Set any value.
Android: Settings > Accessibility > Display size and text > Font size > Set any value.

Note: restart the app after any change.

Custom added emojis

Preconditions:

Create/rename a workspace to include tall emojis like 🚦.
Update the display name of your current profile to include tall emojis like 🚦.
Set the status to include tall emojis like 🚦.

Actually, there are a lot of scenarios. To sum up, check any place where the display name and workspace name could be displayed. Verify that the emojis shouldn’t be chopped off.

Tabs

There is one more case where static icons were chopped off.

Click on the FAB.
Click on Money request.
Verify that "Manual", "Scan" and "Distance" tabs are not chopped off.

Verify that no errors appear in the JS console

Offline tests

Same as "Tests".

QA Steps

Same as "Tests".

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android.Large.mp4

Android.Normal.mp4

Android.Small.mp4

Android: mWeb Chrome

Android.Chrome.Normal.mp4

Android.Chrome.Small.mp4

iOS: Native

IOS.Large.mp4

IOS.Normal.mp4

IOS.Small.mp4

iOS: mWeb Safari

IOS.Safari.Normal.mp4

IOS.Safari.Small.mp4

MacOS: Chrome / Safari

Chrome.mp4

MacOS: Desktop

Desktop.mp4

…/26044-tall-emojies

melvin-bot · 2023-12-19T11:12:12Z

@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…/26044-tall-emojies

src/components/ReportActionItem/ReportPreview.js

fedirjh · 2023-12-20T21:13:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Large Font Size

Small Font Size

Android: mWeb Chrome

#### Large Font Size

Small Font Size

iOS: Native

#### Large Font Size

Small Font Size

iOS: mWeb Safari

Large Font Size

Small Font Size

MacOS: Chrome / Safari

MacOS: Desktop

…/26044-tall-emojies

fedirjh

Looks good and tests well.

OSBotify · 2023-12-27T14:30:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-28T21:19:06Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.18-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

getusha · 2024-01-05T20:32:05Z

src/styles/index.ts

@@ -1585,7 +1585,7 @@ const styles = (theme: ThemeColors) =>
        optionDisplayName: {
            fontFamily: fontFamily.EXP_NEUE,
            minHeight: variables.alternateTextHeight,
-            lineHeight: variables.lineHeightXLarge,
+            lineHeight: variables.lineHeightXXLarge,


this caused a regression #33647

rezkiy37 added 3 commits December 11, 2023 14:46

fix tall emojies

e7dc281

fix tab lineHeight

0acc833

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

4815877

…/26044-tall-emojies

rezkiy37 changed the title ~~fix tall emojies~~ Fix tall emojis are chopped off from top Dec 12, 2023

rezkiy37 added 2 commits December 13, 2023 10:49

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

df3aade

…/26044-tall-emojies

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

169ea84

…/26044-tall-emojies

rezkiy37 marked this pull request as ready for review December 19, 2023 11:12

rezkiy37 requested a review from a team as a code owner December 19, 2023 11:12

melvin-bot bot requested review from fedirjh and removed request for a team December 19, 2023 11:12

rezkiy37 mentioned this pull request Dec 19, 2023

[HOLD for payment 2024-01-04] [$1000] IOS - Emoji chopped off from top in workspace name #26044

Closed

6 tasks

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

54b82a6

…/26044-tall-emojies

fedirjh reviewed Dec 20, 2023

View reviewed changes

src/components/ReportActionItem/ReportPreview.js Outdated Show resolved Hide resolved

rezkiy37 added 2 commits December 21, 2023 10:37

use helper

841969a

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

fb19a56

…/26044-tall-emojies

rezkiy37 requested a review from fedirjh December 21, 2023 09:38

fedirjh approved these changes Dec 26, 2023

View reviewed changes

melvin-bot bot requested a review from arosiclair December 26, 2023 17:27

arosiclair approved these changes Dec 27, 2023

View reviewed changes

arosiclair merged commit 104d77d into Expensify:main Dec 27, 2023
17 of 18 checks passed

github-actions bot mentioned this pull request Dec 27, 2023

Deploy Checklist: New Expensify 2023-12-27 #33644

Closed

41 tasks

situchan mentioned this pull request Dec 27, 2023

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [HOLD for payment 2024-04-15] [HOLD for payment 2024-03-22] [$250] LHN chat row has large spacing #33647

Closed

6 tasks

situchan mentioned this pull request Dec 29, 2023

[HOLD for payment 2024-01-22] [$500] mWeb - IOU- Text "Long email id owes" is displayed with extra spacing in IOU preview #33769

Closed

6 tasks

getusha reviewed Jan 5, 2024

View reviewed changes

shawnborton mentioned this pull request Jan 9, 2024

[HOLD for payment 2024-01-24] PR regression causing misalignment of basic chat message styles #34152

Closed

VickyStash mentioned this pull request Jun 12, 2024

Emojis larger in other contexts than just single character messages #40692

Merged

53 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix tall emojis are chopped off from top #32818

Fix tall emojis are chopped off from top #32818

rezkiy37 commented Dec 11, 2023 •

edited

Loading

melvin-bot bot commented Dec 19, 2023

fedirjh commented Dec 20, 2023 •

edited

Loading

Large Font Size

Small Font Size

Small Font Size

Small Font Size

Large Font Size

Small Font Size

fedirjh left a comment

OSBotify commented Dec 27, 2023

OSBotify commented Dec 28, 2023

getusha Jan 5, 2024

Fix tall emojis are chopped off from top #32818

Fix tall emojis are chopped off from top #32818

Conversation

rezkiy37 commented Dec 11, 2023 • edited Loading

Details

Fixed Issues

Tests

Custom added emojis

Tabs

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 19, 2023

fedirjh commented Dec 20, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

Large Font Size

Small Font Size

Small Font Size

Small Font Size

Large Font Size

Small Font Size

fedirjh left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 27, 2023

OSBotify commented Dec 28, 2023

getusha Jan 5, 2024

Choose a reason for hiding this comment

rezkiy37 commented Dec 11, 2023 •

edited

Loading

fedirjh commented Dec 20, 2023 •

edited

Loading