-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NO QA] [TS migration] Migrate LinkPreviewer component to TypeScript #32822
Merged
bondydaa
merged 9 commits into
Expensify:main
from
software-mansion-labs:@szymczak/31948
Dec 20, 2023
Merged
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
103821b
migrate LinkPreviewer to typescript
SzymczakJ 20463d1
fix PR comments
SzymczakJ a94831b
Merge branch 'main' into @szymczak/31948
SzymczakJ 5547279
fix typescript errors
SzymczakJ ed74e29
fix PR comments
SzymczakJ 66393c5
Merge branch 'main' into @szymczak/31948
SzymczakJ 23a9a01
fix comments
SzymczakJ 84a862b
fix naming
SzymczakJ 28cd4fc
Merge branch 'main' into @szymczak/31948
SzymczakJ File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,91 @@ | ||
import React from 'react'; | ||
import {Image, View} from 'react-native'; | ||
import Text from '@components/Text'; | ||
import TextLink from '@components/TextLink'; | ||
import useTheme from '@styles/themes/useTheme'; | ||
import useStyleUtils from '@styles/useStyleUtils'; | ||
import useThemeStyles from '@styles/useThemeStyles'; | ||
import variables from '@styles/variables'; | ||
import type {LinkMetadata} from '@src/types/onyx/ReportAction'; | ||
|
||
const IMAGE_TYPES = ['jpg', 'jpeg', 'png']; | ||
const MAX_IMAGE_HEIGHT = 180; | ||
const MAX_IMAGE_WIDTH = 340; | ||
|
||
type LinkPreviewerProps = { | ||
/** Data about links provided in message. */ | ||
linkMetadata?: LinkMetadata[]; | ||
|
||
/** Maximum amount of visible link previews. -1 means unlimited amount of previews */ | ||
maxAmountOfPreviews?: number; | ||
}; | ||
|
||
function LinkPreviewer({linkMetadata = [], maxAmountOfPreviews = -1}: LinkPreviewerProps) { | ||
const theme = useTheme(); | ||
const styles = useThemeStyles(); | ||
const StyleUtils = useStyleUtils(); | ||
const uniqueLinks = linkMetadata.filter((link, index, self) => self.findIndex((t) => t.url === link.url) === index); | ||
const maxAmmountOfLinks = maxAmountOfPreviews >= 0 ? Math.min(maxAmountOfPreviews, linkMetadata.length) : linkMetadata.length; | ||
const linksToShow = uniqueLinks.slice(0, maxAmmountOfLinks); | ||
return linksToShow.map((linkData) => { | ||
if (Array.isArray(linkData)) { | ||
return; | ||
} | ||
const {description, image, title, logo, publisher, url} = linkData; | ||
return ( | ||
linkData && ( | ||
<View | ||
style={styles.linkPreviewWrapper} | ||
key={url} | ||
> | ||
<View style={styles.flexRow}> | ||
{logo && ( | ||
<Image | ||
style={styles.linkPreviewLogoImage} | ||
source={{uri: logo.url}} | ||
/> | ||
)} | ||
{publisher && ( | ||
<Text | ||
fontSize={variables.fontSizeLabel} | ||
style={styles.pl2} | ||
> | ||
{publisher} | ||
</Text> | ||
)} | ||
</View> | ||
{title && url && ( | ||
<TextLink | ||
fontSize={variables.fontSizeNormal} | ||
style={[styles.mv2, StyleUtils.getTextColorStyle(theme.link), styles.alignSelfStart]} | ||
href={url} | ||
> | ||
{title} | ||
</TextLink> | ||
)} | ||
{description && <Text fontSize={variables.fontSizeNormal}>{description}</Text>} | ||
{image?.type && IMAGE_TYPES.includes(image.type) && image.width && image.height && ( | ||
<Image | ||
style={[ | ||
styles.linkPreviewImage, | ||
{ | ||
aspectRatio: image.width / image.height, | ||
maxHeight: Math.min(image.height, MAX_IMAGE_HEIGHT), | ||
|
||
// Calculate maximum width when image is too tall, so it doesn't move away from left | ||
maxWidth: Math.min((Math.min(image.height, MAX_IMAGE_HEIGHT) / image.height) * image.width, MAX_IMAGE_WIDTH), | ||
}, | ||
]} | ||
resizeMode="contain" | ||
source={{uri: image.url}} | ||
/> | ||
)} | ||
</View> | ||
) | ||
); | ||
}); | ||
} | ||
|
||
LinkPreviewer.displayName = 'ReportLinkPreview'; | ||
|
||
export default LinkPreviewer; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor but maybe you can change
t
variable name to something more meaningful?