[TS migration] Migrate 'ReportActionItemChronosOOOListActions.js' component to TypeS… #32927

pasyukevich · 2023-12-12T15:20:23Z

Details

Fixed Issues

$ #31951
PROPOSAL:

Tests

Open ChronosOOOListActions and patch the default array with data - const events = action.originalMessage?.events ?? [];

data:


	{id: '1', summary: 'test', lengthInDays: 1000, end: {date: '',
        // eslint-disable-next-line @typescript-eslint/naming-convention
        timezone: 'Europe/Paris', timezone_type: 0 }, start: {date: new Date('2022-04-01T12:00:00Z'),
        // eslint-disable-next-line @typescript-eslint/naming-convention
        timezone: 'Europe/Paris', timezone_type: 0 } }

Open ReportActionItem and find the usage of props.action.actionName === CONST.REPORT.ACTIONS.TYPE.CHRONOSOOOLIST
Extend it with || true
Open any report and verify that Chronos is displayed correctly

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open ChronosOOOListActions and patch the default array with data - const events = action.originalMessage?.events ?? [];

data:


	{id: '1', summary: 'test', lengthInDays: 1000, end: {date: '',
        // eslint-disable-next-line @typescript-eslint/naming-convention
        timezone: 'Europe/Paris', timezone_type: 0 }, start: {date: new Date('2022-04-01T12:00:00Z'),
        // eslint-disable-next-line @typescript-eslint/naming-convention
        timezone: 'Europe/Paris', timezone_type: 0 } }

Open ReportActionItem and find the usage of props.action.actionName === CONST.REPORT.ACTIONS.TYPE.CHRONOSOOOLIST
Extend it with || true
Open any report and verify that Chronos is displayed correctly

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

kubabutkiewicz · 2023-12-12T16:09:23Z

src/components/ReportActionItem/ChronosOOOListActions.tsx


    if (!events.length) {
        return (
-            <View style={[styles.flexRow, styles.alignItemsCenter, styles.pt, styles.ml18]}>


Why this style was removed?

Looks like this style .pt does not exist.

Yes, the .pt style has never existed

kubabutkiewicz · 2023-12-12T16:12:46Z

src/components/OfflineWithFeedback.tsx

@@ -18,7 +18,7 @@ import MessagesRow from './MessagesRow';

 type OfflineWithFeedbackProps = ChildrenProps & {
    /** The type of action that's pending  */
-    pendingAction: OnyxCommon.PendingAction;
+    pendingAction?: OnyxCommon.PendingAction;


Can you test what will happen when pendingAction will be undefined?

Nothing happened - all works good

src/components/ReportActionItem/ChronosOOOListActions.tsx

…cript

blazejkustra · 2023-12-19T13:48:46Z

@pasyukevich LGTM, please adjust Offline and QA sections + record videos 🚀

…tActions

melvin-bot · 2023-12-28T11:45:52Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allroundexperts · 2023-12-31T17:24:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

allroundexperts

Looks good!

melvin-bot · 2024-01-12T22:11:47Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #31951 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

…tActions

MonilBhavsar · 2024-01-30T18:44:37Z

@pasyukevich could you please merge main. I can take a look

src/components/ReportActionItem/ChronosOOOListActions.tsx

…tActions

pasyukevich · 2024-01-31T17:27:17Z

@MonilBhavsar The latest main was merged

MonilBhavsar

Thanks!

OSBotify · 2024-01-31T18:46:35Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-31T23:00:51Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.4.35-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mvtglobally · 2024-02-01T01:50:20Z

@MonilBhavsar Can you pls validate this internally? Or help us with more user friendly QA steps?

MonilBhavsar · 2024-02-01T06:10:14Z

I'll QA this

MonilBhavsar · 2024-02-01T13:40:33Z

Looks good!

OSBotify · 2024-02-02T15:13:24Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.35-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

pasyukevich force-pushed the feaure/migrate-ReportActionItemChronosOOOListActions branch from b116ed7 to 343933e Compare December 12, 2023 16:02

kubabutkiewicz reviewed Dec 12, 2023

View reviewed changes

fabioh8010 reviewed Dec 13, 2023

View reviewed changes

src/components/ReportActionItem/ChronosOOOListActions.tsx Outdated Show resolved Hide resolved

src/components/ReportActionItem/ChronosOOOListActions.tsx Outdated Show resolved Hide resolved

Migrate 'ReportActionItemChronosOOOListActions.js' component to TypeS…

2e192b3

…cript

pasyukevich force-pushed the feaure/migrate-ReportActionItemChronosOOOListActions branch from 343933e to 2e192b3 Compare December 13, 2023 11:16

fabioh8010 approved these changes Dec 15, 2023

View reviewed changes

blazejkustra approved these changes Dec 19, 2023

View reviewed changes

pasyukevich added 2 commits December 28, 2023 10:16

Merge branch 'main' into feaure/migrate-ReportActionItemChronosOOOLis…

59b6952

…tActions

apply prettier

6dbcba9

pasyukevich marked this pull request as ready for review December 28, 2023 11:45

pasyukevich requested a review from a team as a code owner December 28, 2023 11:45

melvin-bot bot requested review from allroundexperts and removed request for a team December 28, 2023 11:45

allroundexperts approved these changes Jan 12, 2024

View reviewed changes

pasyukevich added 2 commits January 17, 2024 12:50

Merge branch 'main' into feaure/migrate-ReportActionItemChronosOOOLis…

2f3c8e8

…tActions

Merge branch 'main' into feaure/migrate-ReportActionItemChronosOOOLis…

991f77e

…tActions

MonilBhavsar self-requested a review January 30, 2024 18:44

MonilBhavsar requested changes Jan 30, 2024

View reviewed changes

src/components/ReportActionItem/ChronosOOOListActions.tsx Outdated Show resolved Hide resolved

pasyukevich added 2 commits January 31, 2024 18:24

Merge branch 'main' into feaure/migrate-ReportActionItemChronosOOOLis…

e0a0f61

…tActions

fix start date

f14a7ca

pasyukevich requested a review from MonilBhavsar January 31, 2024 17:27

MonilBhavsar approved these changes Jan 31, 2024

View reviewed changes

MonilBhavsar merged commit 2d2ea11 into Expensify:main Jan 31, 2024
16 checks passed

github-actions bot mentioned this pull request Jan 31, 2024

Deploy Checklist: New Expensify 2024-01-31 #35524

Closed

37 tasks

melvin-bot bot mentioned this pull request Feb 2, 2024

[HOLD for payment 2024-02-09] [TS migration] Migrate 'ReportActionItemChronosOOOListActions.js' component to TypeScript #31951

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TS migration] Migrate 'ReportActionItemChronosOOOListActions.js' component to TypeS… #32927

[TS migration] Migrate 'ReportActionItemChronosOOOListActions.js' component to TypeS… #32927

pasyukevich commented Dec 12, 2023 •

edited

Loading

kubabutkiewicz Dec 12, 2023

rezkiy37 Dec 12, 2023

pasyukevich Dec 13, 2023

kubabutkiewicz Dec 12, 2023

pasyukevich Dec 13, 2023

blazejkustra commented Dec 19, 2023

melvin-bot bot commented Dec 28, 2023

allroundexperts commented Dec 31, 2023 •

edited

Loading

allroundexperts left a comment

melvin-bot bot commented Jan 12, 2024

MonilBhavsar commented Jan 30, 2024

pasyukevich commented Jan 31, 2024

MonilBhavsar left a comment

OSBotify commented Jan 31, 2024

OSBotify commented Jan 31, 2024

mvtglobally commented Feb 1, 2024

MonilBhavsar commented Feb 1, 2024

MonilBhavsar commented Feb 1, 2024

OSBotify commented Feb 2, 2024

[TS migration] Migrate 'ReportActionItemChronosOOOListActions.js' component to TypeS… #32927

[TS migration] Migrate 'ReportActionItemChronosOOOListActions.js' component to TypeS… #32927

Conversation

pasyukevich commented Dec 12, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

kubabutkiewicz Dec 12, 2023

Choose a reason for hiding this comment

rezkiy37 Dec 12, 2023

Choose a reason for hiding this comment

pasyukevich Dec 13, 2023

Choose a reason for hiding this comment

kubabutkiewicz Dec 12, 2023

Choose a reason for hiding this comment

pasyukevich Dec 13, 2023

Choose a reason for hiding this comment

blazejkustra commented Dec 19, 2023

melvin-bot bot commented Dec 28, 2023

allroundexperts commented Dec 31, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

allroundexperts left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Jan 12, 2024

MonilBhavsar commented Jan 30, 2024

pasyukevich commented Jan 31, 2024

MonilBhavsar left a comment

Choose a reason for hiding this comment

OSBotify commented Jan 31, 2024

OSBotify commented Jan 31, 2024

mvtglobally commented Feb 1, 2024

MonilBhavsar commented Feb 1, 2024

MonilBhavsar commented Feb 1, 2024

OSBotify commented Feb 2, 2024

pasyukevich commented Dec 12, 2023 •

edited

Loading

allroundexperts commented Dec 31, 2023 •

edited

Loading