Update HTMLEngineProvider to use VideoRenderer #33145

Skalakid · 2023-12-15T09:53:58Z

Details

In this PR we are preparing New/Dot app for a backend changes connected to video player. Video attachment will be returned as <video> tags now, so we added temporary tag handling until video player component is ready.

More info in the video player design doc

Fixed Issues

$ #32771
PROPOSAL: #32771

Tests

For now our backend doesn't return any new tags so we can simulate it by replacing this fragment of code to:

    if (ReportUtils.isReportMessageAttachment(fragment)) {
        fragment.html = fragment.html.replace(/^<a\s/g, '<video ');
        return (
            <AttachmentCommentFragment
                source={props.source}
                html={fragment.html}
                addExtraMargin={!props.displayAsGroup}
            />
        );
    }
    ...

Now all <a> tags will be converted to <video> tags
Open any chat
Check if all previously send attachments are rendered normally
Upload a video and check if everything is rendered properly

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

ios.mov

iOS: mWeb Safari

ios-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2023-12-15T10:40:53Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Ollyws · 2023-12-18T13:15:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

01_Android_Native.mp4

Android: mWeb Chrome

02_Android_Chrome.mp4

iOS: Native

03_iOS_Native.mp4

iOS: mWeb Safari

04_iOS_Safari.mp4

MacOS: Chrome / Safari

05_MacOS_Chrome.mp4

MacOS: Desktop

06_MacOS_Desktop.mp4

Ollyws

LGTM.

francoisl

Nice!

francoisl · 2023-12-19T03:27:17Z

Ah shoot, there's a conflict in BaseHTMLEngineProvider.js

Skalakid · 2023-12-20T21:31:18Z

@francoisl I just fixed the the conflict

OSBotify · 2023-12-20T22:23:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-21T05:31:11Z

🚀 Deployed to staging by https://github.com/francoisl in version: 1.4.15-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kavimuru · 2023-12-21T11:39:23Z

@Skalakid Do we run the script in the console in step 1? Can you please help with step 1?

francoisl · 2023-12-21T18:27:33Z

That snippet won't work in the console, I don't think there's a way to fully QA this yet actually.

We can still make sure attachments can be uploaded and show up correctly in the chat though (i.e. no regressions for other types), which I did - so feel free to check this off the checklist.

OSBotify · 2023-12-22T05:19:54Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.4.15-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Skalakid added 2 commits December 15, 2023 09:23

Add temporary video tag handling

a40c9f8

Update BaseHTMLProvider

bddf4d8

Skalakid mentioned this pull request Dec 15, 2023

[HOLD for payment 2023-12-29] [CRITICAL] Update HTMLEngineProvider to use VideoRenderer #32771

Closed

Fix getting href for video tags in AnchorRenderer

1eb74da

Skalakid marked this pull request as ready for review December 15, 2023 10:40

Skalakid requested a review from a team as a code owner December 15, 2023 10:40

melvin-bot bot requested review from Ollyws and removed request for a team December 15, 2023 10:40

Ollyws approved these changes Dec 18, 2023

View reviewed changes

melvin-bot bot requested a review from francoisl December 18, 2023 13:16

Merge branch 'main' into prepare-renderer-for-videos

0e9b9dc

francoisl previously approved these changes Dec 19, 2023

View reviewed changes

Merge branch 'main' into prepare-renderer-for-videos

9515870

Skalakid dismissed francoisl’s stale review via 9515870 December 20, 2023 21:25

Skalakid requested a review from francoisl December 20, 2023 21:36

francoisl approved these changes Dec 20, 2023

View reviewed changes

francoisl merged commit 4afbde0 into Expensify:main Dec 20, 2023
16 of 18 checks passed

github-actions bot mentioned this pull request Dec 21, 2023

Deploy Checklist: New Expensify 2023-12-21 #33391

Closed

51 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update HTMLEngineProvider to use VideoRenderer #33145

Update HTMLEngineProvider to use VideoRenderer #33145

Skalakid commented Dec 15, 2023 •

edited by francoisl

Loading

melvin-bot bot commented Dec 15, 2023

Ollyws commented Dec 18, 2023 •

edited by francoisl

Loading

Ollyws left a comment

francoisl left a comment

francoisl commented Dec 19, 2023

Skalakid commented Dec 20, 2023

OSBotify commented Dec 20, 2023

OSBotify commented Dec 21, 2023

kavimuru commented Dec 21, 2023

francoisl commented Dec 21, 2023

OSBotify commented Dec 22, 2023

Update HTMLEngineProvider to use VideoRenderer #33145

Update HTMLEngineProvider to use VideoRenderer #33145

Conversation

Skalakid commented Dec 15, 2023 • edited by francoisl Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 15, 2023

Ollyws commented Dec 18, 2023 • edited by francoisl Loading

Reviewer Checklist

Screenshots/Videos

Ollyws left a comment

Choose a reason for hiding this comment

francoisl left a comment

Choose a reason for hiding this comment

francoisl commented Dec 19, 2023

Skalakid commented Dec 20, 2023

OSBotify commented Dec 20, 2023

OSBotify commented Dec 21, 2023

kavimuru commented Dec 21, 2023

francoisl commented Dec 21, 2023

OSBotify commented Dec 22, 2023

Skalakid commented Dec 15, 2023 •

edited by francoisl

Loading

Ollyws commented Dec 18, 2023 •

edited by francoisl

Loading