-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS migration] Migrate 'HeaderWithBackButton' component to TypeScript #33214
[TS migration] Migrate 'HeaderWithBackButton' component to TypeScript #33214
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit , besides lgtm
Note: android recording will be added as soon as the issue on the main branch will be resolved |
# Conflicts: # src/components/HeaderWithBackButton/index.tsx
@akinwale kind bump 🙂 |
@VickyStash I think every prop is optional here. So can you fix that? |
@shubham1206agra Sure, taking a look |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2023-12-29.at.3.48.27.PM.mp4Android: mWeb ChromeiOS: NativeScreen.Recording.2023-12-29.at.3.53.04.PM.mp4iOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2023-12-29.at.4.05.14.PM.mp4MacOS: DesktopScreen.Recording.2023-12-29.at.4.09.10.PM.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! No comments to the code.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.20-0 🚀
|
🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.20-3 🚀
|
Details
[TS migration] Migrate 'HeaderWithBackButton' component to TypeScript
Fixed Issues
$ #25120
PROPOSAL: N/A
Tests
close
anddownload
buttons. When you click on the download button it should change the color and temporary be disabled.(?)
button in the header looks and works as expected. After that click onthree dots button
in the header and tap on theGo to admins room
option. Make surethree dots button
looks and works as expected.Offline tests
N/A
QA Steps
close
anddownload
buttons. When you click on the download button it should change the color and temporary be disabled.(?)
button in the header looks and works as expected. After that click onthree dots button
in the header and tap on theGo to admins room
option. Make surethree dots button
looks and works as expected.PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android_header1.mp4
Android: mWeb Chrome
android_web1.mp4
iOS: Native
ios1.mp4
iOS: mWeb Safari
ios_web1.mp4
MacOS: Chrome / Safari
web1.mp4
MacOS: Desktop
desktop1.mp4