fix: detect if date is NaN in getLocalDateFromDatetime #33223

hannojg · 2023-12-18T13:00:18Z

Details

When running the e2e tests locally I noticed that on some android devices opening a report crashes.
We basically get this error, because we are trying to pass an invalid date here:

App/src/pages/home/report/ParticipantLocalTime.js

Line 23 in 648c000

const reportRecipientDay = DateUtils.formatToDayOfWeek(reportTimezone);

The invalid date gets created here:

App/src/libs/DateUtils.ts

Lines 91 to 94 in 648c000

    
           function getLocalDateFromDatetime(locale: Locale, datetime?: string, currentSelectedTimezone: SelectedTimezone = timezone.selected): Date { 
        
               setLocale(locale); 
        
               if (!datetime) { 
        
                   return utcToZonedTime(new Date(), currentSelectedTimezone);

I investigate which values are passed to utcToZonedTime but they all seem valid. I try to reproduce the crash on my machine using utcToZonedTime and the input variable the app passes, but on my computer it was working.
I assume that it's an issue due to the Intl polyfill. That might also be the reason why we don't see this on every android device, but just some.

Fixed Issues

$ #33219
PROPOSAL: #33219

Tests

Hard to test as you'd need a specific android phone where you'd get this error.

Open a report
Verify that there is no crash
This only happens on some specific android devices so not clear if this can be reproed easily in main

Offline tests

/

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2023-12-18T13:00:24Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

abdulrahuman5196 · 2023-12-18T13:20:28Z

@hannojg Any specific case to reproduce this crash? Like any specific mobile?

Edit: Anyways will test since the description and the fix is generic enough

hannojg · 2023-12-18T14:33:58Z

You could try running the e2e tests and see if you get the crash as well:

We need to compile a android development app version that has capturing metrics enabled:

# Make sure that your .env file is the one we need for e2e testing:
cp ./tests/e2e/.env.e2e .env

# Build the android app like you normally would with
npm run android

Rename ./index.js to ./appIndex.js
Create a new ./index.js with the following content:

require('./src/libs/E2E/reactNativeLaunchingTest');

In ./src/libs/E2E/reactNativeLaunchingTest.ts change the main app import to the new ./appIndex.js file:

- import '../../../index';
+ import '../../../appIndex';

Then run the tests using:

npm run test:e2e:dev --includes Report

abdulrahuman5196 · 2023-12-18T19:25:52Z

I tried multiple times and wasn't able to reproduce the crash same as if the author pointed. But on checking the changes, its more like a generic error handling which would be good here.
So will test the change in all platforms and perform reviewers checklist here.

abdulrahuman5196 · 2023-12-18T20:07:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-12-19.at.1.30.23.AM.mp4

Android: mWeb Chrome

Screen.Recording.2023-12-19.at.1.32.06.AM.mp4

iOS: Native

Screen.Recording.2023-12-19.at.1.28.51.AM.mp4

iOS: mWeb Safari

Screen.Recording.2023-12-19.at.1.29.47.AM.mp4

MacOS: Chrome / Safari

Screen.Recording.2023-12-19.at.1.06.28.AM.mp4

MacOS: Desktop

Screen.Recording.2023-12-19.at.1.13.01.AM.mp4

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @mountiny

🎀 👀 🎀
C+ Reviewed

hannojg · 2023-12-19T06:17:36Z

Yeah the issue is that it doesn't happen on all android devices. Would be interesting to find out exactly why that is but I feel that would be a multiple days endeavour 😅

mountiny

Thanks!

OSBotify · 2023-12-26T11:50:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-28T21:19:21Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.18-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

detect if date is NaN

81ea1f6

hannojg requested a review from a team as a code owner December 18, 2023 13:00

melvin-bot bot requested review from abdulrahuman5196 and removed request for a team December 18, 2023 13:00

hannojg mentioned this pull request Dec 18, 2023

[HOLD for payment 2024-01-04] [$500] Opening a chat crashes due to formatToDayOfWeek throws "Invalid time value" #33219

Closed

6 tasks

abdulrahuman5196 approved these changes Dec 18, 2023

View reviewed changes

melvin-bot bot requested a review from mountiny December 18, 2023 20:09

mountiny approved these changes Dec 26, 2023

View reviewed changes

mountiny merged commit de5a943 into Expensify:main Dec 26, 2023
18 of 19 checks passed

mountiny assigned hannojg Dec 26, 2023

github-actions bot mentioned this pull request Dec 27, 2023

Deploy Checklist: New Expensify 2023-12-27 #33644

Closed

41 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: detect if date is NaN in getLocalDateFromDatetime #33223

fix: detect if date is NaN in getLocalDateFromDatetime #33223

hannojg commented Dec 18, 2023 •

edited by mountiny

Loading

melvin-bot bot commented Dec 18, 2023

abdulrahuman5196 commented Dec 18, 2023 •

edited

Loading

hannojg commented Dec 18, 2023

abdulrahuman5196 commented Dec 18, 2023

abdulrahuman5196 commented Dec 18, 2023 •

edited

Loading

abdulrahuman5196 left a comment

hannojg commented Dec 19, 2023

mountiny left a comment

OSBotify commented Dec 26, 2023

OSBotify commented Dec 28, 2023

	function getLocalDateFromDatetime(locale: Locale, datetime?: string, currentSelectedTimezone: SelectedTimezone = timezone.selected): Date {
	setLocale(locale);
	if (!datetime) {
	return utcToZonedTime(new Date(), currentSelectedTimezone);

fix: detect if date is NaN in getLocalDateFromDatetime #33223

fix: detect if date is NaN in getLocalDateFromDatetime #33223

Conversation

hannojg commented Dec 18, 2023 • edited by mountiny Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 18, 2023

abdulrahuman5196 commented Dec 18, 2023 • edited Loading

hannojg commented Dec 18, 2023

abdulrahuman5196 commented Dec 18, 2023

abdulrahuman5196 commented Dec 18, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

hannojg commented Dec 19, 2023

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 26, 2023

OSBotify commented Dec 28, 2023

hannojg commented Dec 18, 2023 •

edited by mountiny

Loading

abdulrahuman5196 commented Dec 18, 2023 •

edited

Loading

abdulrahuman5196 commented Dec 18, 2023 •

edited

Loading