-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix animation of fill prop of the svg element #33224
Closed
rayane-djouah
wants to merge
17
commits into
Expensify:main
from
rayane-djouah:Fix-animation-of-fill-prop-of-the-SVG-element
Closed
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
2f66190
Fix animation of fill prop of the SVG element
rayane-djouah 92f3b54
fix error: importing createAnimatedPropAdapter
rayane-djouah 9c1da47
fix lint error
rayane-djouah 225988e
fix error: The fill color of the plus icon does not get animated
rayane-djouah 9042025
fix propTypes declaration for the adapter
rayane-djouah adbb866
move adapter outside of the component
rayane-djouah 62833d1
remove unnecessary comment
rayane-djouah bf164fd
use native Object.keys instead of _.keys
rayane-djouah ccec8cf
ignore prefer-underscore-method lint rule
rayane-djouah 2cf48f5
move adapter inside the component
rayane-djouah 28b8b72
fix error on android
rayane-djouah abf9500
remove duplicate definition
rayane-djouah e1e2015
correct eslint-disable-next-line comment
rayane-djouah 6487dcf
correct eslint-disable-next-line comment
rayane-djouah 6007567
Merge branch 'Expensify:main' into Fix-animation-of-fill-prop-of-the-…
rayane-djouah c12ad0f
correct eslint-disable-next-line comment
rayane-djouah b57637d
mock createAnimatedPropAdapter from react-native-reanimated
rayane-djouah File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the bug cause is that we are not adapting properly the
fill
property from react-native-svg here, The fill color defaults to black.using the example from the docs is not working.
we should understand the expected color structure, and how we should set the
props.fill
in this case. for this, we need more information from SWM on theColorStruct
type declaration here, and what color format is expected byprocessColor
.cc @tomekzaw