Use updateMoneyRequestBillable #33245

luacmartins · 2023-12-18T16:21:45Z

Details

Uses the new updateMoneyRequestBillable command.

Fixed Issues

Tests

In OldDot, create a new Control policy as admin
Run the following code in the browser:

p = Policy.getCurrent();
p.policy.isPolicyExpenseChatEnabled = "true";
p.save()

Navigate to Settings > Workspaces > Expenses and change Re-bill expenses to clients to Default to Billable
Navigate to Settings > Workspaces > Members and invite another user as an employee
As the employee, log into NewDot
Request money from the Workspaces + > Request money
Tap the report preview and the request preview to navigate to the request view
Verify that you can see the Billable toggle
Toggle the switch and verify that you see the changed the request to "non-billable" (previously "billable"). comment

Verify that no errors appear in the JS console

Offline tests

Step 8 above

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

web.mov

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-01-08T21:43:43Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2024-01-08T21:43:48Z

@c3024 @ One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

c3024 · 2024-01-09T03:00:21Z

Not related to this PR but there are warnings in console because receipt returned is an array whereas it should be an object

c3024 · 2024-01-09T05:28:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

billableAndroidmWeb-compressed.mp4

iOS: Native

billableiOSNative.mp4

iOS: mWeb Safari

billableiOSSafari.mp4

MacOS: Chrome / Safari

billableChrome.mp4

MacOS: Desktop

billableDesktop.mp4

c3024

LGTM

melvin-bot · 2024-01-09T05:44:21Z

@MariaHCD Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

OSBotify · 2024-01-09T06:46:54Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-10T06:20:44Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.4.24-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-01-11T08:52:24Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.24-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Krishna2323 · 2024-07-05T23:02:04Z

src/components/ReportActionItem/MoneyRequestView.js

+                return;
+            }
+            IOU.updateMoneyRequestBillable(transaction.transactionID, report.reportID, newBillable);
+            Navigation.dismissModal();


@luacmartins @c3024,Coming from this PR, why do we need to call Navigation.dismissModal();?

I think we just wanted to navigate the user back once they edit the billable field.

@luacmartins, do you mean we want to navigate back (close the RHP) if report is opened in RHP? I don't think we should be doing that.

I think we should do that if the report is opened from the central pane (original design in this PR). If the report is opened in the RHP, I agree that we should just navigate back.

@luacmartins, I think we don't need to do anything in both cases. When report is opened in central pane we shouldn't navigate when toggling billable value and same for RHP, we should not close the RHP just because of updating billable value. The RHP should remain open like it is opened when any other field is edited. WDYT?

I just tested again and I think that makes sense. Toggling billable when opening the thread from the central pane doesn't dismiss the modal, so we should do the same for the RHP

Screen.Recording.2024-07-09.at.9.51.45.AM.mov

use udpateMoneyRequestBillable

ad89755

luacmartins self-assigned this Dec 18, 2023

luacmartins changed the title ~~Use udpateMoneyRequestBillable~~ Use updateMoneyRequestBillable Dec 20, 2023

luacmartins added 3 commits January 8, 2024 13:58

resolve conflicts

67905e5

rm comment

9e9e739

get right param

6e50cc7

luacmartins marked this pull request as ready for review January 8, 2024 21:43

luacmartins requested a review from a team as a code owner January 8, 2024 21:43

melvin-bot bot requested review from c3024 and removed request for a team January 8, 2024 21:43

luacmartins requested review from tgolen and a team and removed request for c3024 January 8, 2024 21:43

melvin-bot bot requested review from c3024 and removed request for a team January 8, 2024 21:43

tgolen approved these changes Jan 8, 2024

View reviewed changes

c3024 approved these changes Jan 9, 2024

View reviewed changes

melvin-bot bot requested a review from MariaHCD January 9, 2024 05:44

MariaHCD approved these changes Jan 9, 2024

View reviewed changes

MariaHCD merged commit 85fee5a into main Jan 9, 2024
16 of 21 checks passed

MariaHCD deleted the cmartins-updateMoneyRequestBillable branch January 9, 2024 06:42

github-actions bot mentioned this pull request Jan 10, 2024

Deploy Checklist: New Expensify 2024-01-10 #34203

Closed

54 tasks

melvin-bot bot mentioned this pull request Jan 11, 2024

[HOLD for payment 2024-01-18] [DISTANCE] LOW: UpdateDistanceRequest 1:1:1 - UpdateMoneyRequestBillable - Split out into its own command #32310

Closed

Krishna2323 reviewed Jul 5, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use updateMoneyRequestBillable #33245

Use updateMoneyRequestBillable #33245

luacmartins commented Dec 18, 2023 •

edited

Loading

melvin-bot bot commented Jan 8, 2024

melvin-bot bot commented Jan 8, 2024

c3024 commented Jan 9, 2024

c3024 commented Jan 9, 2024 •

edited

Loading

c3024 left a comment

melvin-bot bot commented Jan 9, 2024

OSBotify commented Jan 9, 2024

OSBotify commented Jan 10, 2024

OSBotify commented Jan 11, 2024

Krishna2323 Jul 5, 2024

luacmartins Jul 8, 2024

Krishna2323 Jul 8, 2024

luacmartins Jul 8, 2024

Krishna2323 Jul 8, 2024

luacmartins Jul 9, 2024

Use updateMoneyRequestBillable #33245

Use updateMoneyRequestBillable #33245

Conversation

luacmartins commented Dec 18, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 8, 2024

melvin-bot bot commented Jan 8, 2024

c3024 commented Jan 9, 2024

c3024 commented Jan 9, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

c3024 left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Jan 9, 2024

OSBotify commented Jan 9, 2024

OSBotify commented Jan 10, 2024

OSBotify commented Jan 11, 2024

Krishna2323 Jul 5, 2024

Choose a reason for hiding this comment

luacmartins Jul 8, 2024

Choose a reason for hiding this comment

Krishna2323 Jul 8, 2024

Choose a reason for hiding this comment

luacmartins Jul 8, 2024

Choose a reason for hiding this comment

Krishna2323 Jul 8, 2024

Choose a reason for hiding this comment

luacmartins Jul 9, 2024

Choose a reason for hiding this comment

luacmartins commented Dec 18, 2023 •

edited

Loading

c3024 commented Jan 9, 2024 •

edited

Loading