Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Uncaught (in promise) TypeError in Timing.ts #33327

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Fix Uncaught (in promise) TypeError in Timing.ts #33327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libs/actions/Timing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ function end(eventName: string, secondaryName = '', maxExecutionTime = 0) {
return;
}

const {startTime, shouldUseFirebase} = timestampData[eventName];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... What if timestampData[eventName] is undefined? We'll still get an error here. Can't we just do:

    const {startTime, shouldUseFirebase} = timestampData[eventName] || {};

instead inside the callback?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, we need to set a default value for startTime as well?

Copy link
Contributor Author

@marcochavezf marcochavezf Dec 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah I thought the same but we're already checking if the value exists in the condition above, also we're substracting startTime below which also won't be ideal. timestampData[eventName] exists but it's deleted in another .end call

Environment.getEnvironment().then((envName) => {
const {startTime, shouldUseFirebase} = timestampData[eventName];
const eventTime = Date.now() - startTime;

if (shouldUseFirebase) {
Expand Down
Loading