-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change icon for empty workspace view in new room page #33331
Conversation
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@dukenv0307 Android native app screenshot is missing |
@shawnborton loop you here to help to review if screenshots look good to you. |
@dukenv0307 the icon looks bigger than original design #27995 (comment) |
@hoangzinh Updated with new width and height
I have crash problem with my android simulator. |
@dukenv0307 can you share latest screenshots so @shawnborton can review them? Thanks |
The updated screenshot here cc @shawnborton |
Looks great! |
cc @Expensify/design 4viz |
@shawnborton @hoangzinh any update here. |
I missed updates in this PR, let me complete the Review checklist |
Reviewer Checklist
Screenshots/Videos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/techievivek in version: 1.4.20-0 🚀
|
🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.20-3 🚀
|
Details
Change icon for empty workspace view in new room page
Fixed Issues
$ #27995
PROPOSAL: #27995 (comment)
Tests
Offline tests
Same as above
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop