Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix showing the IOU preview #3352

Merged
merged 1 commit into from
Jun 4, 2021
Merged

Fix showing the IOU preview #3352

merged 1 commit into from
Jun 4, 2021

Conversation

iwiznia
Copy link
Contributor

@iwiznia iwiznia commented Jun 3, 2021 •
edited
Loading

Held on https://github.com/Expensify/Auth/pull/5632

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/165671

Tests

  • Create an IOU split with only one other user
  • Check you see the Split $X with Y for Z comment first in the chat, then the Requested $X from Y for Z with the view details link (and that the link works) and then the preview:
    image
  • Create an IOU split with 2 other users
  • Check it left the Split $X with Y for Z in the comment of the 3 way chat
    image
  • Check it created the request in each of the user's 1:1 chats
    image
    image

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

@iwiznia iwiznia requested a review from Julesssss June 3, 2021 20:16
@iwiznia iwiznia requested a review from a team as a code owner June 3, 2021 20:16
@iwiznia iwiznia self-assigned this Jun 3, 2021
@MelvinBot MelvinBot requested review from MonilBhavsar and removed request for a team June 3, 2021 20:16
@iwiznia iwiznia removed the request for review from MonilBhavsar June 3, 2021 20:17
Julesssss
Julesssss approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@Julesssss Julesssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this action ordering is def. better.

@Julesssss Julesssss merged commit cec7949 into main Jun 4, 2021
@Julesssss Julesssss deleted the ionatan_fix_ioupreview_splits branch June 4, 2021 09:26
@OSBotify OSBotify mentioned this pull request Jun 4, 2021
Closed
11 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Jun 4, 2021

🚀 Deployed to staging in version: 1.0.62-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Jun 8, 2021

🚀 Deployed to production in version: 1.0.64-0🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julesssss Julesssss Julesssss approved these changes

Assignees

@iwiznia iwiznia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iwiznia @OSBotify @Julesssss