Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add policy summaries to Onyx #3353

Merged
merged 6 commits into from
Jun 4, 2021
Merged

Add policy summaries to Onyx #3353

merged 6 commits into from
Jun 4, 2021

Conversation

tgolen
Copy link
Contributor

@tgolen tgolen commented Jun 3, 2021

This data is not currently used, but @TomatoToaster needs it for a PR and we also need it for the N5.5 feature.

Fixed Issues

Part of https://github.com/Expensify/Expensify/issues/166038

Tests

None

QA Steps

None

Tested On

  • Web
    Other platforms will be tested as part of the features that implement this data

No screenshots because there is no UI using this yet.

cc @yuwenmemon

@tgolen tgolen requested a review from a team June 3, 2021 21:01
@tgolen tgolen self-assigned this Jun 3, 2021
@botify
Copy link

botify commented Jun 3, 2021

npm has a package.json file and a package-lock.json file. It seems you updated one without the other, which is usually a sign of a mistake. If you are updating a package make sure that you update the version in package.json then run npm install

@MelvinBot MelvinBot requested review from nickmurray47 and removed request for a team June 3, 2021 21:02
@tgolen tgolen requested a review from a team as a code owner June 3, 2021 21:05
@MelvinBot MelvinBot requested review from HorusGoul and removed request for a team June 3, 2021 21:05
nickmurray47
nickmurray47 approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@nickmurray47 nickmurray47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yuwenmemon
yuwenmemon approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@yuwenmemon yuwenmemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for this!

@HorusGoul HorusGoul merged commit 679e8ff into main Jun 4, 2021
@HorusGoul HorusGoul deleted the tgolen-policy-summaries branch June 4, 2021 09:20
@OSBotify OSBotify mentioned this pull request Jun 4, 2021
Closed
11 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Jun 4, 2021

🚀 Deployed to staging in version: 1.0.62-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Jun 8, 2021

🚀 Deployed to production in version: 1.0.64-0🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuwenmemon yuwenmemon yuwenmemon approved these changes

@HorusGoul HorusGoul HorusGoul approved these changes

@nickmurray47 nickmurray47 nickmurray47 approved these changes

Assignees

@tgolen tgolen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tgolen @botify @OSBotify @yuwenmemon @HorusGoul @nickmurray47