-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix remove the fill for non-icon mentions #33668
fix: Fix remove the fill for non-icon mentions #33668
Conversation
@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@mountiny the yesterday's PR #33634 unfortunately caused a regression: #33657 I'm not quite sure what is the reviewing process here as the original issue had no C+, so I'm tagging you directly. Sorry about that, IDK how it happened considering I had the screenshots of the native platforms attached in the original PR with the icons being displayed correctly. |
I think I will be C+ here as the regression issue has assigned me as C+ |
@mountiny Can you generate adhoc build here? |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
Reviewer Checklist
Screenshots/VideosAndroid: mWeb ChromeiOS: mWeb Safari |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.20-0 🚀
|
🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.20-3 🚀
|
Details
This is a follow-up PR to fix the regression: #33657
Fixed Issues
$ #33589
$ #33657
PROPOSAL: #33589 (comment)
Tests
Same as QA
Offline tests
Same as QA
QA Steps
@
to trigger mention suggestions listPR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop