-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] Fix merchant saving when empty in P2P case and copy for validation #33785
Conversation
@abzokhattab Let me know if you need anything, whats your ETA for the testing? |
@mountiny i am gonna test it now and upload the screenshots .. give me around 30 mins as i need to build the app on android to provide the screenshots |
Thanks! |
@abzokhattab Can you also go through the checklist and post it filled out here? you can use it from some other recently completed PR |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2023-12-30.at.12.53.58.AM.movAndroid: mWeb ChromeScreen.Recording.2023-12-30.at.1.01.03.AM.moviOS: NativeScreen.Recording.2023-12-30.at.12.53.58.AM.moviOS: mWeb SafariScreen.Recording.2023-12-30.at.1.01.03.AM.movMacOS: Chrome / SafariScreen.Recording.2023-12-30.at.12.25.29.AM.movMacOS: DesktopScreen.Recording.2023-12-30.at.1.03.14.AM.mov |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
[CP Staging] Fix merchant saving and copy for validation (cherry picked from commit 89ee303)
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.4.20-2 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.20-3 🚀
|
Details
Fixed Issues
$ #33780
$ #33781
PROPOSAL:
Tests
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Trying to set expense merchant to empty string not possible:
Correct error shown when merchant is missing on expense view
Setting empty merchant does nothing
Screen.Recording.2023-12-29.at.23.03.50.mp4
Android: Native
Purely logical changes, included web testing above, c+ will test other platforms
Android: mWeb Chrome
Purely logical changes, included web testing above, c+ will test other platforms
iOS: Native
Purely logical changes, included web testing above, c+ will test other platforms
iOS: mWeb Safari
Purely logical changes, included web testing above, c+ will test other platforms
MacOS: Chrome / Safari
Purely logical changes, included web testing above, c+ will test other platforms
MacOS: Desktop
Purely logical changes, included web testing above, c+ will test other platforms