Fix: No required field validation state picker #33926

DylanDylann · 2024-01-04T07:59:33Z

Details

No required field validation on no value select on new dropdowns like state (validation works on older dropdown)

Fixed Issues

$ #30195
PROPOSAL: #30195 (comment)

Tests

Open the app
Open settings->workspaces->any workspace->bank account->connect manually
Fill in details in step 1 and continue
Open state field and go back without selection (new dropdown)
Observe that validation is triggered

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open the app
Open settings->workspaces->any workspace->bank account->connect manually
Fill in details in step 1 and continue
Open state field and go back without selection (new dropdown)
Observe that validation is triggered

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screencast.from.04-01-2024.16.11.38.webm

Android: mWeb Chrome

Screencast.from.04-01-2024.15.05.43.webm

iOS: Native

Screencast.from.09-01-2024.02.37.18.webm

iOS: mWeb Safari

Screencast.from.04-01-2024.15.05.43.webm

MacOS: Chrome / Safari

Screencast.from.04-01-2024.15.00.51.webm

MacOS: Desktop

Screencast.from.09-01-2024.02.27.58.webm

melvin-bot · 2024-01-04T07:59:37Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

DylanDylann · 2024-01-04T09:21:01Z

src/components/StatePicker/index.js

+        if (!isUpdateStateInput) {
+            onBlur();
+        }


There are a few methods that can make the picker modal hidden, for example, clicking on back button, or clicking on any option.

We only call the onBlur function if the modal is hidden when user clicks on the back button

If we call the onBlur function if the modal is hidden when user clicks on any option as well, and the user did not open the picker modal before, then opened it, and clicked on any option, the modal will be hidden and the error message appears for a while

Let's rename isUpdateStateInput to shouldBur and default it to true , also let's add a comment explaining it.

melvin-bot · 2024-01-04T09:25:07Z

@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

fedirjh · 2024-01-05T12:16:38Z

src/components/StatePicker/index.js

+        if (!isUpdateStateInput) {
+            onBlur();
+        }


Let's rename isUpdateStateInput to shouldBur and default it to true , also let's add a comment explaining it.

src/components/StatePicker/index.js

fedirjh · 2024-01-05T12:25:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

CleanShot.2024-01-05.at.12.43.15.mp4

Android: mWeb Chrome

CleanShot.2024-01-05.at.12.48.59.mp4

iOS: Native

iOS: mWeb Safari

CleanShot.2024-01-05.at.12.51.47.mp4

MacOS: Chrome / Safari

CleanShot.2024-01-05.at.11.14.25.mp4

MacOS: Desktop

fedirjh · 2024-01-05T12:25:29Z

@DylanDylann Please add the missing screenshots. Thank you.

fedirjh · 2024-01-08T18:07:34Z

@DylanDylann friendly bump.

DylanDylann · 2024-01-08T19:38:57Z

@fedirjh I updated the screenshots and fixed all your comments

fedirjh

Looks good and tests well.

OSBotify · 2024-01-09T11:08:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-10T06:21:05Z

🚀 Deployed to staging by https://github.com/nkuoch in version: 1.4.24-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-01-11T08:52:45Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.24-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix no required field validation state picker

95efb33

DylanDylann changed the title ~~fix no required field validation state picker~~ Fix: No required field validation state picker Jan 4, 2024

DylanDylann commented Jan 4, 2024

View reviewed changes

DylanDylann marked this pull request as ready for review January 4, 2024 09:25

DylanDylann requested a review from a team as a code owner January 4, 2024 09:25

melvin-bot bot requested review from fedirjh and removed request for a team January 4, 2024 09:25

fedirjh suggested changes Jan 5, 2024

View reviewed changes

fix rename param to shouldBlur

cb544b7

fedirjh approved these changes Jan 8, 2024

View reviewed changes

melvin-bot bot requested a review from nkuoch January 8, 2024 20:28

nkuoch approved these changes Jan 9, 2024

View reviewed changes

nkuoch merged commit 56d732b into Expensify:main Jan 9, 2024
19 checks passed

github-actions bot mentioned this pull request Jan 10, 2024

Deploy Checklist: New Expensify 2024-01-10 #34203

Closed

54 tasks

melvin-bot bot mentioned this pull request Jan 11, 2024

[HOLD for payment 2024-01-18] [ON HOLD for #25397][$500] No required field validation on no value select on new dropdowns like state (validation works on older dropdown) #30195

Closed

6 tasks

vincdargento mentioned this pull request Dec 25, 2024

[HOLD for payment 2025-01-24] [$250] Bank account - App does not trigger required field validation when no state is selected #54572

Open

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: No required field validation state picker #33926

Fix: No required field validation state picker #33926

DylanDylann commented Jan 4, 2024 •

edited

Loading

melvin-bot bot commented Jan 4, 2024

DylanDylann Jan 4, 2024 •

edited

Loading

fedirjh Jan 5, 2024

melvin-bot bot commented Jan 4, 2024

fedirjh Jan 5, 2024

fedirjh commented Jan 5, 2024 •

edited

Loading

fedirjh commented Jan 5, 2024

fedirjh commented Jan 8, 2024

DylanDylann commented Jan 8, 2024 •

edited

Loading

fedirjh left a comment

OSBotify commented Jan 9, 2024

OSBotify commented Jan 10, 2024

OSBotify commented Jan 11, 2024

Fix: No required field validation state picker #33926

Fix: No required field validation state picker #33926

Conversation

DylanDylann commented Jan 4, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 4, 2024

DylanDylann Jan 4, 2024 • edited Loading

Choose a reason for hiding this comment

fedirjh Jan 5, 2024

Choose a reason for hiding this comment

melvin-bot bot commented Jan 4, 2024

fedirjh Jan 5, 2024

Choose a reason for hiding this comment

fedirjh commented Jan 5, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

fedirjh commented Jan 5, 2024

fedirjh commented Jan 8, 2024

DylanDylann commented Jan 8, 2024 • edited Loading

fedirjh left a comment

Choose a reason for hiding this comment

OSBotify commented Jan 9, 2024

OSBotify commented Jan 10, 2024

OSBotify commented Jan 11, 2024

DylanDylann commented Jan 4, 2024 •

edited

Loading

DylanDylann Jan 4, 2024 •

edited

Loading

fedirjh commented Jan 5, 2024 •

edited

Loading

DylanDylann commented Jan 8, 2024 •

edited

Loading