Load parent report action from withOnyx in report action HOC #34113

tgolen · 2024-01-08T21:20:58Z

@luacmartins I wanted you to review this to ensure I didn't end up changing any of the logic and it looked like you had the most context into the current code.

Fixed Issues

Part of #27262

Tests

Run npm i and also a pod install from the ios directory
Open a chat with Person A and Person B
Have Person B open a thread from one of Person A's comments and add a message to the thread
From inside the thread, have Person B flag the original comment from Person A (the topmost comment)
Verify the Flag Comment window opens with options (if this PR were not working, this would display as a not-found page instead)

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Open a chat with Person A and Person B
Have Person B open a thread from one of Person A's comments and add a message to the thread
From inside the thread, have Person B flag the original comment from Person A (the topmost comment)
Verify the Flag Comment window opens with options (if this PR were not working, this would display as a not-found page instead)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

tgolen · 2024-01-08T23:13:59Z

Got stuck with the TS errors. There is a draft PR for Onyx which will probably be required: Expensify/react-native-onyx#445

tgolen · 2024-01-12T18:12:44Z

Now that Expensify/react-native-onyx#446 is merged, I need to update Onyx to 1.0.126 and finish this up.

aimane-chnaif · 2024-01-12T20:44:39Z

Onyx version will be bumped in #33554. I am currently doing regression test

tgolen · 2024-01-12T21:13:53Z

src/pages/FlagCommentPage.js

@@ -200,10 +199,4 @@ FlagCommentPage.displayName = 'FlagCommentPage';
 export default compose(
    withLocalize,
    withReportAndReportActionOrNotFound,
-    withOnyx({


This can be removed because the parentReportAction comes from withReportAndReportActionOrNotFound now.

melvin-bot · 2024-01-12T21:48:19Z

@amyevans Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

amyevans · 2024-01-15T17:29:18Z

@aimane-chnaif are you planning to provide a C+ review on this PR? Or should I complete the checklist?

Onyx version will be bumped in #33554. I am currently doing regression test

Looks like this got merged, @tgolen want to merge main? That should clear up the package.json/package-lock.json diff and hopefully the Snyk failures

aimane-chnaif · 2024-01-15T17:33:57Z

@amyevans sure I can review

luacmartins

Changes LGTM. Agree with @amyevans that we should merge main to get rid of the Onyx diff.

aimane-chnaif · 2024-01-16T14:23:35Z

I will do checklist after sync with main and unit tests are fixed

tgolen · 2024-01-16T15:22:51Z

OK, I should be able to get this updated today.

aimane-chnaif · 2024-02-07T15:24:51Z

@tgolen please pull main. Hope that would fix perf-tests

aimane-chnaif

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-08.at.11.29.50.AM.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2024-02-08T10:33:58Z

@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2024-02-08T10:34:01Z

🎯 @aimane-chnaif, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #36119.

aimane-chnaif · 2024-02-08T10:35:32Z

@tgolen still there's case when not found page briefly shows

Repro step:

Go to any flag comment page
Copy url
Logout
Enter url
Login with same account
Verify that app goes to flag comment page deeplink directly

Screen.Recording.2024-02-08.at.11.29.50.AM.mov

luacmartins

Seems like we have an edge case

tgolen · 2024-02-08T17:21:34Z

I think that edgecase is fine. Do either of you feel strongly about improving that? I'll fix the conflicts this morning.

aimane-chnaif · 2024-02-08T17:51:45Z

I think that edgecase is fine. Do either of you feel strongly about improving that? I'll fix the conflicts this morning.

yes if we have straightforward solution.
Otherwise someone will report this as regression

tgolen · 2024-02-08T18:03:50Z

Practically thinking through it, when is a real user ever going to enter that flow? And if they do, what are the consequences when they do? I think it's highly unlikely anyone would ever encounter it in the real world, and the worst that can happen when they do is they see a not-found page while the report loads. IMO it is too low value to worry about. I would also explain that to anyone who reports it as a regression.

aimane-chnaif · 2024-02-08T18:15:05Z

ok agree with you.
TLDR; This might also happen on Split bill detail page (tested this page as well but not reproduced yet) which uses withReportAndReportActionOrNotFound HOC

luacmartins · 2024-02-08T18:16:09Z

I agree that it's enough of an edge case for it to be low value.

tgolen · 2024-02-08T18:22:32Z

Thanks for hearing me out.

I fixed the conflicts. It was caused because both files were migrated to TS. That probably means it's worth having another last look at the code before shipping it.

luacmartins · 2024-02-08T18:29:37Z

Changes LGTM. @aimane-chnaif wanna test again before we ship?

aimane-chnaif

Screen.Recording.2024-02-08.at.7.59.05.PM.mov

luacmartins · 2024-02-08T19:02:20Z

Thanks! Merging!

OSBotify · 2024-02-08T19:08:13Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-12T14:19:55Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.40-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	failure ❌

OSBotify · 2024-02-13T18:25:16Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.40-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	failure ❌

tgolen added 3 commits January 8, 2024 14:20

Add the data to be loaded from onyx

cc24a97

Remove the use of lodash.

d318c95

Remove deprecated method

b2b8868

tgolen mentioned this pull request Jan 8, 2024

Remove ReportActionsUtils.getParentReportAction(), ReportUtils.getParentReport(), TransactionUtils.getLinkedTransaction(), ReportUtils.getPolicy(), and TransactionUtils.getTransaction() #27262

Closed

25 tasks

tgolen changed the title ~~Add the data to be loaded from onyx~~ Load parent report action from Onyx for report action HOC Jan 12, 2024

tgolen changed the title ~~Load parent report action from Onyx for report action HOC~~ Load parent report action from withOnyx in report action HOC Jan 12, 2024

tgolen added 4 commits January 12, 2024 13:36

Merge branch 'main' into tgolen-refactor-hocsideloading

33e348e

Update onyx

4237770

Fix types

83b1547

Remove extra onyx subscription

2440051

Add all withOnyx properties and import type

05b979d

tgolen commented Jan 12, 2024

View reviewed changes

Remove unused imports

6f7b07f

tgolen self-assigned this Jan 12, 2024

Style

fe4cb1a

tgolen marked this pull request as ready for review January 12, 2024 21:47

tgolen requested a review from a team as a code owner January 12, 2024 21:47

melvin-bot bot removed the request for review from a team January 12, 2024 21:48

melvin-bot bot requested a review from amyevans January 12, 2024 21:48

luacmartins self-requested a review January 15, 2024 17:02

luacmartins reviewed Jan 15, 2024

View reviewed changes

Merge branch 'main' into tgolen-refactor-hocsideloading

9cf1ed8

tgolen requested a review from luacmartins February 6, 2024 16:21

luacmartins previously approved these changes Feb 6, 2024

View reviewed changes

Merge branch 'main' into tgolen-refactor-hocsideloading

31009d2

aimane-chnaif approved these changes Feb 8, 2024

View reviewed changes

melvin-bot bot requested a review from marcochavezf February 8, 2024 10:33

melvin-bot bot mentioned this pull request Feb 8, 2024

Payment issue for E/App PR#34113 #36119

Closed

luacmartins reviewed Feb 8, 2024

View reviewed changes

Merge branch 'main' into tgolen-refactor-hocsideloading

2deac05

Fix changes from TS migration

d698da3

tgolen dismissed luacmartins’s stale review via d698da3 February 8, 2024 18:18

luacmartins approved these changes Feb 8, 2024

View reviewed changes

aimane-chnaif reviewed Feb 8, 2024

View reviewed changes

luacmartins merged commit 2988851 into main Feb 8, 2024
19 checks passed

luacmartins deleted the tgolen-refactor-hocsideloading branch February 8, 2024 19:02

github-actions bot mentioned this pull request Feb 12, 2024

Deploy Checklist: New Expensify 2024-02-12 #36335

Closed

90 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Load parent report action from withOnyx in report action HOC #34113

Load parent report action from withOnyx in report action HOC #34113

tgolen commented Jan 8, 2024 •

edited

Loading

tgolen commented Jan 8, 2024

tgolen commented Jan 12, 2024

aimane-chnaif commented Jan 12, 2024

tgolen Jan 12, 2024

melvin-bot bot commented Jan 12, 2024

amyevans commented Jan 15, 2024

aimane-chnaif commented Jan 15, 2024

luacmartins left a comment

aimane-chnaif commented Jan 16, 2024

tgolen commented Jan 16, 2024

aimane-chnaif commented Feb 7, 2024

aimane-chnaif left a comment

melvin-bot bot commented Feb 8, 2024

melvin-bot bot commented Feb 8, 2024

aimane-chnaif commented Feb 8, 2024

luacmartins left a comment

tgolen commented Feb 8, 2024

aimane-chnaif commented Feb 8, 2024

tgolen commented Feb 8, 2024

aimane-chnaif commented Feb 8, 2024

luacmartins commented Feb 8, 2024

tgolen commented Feb 8, 2024

luacmartins commented Feb 8, 2024

aimane-chnaif left a comment

luacmartins commented Feb 8, 2024

OSBotify commented Feb 8, 2024

OSBotify commented Feb 12, 2024

OSBotify commented Feb 13, 2024

Load parent report action from withOnyx in report action HOC #34113

Load parent report action from withOnyx in report action HOC #34113

Conversation

tgolen commented Jan 8, 2024 • edited Loading

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

tgolen commented Jan 8, 2024

tgolen commented Jan 12, 2024

aimane-chnaif commented Jan 12, 2024

tgolen Jan 12, 2024

Choose a reason for hiding this comment

melvin-bot bot commented Jan 12, 2024

amyevans commented Jan 15, 2024

aimane-chnaif commented Jan 15, 2024

luacmartins left a comment

Choose a reason for hiding this comment

aimane-chnaif commented Jan 16, 2024

tgolen commented Jan 16, 2024

aimane-chnaif commented Feb 7, 2024

aimane-chnaif left a comment

Choose a reason for hiding this comment

Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented Feb 8, 2024

melvin-bot bot commented Feb 8, 2024

aimane-chnaif commented Feb 8, 2024

luacmartins left a comment

Choose a reason for hiding this comment

tgolen commented Feb 8, 2024

aimane-chnaif commented Feb 8, 2024

tgolen commented Feb 8, 2024

aimane-chnaif commented Feb 8, 2024

luacmartins commented Feb 8, 2024

tgolen commented Feb 8, 2024

luacmartins commented Feb 8, 2024

aimane-chnaif left a comment

Choose a reason for hiding this comment

luacmartins commented Feb 8, 2024

OSBotify commented Feb 8, 2024

OSBotify commented Feb 12, 2024

OSBotify commented Feb 13, 2024

tgolen commented Jan 8, 2024 •

edited

Loading