fix: Use the full-height ReportActionsSkeletonView in all cases #34114

paultsimura · 2024-01-08T21:25:23Z

Details

This PR brings consistency to displaying the ReportActions Skeleton View: makes it take the full-screen height in all scenarios

Fixed Issues

$ #33659
PROPOSAL: #33659 (comment)

Tests

Same as QA

Offline tests

Same as QA

QA Steps

Go offline
Open a chat that you have not opened yet

Verify a full-height skeleton is displayed

While the loading screen is being shown, send any message

Verify the message appeared in the chat
Verify that the skeleton above the message still takes a full screen height

PR Author Checklist

Screenshots/Videos

Android: Native

android-compressed.mp4

Android: mWeb Chrome

chrome-compressed.mp4

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-01-08.at.22.21.36-compressed.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-01-08.at.22.23.05-compressed.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-01-08.at.22.11.50.mov

MacOS: Desktop

Screen.Recording.2024-01-08.at.22.34.40-compressed.mp4

melvin-bot · 2024-01-08T21:25:27Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

paultsimura · 2024-01-08T21:27:38Z

@mananjadhav I tried to separate the isReportLoadedUntilBeginning case from isLoadingOlderReportActions to mark it with separate comments even though in both cases we now return <ReportActionsSkeletonView />.

Please let me know if you'd prefer me to squash both returns into one with a unified if-condition (I thought it may be less readable).

dragnoir · 2024-01-08T21:42:59Z

There's a way to simplify your code, especially since both conditions return the same component <ReportActionsSkeletonView />) Here's an optimized version:

if (type === CONST.LIST_COMPONENTS.FOOTER) {
    const isReportLoadedUntilBeginning = lastReportActionName === CONST.REPORT.ACTIONS.TYPE.CREATED;

    if (isLoadingOlderReportActions || (!isReportLoadedUntilBeginning && (isLoadingInitialReportActions || isOffline))) {
        return <ReportActionsSkeletonView />;
    }
}

paultsimura · 2024-01-08T21:45:10Z

There's a way to simplify your code

Of course, that's what I was referring to here: #34114 (comment)
Sometimes less code means less clarity, that's why I need Manan's opinion on this.

mananjadhav · 2024-01-09T14:45:58Z

@paultsimura It's best we have one condition and return the SkeletonView only once.

When we have such complex long conditions it is better to split them into flags. For example, !isReportLoadedUntilBeginning && (isLoadingInitialReportActions || isOffline can be one flag.

mananjadhav · 2024-01-09T14:46:15Z

src/pages/home/report/ListBoundaryLoader/ListBoundaryLoader.js

+        const isReportLoadedUntilBeginning = lastReportActionName === CONST.REPORT.ACTIONS.TYPE.CREATED;
+        if (!isReportLoadedUntilBeginning && (isLoadingInitialReportActions || isOffline)) {


When we have such complex long conditions it is better to split them into flags. For example, !isReportLoadedUntilBeginning && (isLoadingInitialReportActions || isOffline can be one flag.

Thanks, done ✔️

mananjadhav · 2024-01-09T16:26:49Z

Thanks this looks good. I'll start with the checklist in a while.

mananjadhav · 2024-01-09T18:22:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-offline-report-skeleton.mov

Android: mWeb Chrome

mweb-chrome-offline-report-skeleton.mov

iOS: Native

ios-offline-report-skeleton.mov

iOS: mWeb Safari

mweb-safari-offline-report-skeleton.mov

MacOS: Chrome / Safari

desktop-offline-report-skeleton.mov

MacOS: Desktop

desktop-offline-report-skeleton.mov

OSBotify · 2024-01-10T18:10:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-11T09:59:40Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 1.4.24-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2024-01-15T11:41:00Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.24-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dragnoir · 2024-01-15T12:43:18Z

The updates here are causing a new extra scroll bar (don't exist on the other full skeleton) and the bar is freezing in the middle

paultsimura · 2024-01-15T13:06:59Z

@dragnoir Yes, that's expected.
The skeleton itself covers the full screen, so you can scroll it with the scrollbar. You can see it in the recordings attached to this PR.

dragnoir · 2024-01-15T13:09:36Z

@paultsimura you can't scroll to the top even the scroll bar exist.

paultsimura · 2024-01-15T13:11:14Z

What device & browser do you use?
Also, please attach the recording

Use the full-height ReportActionsSkeletonView in all cases

0f045e1

paultsimura requested a review from a team as a code owner January 8, 2024 21:25

melvin-bot bot removed the request for review from a team January 8, 2024 21:25

melvin-bot bot requested a review from mananjadhav January 8, 2024 21:25

paultsimura mentioned this pull request Jan 8, 2024

[HOLD for payment 2024-01-22] [$500] Web - tasks - Only half of the screen shows loading animation when creating tasks offline #33659

Closed

6 tasks

mananjadhav reviewed Jan 9, 2024

View reviewed changes

Use single return for Skeleton views

b868094

paultsimura requested a review from mananjadhav January 9, 2024 16:25

mananjadhav approved these changes Jan 9, 2024

View reviewed changes

melvin-bot bot requested a review from madmax330 January 9, 2024 18:40

madmax330 approved these changes Jan 10, 2024

View reviewed changes

madmax330 merged commit 03f7222 into Expensify:main Jan 10, 2024
16 of 17 checks passed

github-actions bot mentioned this pull request Jan 11, 2024

Deploy Checklist: New Expensify 2024-01-11 #34327

Closed

54 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Use the full-height ReportActionsSkeletonView in all cases #34114

fix: Use the full-height ReportActionsSkeletonView in all cases #34114

paultsimura commented Jan 8, 2024 •

edited

Loading

melvin-bot bot commented Jan 8, 2024

paultsimura commented Jan 8, 2024

dragnoir commented Jan 8, 2024

paultsimura commented Jan 8, 2024

mananjadhav commented Jan 9, 2024

mananjadhav Jan 9, 2024

paultsimura Jan 9, 2024

mananjadhav commented Jan 9, 2024

mananjadhav commented Jan 9, 2024 •

edited

Loading

OSBotify commented Jan 10, 2024

OSBotify commented Jan 11, 2024

OSBotify commented Jan 15, 2024

dragnoir commented Jan 15, 2024

paultsimura commented Jan 15, 2024

dragnoir commented Jan 15, 2024

paultsimura commented Jan 15, 2024

		const isReportLoadedUntilBeginning = lastReportActionName === CONST.REPORT.ACTIONS.TYPE.CREATED;
		if (!isReportLoadedUntilBeginning && (isLoadingInitialReportActions \|\| isOffline)) {

fix: Use the full-height ReportActionsSkeletonView in all cases #34114

fix: Use the full-height ReportActionsSkeletonView in all cases #34114

Conversation

paultsimura commented Jan 8, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 8, 2024

paultsimura commented Jan 8, 2024

dragnoir commented Jan 8, 2024

paultsimura commented Jan 8, 2024

mananjadhav commented Jan 9, 2024

mananjadhav Jan 9, 2024

Choose a reason for hiding this comment

paultsimura Jan 9, 2024

Choose a reason for hiding this comment

mananjadhav commented Jan 9, 2024

mananjadhav commented Jan 9, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

OSBotify commented Jan 10, 2024

OSBotify commented Jan 11, 2024

OSBotify commented Jan 15, 2024

dragnoir commented Jan 15, 2024

paultsimura commented Jan 15, 2024

dragnoir commented Jan 15, 2024

paultsimura commented Jan 15, 2024

paultsimura commented Jan 8, 2024 •

edited

Loading

mananjadhav commented Jan 9, 2024 •

edited

Loading