-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client-side violations for money request updates #34402
Client-side violations for money request updates #34402
Commits on Jan 10, 2024
-
Add optimistic violations to money request edits
Update everywhere that accesses an arg on policy to use {} as default arg for safety, since we can't use optional chaining
Configuration menu - View commit details
-
Copy full SHA for a551927 - Browse repository at this point
Copy the full SHA a551927View commit details -
Merge remote-tracking branch 'upstream/main' into lindboe/violations/…
…money-request-updates
Configuration menu - View commit details
-
Copy full SHA for 5ea3000 - Browse repository at this point
Copy the full SHA 5ea3000View commit details -
Configuration menu - View commit details
-
Copy full SHA for 56dd74d - Browse repository at this point
Copy the full SHA 56dd74dView commit details -
Configuration menu - View commit details
-
Copy full SHA for fe4b178 - Browse repository at this point
Copy the full SHA fe4b178View commit details -
Configuration menu - View commit details
-
Copy full SHA for a189970 - Browse repository at this point
Copy the full SHA a189970View commit details
Commits on Jan 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 69ad695 - Browse repository at this point
Copy the full SHA 69ad695View commit details
Commits on Jan 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 41e87ca - Browse repository at this point
Copy the full SHA 41e87caView commit details -
getViolationsOnyxData requires new transaction data but previous tran…
…saction violations. Fix and make that more clear with argument names
Configuration menu - View commit details
-
Copy full SHA for a09e4ac - Browse repository at this point
Copy the full SHA a09e4acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 72cfa45 - Browse repository at this point
Copy the full SHA 72cfa45View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ff7c69 - Browse repository at this point
Copy the full SHA 8ff7c69View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2942ea - Browse repository at this point
Copy the full SHA f2942eaView commit details
Commits on Jan 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 37bbacc - Browse repository at this point
Copy the full SHA 37bbaccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a3e818 - Browse repository at this point
Copy the full SHA 0a3e818View commit details -
Merge remote-tracking branch 'upstream/main' into lindboe/violations/…
…money-request-updates
Configuration menu - View commit details
-
Copy full SHA for d211324 - Browse repository at this point
Copy the full SHA d211324View commit details
Commits on Jan 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ede3bbe - Browse repository at this point
Copy the full SHA ede3bbeView commit details
Commits on Jan 19, 2024
-
Merge remote-tracking branch 'upstream/main' into lindboe/violations/…
…money-request-updates
Configuration menu - View commit details
-
Copy full SHA for 87d2f07 - Browse repository at this point
Copy the full SHA 87d2f07View commit details
Commits on Jan 23, 2024
-
Merge remote-tracking branch 'upstream/main' into lindboe/violations/…
…money-request-updates
Configuration menu - View commit details
-
Copy full SHA for 04fcb21 - Browse repository at this point
Copy the full SHA 04fcb21View commit details
Commits on Jan 24, 2024
-
Merge remote-tracking branch 'upstream/main' into lindboe/violations/…
…money-request-updates
Configuration menu - View commit details
-
Copy full SHA for d87ded8 - Browse repository at this point
Copy the full SHA d87ded8View commit details
Commits on Jan 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 371e166 - Browse repository at this point
Copy the full SHA 371e166View commit details
Commits on Jan 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 38ffff6 - Browse repository at this point
Copy the full SHA 38ffff6View commit details
Commits on Jan 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 210cfea - Browse repository at this point
Copy the full SHA 210cfeaView commit details -
Merge remote-tracking branch 'upstream/main' into lindboe/violations/…
…money-request-updates
Configuration menu - View commit details
-
Copy full SHA for 269b7df - Browse repository at this point
Copy the full SHA 269b7dfView commit details
Commits on Feb 5, 2024
-
Merge remote-tracking branch 'upstream/main' into lindboe/violations/…
…money-request-updates
Configuration menu - View commit details
-
Copy full SHA for 699dc34 - Browse repository at this point
Copy the full SHA 699dc34View commit details -
Manage MoneyRequestView type error
This component was typed before the actions file, and so it's not inferring the correct type for the policy arg. Should be fixed when IOU.js is typed.
Configuration menu - View commit details
-
Copy full SHA for 938c6bc - Browse repository at this point
Copy the full SHA 938c6bcView commit details -
Merge remote-tracking branch 'upstream/main' into lindboe/violations/…
…money-request-updates
Configuration menu - View commit details
-
Copy full SHA for 84267ea - Browse repository at this point
Copy the full SHA 84267eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for b8248ef - Browse repository at this point
Copy the full SHA b8248efView commit details
Commits on Feb 6, 2024
-
Problems remaining: 1. Inconsistent types 2. Mismatch between Onyx types and what's actually sent, and my code based on what's actually sent doesn't account for bad types: ``` > new.expensify@1.4.36-5 typecheck > tsc src/components/ReportActionItem/MoneyRequestView.tsx:159:109 - error TS2345: Argument of type 'OnyxEntry<Policy>' is not assignable to parameter of type 'Policy'. Type 'null' is not assignable to type 'Policy'. 159 IOU.updateMoneyRequestBillable(transaction?.transactionID ?? '', report?.reportID, newBillable, policy, policyTags, policyCategories); ~~~~~~ Found 1 error in src/components/ReportActionItem/MoneyRequestView.tsx:159 ``` It's never actually null, it's empty object 3. Need to double-check that everything is set by default when it needs to be
Configuration menu - View commit details
-
Copy full SHA for 32d6617 - Browse repository at this point
Copy the full SHA 32d6617View commit details -
Partway through updating code, realizing that `updateMoneyRequest` is now a completely dead code branch
Configuration menu - View commit details
-
Copy full SHA for 28a1f95 - Browse repository at this point
Copy the full SHA 28a1f95View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3493040 - Browse repository at this point
Copy the full SHA 3493040View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86ea25f - Browse repository at this point
Copy the full SHA 86ea25fView commit details -
Merge remote-tracking branch 'upstream/main' into lindboe/violations/…
…money-request-updates
Configuration menu - View commit details
-
Copy full SHA for 4197a85 - Browse repository at this point
Copy the full SHA 4197a85View commit details -
Configuration menu - View commit details
-
Copy full SHA for 352f5b1 - Browse repository at this point
Copy the full SHA 352f5b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 934bab4 - Browse repository at this point
Copy the full SHA 934bab4View commit details -
Revert "editMoneyRequest is no longer used, delete"
This reverts commit 3493040.
Configuration menu - View commit details
-
Copy full SHA for fbbcdae - Browse repository at this point
Copy the full SHA fbbcdaeView commit details
Commits on Feb 7, 2024
-
Merge remote-tracking branch 'upstream/main' into lindboe/violations/…
…money-request-updates
Configuration menu - View commit details
-
Copy full SHA for 1eebb39 - Browse repository at this point
Copy the full SHA 1eebb39View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30a2f24 - Browse repository at this point
Copy the full SHA 30a2f24View commit details
Commits on Feb 9, 2024
-
Merge remote-tracking branch 'upstream/main' into lindboe/violations/…
…money-request-updates
Configuration menu - View commit details
-
Copy full SHA for 9cbb446 - Browse repository at this point
Copy the full SHA 9cbb446View commit details -
Apply suggestions from code review
Co-authored-by: Carlos Alvarez <cead22@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d528580 - Browse repository at this point
Copy the full SHA d528580View commit details