Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client-side violations for money request updates #34402

Merged

Commits on Jan 10, 2024

  1. Add optimistic violations to money request edits

    Update everywhere that accesses an arg on policy to use {} as default arg for safety, since we can't use optional chaining
    lindboe committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    a551927 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'upstream/main' into lindboe/violations/…

    …money-request-updates
    lindboe committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    5ea3000 View commit details
    Browse the repository at this point in the history
  3. Lint fix

    lindboe committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    56dd74d View commit details
    Browse the repository at this point in the history
  4. Fix bugs

    lindboe committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    fe4b178 View commit details
    Browse the repository at this point in the history
  5. Fix data passing

    lindboe committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    a189970 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. Temp fix for tag issue

    lindboe committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    69ad695 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. Configuration menu
    Copy the full SHA
    41e87ca View commit details
    Browse the repository at this point in the history
  2. getViolationsOnyxData requires new transaction data but previous tran…

    …saction violations. Fix and make that more clear with argument names
    lindboe committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    a09e4ac View commit details
    Browse the repository at this point in the history
  3. Improve types

    lindboe committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    72cfa45 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8ff7c69 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f2942ea View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. Configuration menu
    Copy the full SHA
    37bbacc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0a3e818 View commit details
    Browse the repository at this point in the history
  3. Merge remote-tracking branch 'upstream/main' into lindboe/violations/…

    …money-request-updates
    lindboe committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    d211324 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. More prettier changes

    lindboe committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    ede3bbe View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Merge remote-tracking branch 'upstream/main' into lindboe/violations/…

    …money-request-updates
    lindboe committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    87d2f07 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Merge remote-tracking branch 'upstream/main' into lindboe/violations/…

    …money-request-updates
    lindboe committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    04fcb21 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Merge remote-tracking branch 'upstream/main' into lindboe/violations/…

    …money-request-updates
    lindboe committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    d87ded8 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Configuration menu
    Copy the full SHA
    371e166 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Configuration menu
    Copy the full SHA
    38ffff6 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. Configuration menu
    Copy the full SHA
    210cfea View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'upstream/main' into lindboe/violations/…

    …money-request-updates
    lindboe committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    269b7df View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. Configuration menu
    Copy the full SHA
    699dc34 View commit details
    Browse the repository at this point in the history
  2. Manage MoneyRequestView type error

    This component was typed before the actions file, and so it's not
    inferring the correct type for the policy arg. Should be fixed when
    IOU.js is typed.
    lindboe committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    938c6bc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    84267ea View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b8248ef View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. First stab at fixing typing

    Problems remaining:
    1. Inconsistent types
    2. Mismatch between Onyx types and what's actually sent, and my code
       based on what's actually sent doesn't account for bad types:
    
    ```
    > new.expensify@1.4.36-5 typecheck
    > tsc
    
    src/components/ReportActionItem/MoneyRequestView.tsx:159:109 - error TS2345: Argument of type 'OnyxEntry<Policy>' is not assignable to parameter of type 'Policy'.
      Type 'null' is not assignable to type 'Policy'.
    
    159             IOU.updateMoneyRequestBillable(transaction?.transactionID ?? '', report?.reportID, newBillable, policy, policyTags, policyCategories);
                                                                                                                    ~~~~~~
    
    Found 1 error in src/components/ReportActionItem/MoneyRequestView.tsx:159
    ```
    
    It's never actually null, it's empty object
    
    3. Need to double-check that everything is set by default when it needs
       to be
    lindboe committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    32d6617 View commit details
    Browse the repository at this point in the history
  2. WIP update

    Partway through updating code, realizing that `updateMoneyRequest` is
    now a completely dead code branch
    lindboe committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    28a1f95 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3493040 View commit details
    Browse the repository at this point in the history
  4. Finish typing IOU

    lindboe committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    86ea25f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4197a85 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    352f5b1 View commit details
    Browse the repository at this point in the history
  7. Random lint change

    lindboe committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    934bab4 View commit details
    Browse the repository at this point in the history
  8. Revert "editMoneyRequest is no longer used, delete"

    This reverts commit 3493040.
    lindboe committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    fbbcdae View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Configuration menu
    Copy the full SHA
    1eebb39 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    30a2f24 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Configuration menu
    Copy the full SHA
    9cbb446 View commit details
    Browse the repository at this point in the history
  2. Apply suggestions from code review

    Co-authored-by: Carlos Alvarez <cead22@gmail.com>
    lindboe and cead22 authored Feb 9, 2024
    Configuration menu
    Copy the full SHA
    d528580 View commit details
    Browse the repository at this point in the history