Fix scroll behavior when single item is selected #34485

neonbhai · 2024-01-15T01:32:28Z

Details

We fix scroll behavior on selecting single item and add new prop type to control scroll behavior on select.

Fixed Issues

$ #32305
PROPOSAL: #32305 (comment)

Tests

Click on Profile Picture
Click on Profile
Click on Personal Details
Click on Address
Click on State (if not a textbox), else click on Country
Click on an option
Verify the list doesn't scroll while dismissing.

Verify that no errors appear in the JS console

Offline tests

Same as Tests step

QA Steps

Same as Tests step

PR Author Checklist

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/64629613/bdc58c5d-1100-4900-b58c-da0726bab093

Android: mWeb Chrome

Screen.Recording.2024-01-15.at.6.10.37.AM.mov

iOS: Native

Screen.Recording.2024-01-15.at.6.06.35.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-01-15.at.6.05.19.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-01-15.at.5.56.12.AM.mov

MacOS: Desktop

Screen.Recording.2024-01-15.at.6.03.04.AM.mov

melvin-bot · 2024-01-15T01:32:33Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

neonbhai · 2024-01-15T01:39:39Z

@eVoloshchak The PR is ready for review!

eVoloshchak · 2024-01-17T16:54:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

24-01-17-18-36-54_063758.mp4

Android: mWeb Chrome

Screen.Recording.2024-01-17.at.18.35.29.mov

iOS: Native

Screen.Recording.2024-01-17.at.18.50.49.mov

iOS: mWeb Safari

Screen.Recording.2024-01-17.at.18.33.21.mov

MacOS: Chrome / Safari

Screen.Recording.2024-01-17.at.18.25.24.mov

MacOS: Desktop

Screen.Recording.2024-01-17.at.18.32.22.mov

eVoloshchak

Looks good and tests well

eVoloshchak · 2024-01-17T17:52:53Z

@neonbhai, LGTM, there are a couple of things left

in Tests, change "Click on Country" to "Click on State"
resolve the conflicts

src/components/SelectionList/BaseSelectionList.js

We remove this prop from BaseSelectionList as we don't have a usecase for now

neonbhai · 2024-01-24T01:29:35Z

in Tests, change "Click on Country" to "Click on State"

@eVoloshchak hi, added Click on Country as both CountryPicker and StatePicker use BaseSelectionList to display the list, and the bug exists in both.

Since the state picker is only available for USA residents:

App/src/components/AddressForm.js

Lines 172 to 181 in 0efabc2

    
           {isUSAForm ? ( 
        
               <View style={styles.mhn5}> 
        
                   <InputWrapper 
        
                       InputComponent={StatePicker} 
        
                       inputID="state" 
        
                       defaultValue={state} 
        
                       onValueChange={onAddressChanged} 
        
                       shouldSaveDraft={shouldSaveDraft} 
        
                   /> 
        
               </View>

And it might look like textbox sometimes:

Screen.Recording.2024-01-24.at.6.57.58.AM.mov

So changed steps to check the country list, as it is always available.

neonbhai · 2024-01-24T01:51:31Z

Updated Tests to make them clearer!

rlinoz · 2024-01-24T12:47:05Z

Hey @neonbhai just a conflict to fix then we can merge 😄

…ehavior-fix

neonbhai · 2024-01-26T02:23:29Z

Conflicts resolved, and PR retested!

cc: @rlinoz

OSBotify · 2024-01-26T11:25:05Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-29T19:24:09Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 1.4.33-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

This reverts commit 6ec827d, reversing changes made to caf91ae.

[CP Staging] Revert #34485

[CP Staging] Revert #34485 (cherry picked from commit 6c9219c)

OSBotify · 2024-01-31T02:31:00Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.33-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-01-31T02:57:23Z

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 1.4.33-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-01-31T04:11:20Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 1.4.34-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2024-01-31T04:37:37Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 1.4.34-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-01-31T22:48:31Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.34-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

neonbhai added 4 commits January 15, 2024 05:40

Update useEffect to not scroll if multiple options cannot be selected

26630b2

Define shouldScrollToTopOnSelect prop

b0742da

Add prop shouldScrollToTopOnSelect to BaseSelectionList

102862b

Prettier

2543e1c

neonbhai requested a review from a team as a code owner January 15, 2024 01:32

melvin-bot bot requested review from eVoloshchak and removed request for a team January 15, 2024 01:32

eVoloshchak approved these changes Jan 17, 2024

View reviewed changes

melvin-bot bot requested a review from rlinoz January 17, 2024 17:51

rlinoz reviewed Jan 19, 2024

View reviewed changes

src/components/SelectionList/BaseSelectionList.js Outdated Show resolved Hide resolved

neonbhai and others added 2 commits January 24, 2024 06:26

Merge branch 'Expensify:main' into scroll-behavior-fix

24fa7c8

Remove shouldScrollToTopOnSelect prop

fb49bc9

We remove this prop from BaseSelectionList as we don't have a usecase for now

Merge branch 'main' of https://github.com/Expensify/App into scroll-b…

a7e0e01

…ehavior-fix

rlinoz approved these changes Jan 26, 2024

View reviewed changes

rlinoz merged commit 6ec827d into Expensify:main Jan 26, 2024
15 checks passed

github-actions bot mentioned this pull request Jan 29, 2024

Deploy Checklist: New Expensify 2024-01-29 #35328

Closed

Pujan92 mentioned this pull request Jan 30, 2024

[HOLD for payment 2024-02-07] [HOLD for payment 2024-02-07] [$500] Personal details - First item in the list is not highlighted when searching for country #35374

Closed

6 tasks

lakchote added a commit that referenced this pull request Jan 30, 2024

Revert "Merge pull request #34485 from neonbhai/scroll-behavior-fix"

47f6a1d

This reverts commit 6ec827d, reversing changes made to caf91ae.

lakchote mentioned this pull request Jan 30, 2024

[CP Staging] Revert #34485 #35386

Merged

50 tasks

lakchote added a commit that referenced this pull request Jan 30, 2024

Merge pull request #35386 from Expensify/lucien/revert-scroll-pr

6c9219c

[CP Staging] Revert #34485

OSBotify pushed a commit that referenced this pull request Jan 30, 2024

Merge pull request #35386 from Expensify/lucien/revert-scroll-pr

7d5ebe8

[CP Staging] Revert #34485 (cherry picked from commit 6c9219c)

c3024 mentioned this pull request Jan 30, 2024

Fix highlighted user in new chat page is covered by referral view #35129

Merged

50 tasks

github-actions bot mentioned this pull request Jan 31, 2024

Deploy Checklist: New Expensify 2024-01-31 #35448

Closed

54 tasks

melvin-bot bot mentioned this pull request Jan 31, 2024

[HOLD for payment 2024-02-07] [HOLD for payment 2024-02-07] [$500][Wave 9][Low] Mweb - BA - When user selects "State", the drop down list gets scrolled #32305

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix scroll behavior when single item is selected #34485

Fix scroll behavior when single item is selected #34485

neonbhai commented Jan 15, 2024 •

edited

Loading

melvin-bot bot commented Jan 15, 2024

neonbhai commented Jan 15, 2024

eVoloshchak commented Jan 17, 2024 •

edited

Loading

eVoloshchak left a comment

eVoloshchak commented Jan 17, 2024

neonbhai commented Jan 24, 2024

neonbhai commented Jan 24, 2024

rlinoz commented Jan 24, 2024

neonbhai commented Jan 26, 2024

OSBotify commented Jan 26, 2024

OSBotify commented Jan 29, 2024

OSBotify commented Jan 31, 2024

OSBotify commented Jan 31, 2024

OSBotify commented Jan 31, 2024

OSBotify commented Jan 31, 2024

OSBotify commented Jan 31, 2024

Fix scroll behavior when single item is selected #34485

Fix scroll behavior when single item is selected #34485

Conversation

neonbhai commented Jan 15, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 15, 2024

neonbhai commented Jan 15, 2024

eVoloshchak commented Jan 17, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

eVoloshchak left a comment

Choose a reason for hiding this comment

eVoloshchak commented Jan 17, 2024

neonbhai commented Jan 24, 2024

neonbhai commented Jan 24, 2024

rlinoz commented Jan 24, 2024

neonbhai commented Jan 26, 2024

OSBotify commented Jan 26, 2024

OSBotify commented Jan 29, 2024

OSBotify commented Jan 31, 2024

OSBotify commented Jan 31, 2024

OSBotify commented Jan 31, 2024

OSBotify commented Jan 31, 2024

OSBotify commented Jan 31, 2024

neonbhai commented Jan 15, 2024 •

edited

Loading

eVoloshchak commented Jan 17, 2024 •

edited

Loading