-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store User_IsFromPublicDomain in Onyx #3460
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a551642
Add User_IsFromPublicDomain api command
roryabraham f5589e3
Create onyx action to fetch public domain info
roryabraham 9b499fe
Call user action in AuthScreens::componentDidMount
roryabraham c23a17e
Add requireClearbitResponse parameter
roryabraham 689cf93
Change requireClearbitResponse to requireCertainty
roryabraham 11a9d2f
Merge branch 'main' into Rory-IsUserPublicDomain
roryabraham 0bb46ed
Merge branch 'main' into Rory-IsUserPublicDomain
roryabraham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not E.cash knowledgable, so not a blocker, is there a reason why we do
console.debug()
in e.cash comparing to our Web code.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well we can use this library for server logs. Those should show up in LogSearch I believe. I just didn't think we needed this in server logs, but we could put them there. What do you think?
But if you're asking why we used
console.debug
instead ofconsole.log
, it's mostly because we have some ESLint rule that bansconsole.log
. I'm honestly not too sure why.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know honestly, we don't usually log errors in the console and just keep them in the server, that's why I am asking. But maybe since now the repo is public, this makes easier for contributors to debug, no idea haha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well if this happens, we'll likely have server logs for the
ClearbitCheckPublicEmail
bedrock job that was just created, so let's just leave this for now. I think it'll maybe be useful for debugging, esp. since it's not obvious why this request might fail.