Transactions - Update Generic Receipts to use ReceiptBackground

[FitseTLT]

Details

Fixed Issues

$ #28827
PROPOSAL: #28827 (comment)

Tests

1. Click on FAB Request money
2. select a pdf receipt confirm and check the thumbnail is displayed properly in confirmation page
3. Create the request and Verify that the thumbnail is displayed correctly in report preview on the chat
4. Press on the preview and Verify that the thumbnail is displayed correctly in request preview
5. Press on the request preview and Verify that receipts are displayed correctly in money request view
6. On an existing distance request while offline change the distance and Verify that thumbnail is displayed correctly in MoneyRequestView

• Verify that no errors appear in the JS console

Offline tests

same

QA Steps

same

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[melvin-bot]

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[mollfpr]

Hi @FitseTLT, could you complete the checklist? Thanks!

For the tests, we should get step by step on each case to verify the issue is resolved.

[FitseTLT]

@mollfpr Completed! Good to go!
Only haven't uploaded android native videos; having build failed so will upload as soon as I finish 👍

[mollfpr]

There are several issues I found.

Screen.Recording.2024-01-29.at.16.36.04.mp4

1. The banner position is not center
   
2. The thumbnail background color is changed after submit the money request
3. The thumbnail banner size and position constantly change while navigating the page back and forth (on timeframe 0:18 - 0:23)
4. The file extension is gone after the request is submitted to the API (on timeframe 0:23 - 0:25)

[mollfpr]

Where are values like 10 and 16 coming from?

It's just random value 😅

So maybe in order of the screenshots you posted above, we try 15 for confirmation page, then 9 for multiple thumbnails, then 13 for the preview thumbnails (you currently have it at this value, so all good).

This looks good to me!

@FitseTLT Could you try to implement this?

[FitseTLT]

Where are values like 10 and 16 coming from?

It's just random value 😅

So maybe in order of the screenshots you posted above, we try 15 for confirmation page, then 9 for multiple thumbnails, then 13 for the preview thumbnails (you currently have it at this value, so all good).

This looks good to me!

@FitseTLT Could you try to implement this?

on it

[FitseTLT]

@shawnborton Updated. Here is how it looks

[shawnborton]

I think that feels more consistent at least. Does anything happen if you tap on the receipt thumbnail area? I am guessing no right?

[FitseTLT]

I think that feels more consistent at least. Does anything happen if you tap on the receipt thumbnail area? I am guessing no right?

Yeah! Nothing.

[FitseTLT]

@dangrous I think we are good to go here 👍

[dangrous]

This is looking good! Two quick questions and then I think I can get this through to final merging!

[dangrous]

This is looking great (outside of the new merge conflicts, sorry!)

One last question - is there a way to prevent selection of the text?

If not, that's okay, but I think we can probably make it non-interactable, right?

[dubielzyk-expensify]

Great catch @dangrous . It would be nice to not have that label interactable

[FitseTLT]

@dangrous Done!!

[dangrous]

Okay this looks good! @mollfpr can you give the new changes one last look please, and then we can get this going? Thank you both for such hard work!

[FitseTLT]

@mollfpr bump on ^
Let's get this merged before we get another conflict 🥲

[mollfpr]

LGTM and tests well 👍

[dangrous]

Okay! Merging - thank you again!

[dangrous]

not sure why this says I didn't review it, so just calling out that I did and trying again?