[Violations] Update tagOutOfPolicy and taxOutOfPolicy #35048

neonbhai · 2024-01-24T10:52:10Z

Details

We update the violation messages for tagOutOfPolicy and taxOutOfPolicy

Fixed Issues

$ #34539
PROPOSAL: #34539 (comment)

Tests

Prerequisite:

Create a collect policy in OldDot

Execute the following JS snippet in the OldDot policy to enable workspace chats creation:

if (Url.getCurrentPageName()!="policy" ){ alert('Only run this snippet from a policy editor!'); } else { var p = Policy.getCurrent(); p.policy.isPolicyExpenseChatEnabled = "true"; p.save().done(function(){$.jGrowl('Workspace chat creation enabled!')}); }

Add an employee to the policy
Enable Tags and add a custom Tag.

For Tag Out Of Policy:

Log in to the employee's account
Tap on the green plus button (FAB)
Select Request money
Select any currency and amount
Click next
Choose the WS room
Click on "Show more"
Choose the custom tag in the Tag section
Complete the IOU
Login admin account on OldDot (expensify.com)
Navigate to the Collect group policy settings
In the Tag tab, disable the employee's selected tag from step 8
In the employee's account in ND, open the IOU details
Verify the Tag violation can be seen as: Tag no longer valid

Verify that no errors appear in the JS console

For Tax Out Of Policy:

We cannot test the taxOutOfPolicy violation as we do not yet render it in MoneyRequestView.

Offline tests

Violations for a new iou will not be received when offline as they are sent from the backend.

QA Steps

Same as Tests step.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

We update the copy to use 'Tag' when tagName is not available

We update the copy to use 'Tax' when taxName is not available

melvin-bot · 2024-01-24T10:52:15Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/languages/en.ts

cead22 · 2024-01-25T22:28:50Z

Please update tests to include both cases: the single level tags, and the multi level tags. To setup multi level tags you can follow these instructions https://community.expensify.com/discussion/5756/how-to-set-up-and-manage-multi-level-tagging?utm_source=community-search&utm_medium=organic-search&utm_term=independent+tag, and use this file
multitags.csv

That file will give the tag lists a name, which should produce violations like "Department no longer valid"

Also note that we're currently not sending the data array ['tagName' => $tagCollection->getName()] from the back end. I'm fixing that now, so we might need to hold this PR until that change is on staging and we can test

s77rt · 2024-01-27T01:25:06Z

Code looks good but I'm unable to test as I'm not getting any violations errors. I asked for help on Slack

s77rt · 2024-01-29T19:13:33Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

s77rt · 2024-01-29T19:14:29Z

@neonbhai Please tag me once the PR is updated (added new testing steps and missing screenshots, complete the checklist)

s77rt · 2024-02-05T14:25:18Z

@neonbhai Any updates here?

cead22 · 2024-02-05T21:24:39Z

Bump @neonbhai! I also pinged you on #expensify-open-source

neonbhai · 2024-02-06T16:31:10Z

Hi, sorry for delay, I have updated the PR!  

Noting a few things:

For multitags The app does not show all levels of tag show up. This is what I'm getting is currently

Video

d123304e-e405-49b4-b192-44cc1bdd12c5.mp4

Am I missing something? 🤔

The spanish translations are missing checks if params were passed so they show up as undefined

Proposing to translate according to these keys

For Tag:
🇺🇸

CustomTagName no longer valid
Tag no longer valid

🇪🇸

La etiqueta CustomTagName ya no es válida
La etiqueta ya no es válida

For Tax:
🇺🇸

CustomTaxName no longer valid
Tax no longer valid

🇪🇸

CustomTaxName ya no es válido
El impuesto ya no es válido.

cc: @cead22

Looks like backend still doesn't send violations with tagName

Video

d123304e-e405-49b4-b192-44cc1bdd12c5.mp4

Was the backend PR supposed to fix this 🤔

cead22 · 2024-02-06T23:05:27Z

Am I missing something? 🤔

No, it's just that multiple tags isn't currently supported in new dot, so what you're seeing is what's expected. We also have to update some API commands so when you update a request, violations clear automatically (which is something I'm working on)

Looks like backend still doesn't send violations with tagName

I think I have an issue for this as well -- but I'll look into it, but let's not block this PR on that

s77rt · 2024-02-06T23:21:27Z

@neonbhai Can you raise the translation question in Slack?

cead22 · 2024-02-07T00:49:18Z

The translations are good, let's not block on this

s77rt · 2024-02-07T01:05:13Z

@neonbhai Please apply the same fix for the Spanish translation and we should be good to merge

…-update

neonbhai · 2024-02-07T10:52:23Z

@cead22 looks like the backend was updated to show Tag instead of undefined for tagOutOfPolicy.

So currently it shows as:

Is this good?

src/languages/es.ts

cead22 · 2024-02-07T22:13:35Z

Is this good?

Depends, can you share the policy setup, to see if it has multiple levels of tags?

neonbhai · 2024-02-08T02:38:15Z

Here's the policy setup:

It does not have multiple levels of tag.

Video

The Policy ID is `484377E4416A2AFE` if that's helpful

Screen.Recording.2024-02-08.at.7.57.23.AM.mov

For Multiple Tags

The violations are now shown as Missing tag

Screen.Recording.2024-02-08.at.8.00.47.AM.mov

This is the someTagLevelsRequired violation

App/src/languages/en.ts

Line 2168 in 9f37d3e

someTagLevelsRequired: 'Missing tag',

cead22 · 2024-02-08T19:10:30Z

Yeah that looks good, and I submitted a back end fix so when the tagName is Tag we don't send it. Is there anything else that looks like it's not working as expected, or does everything work fine now?

…-update

neonbhai · 2024-02-09T13:53:56Z

Is there anything else that looks like it's not working as expected, or does everything work fine now?

Everything is good now! @cead22

cc: @s77rt for review!

s77rt · 2024-02-09T14:53:21Z

@neonbhai Please clarify the expected results in the testing steps

neonbhai · 2024-02-09T15:22:28Z

Tests Updated! @s77rt

s77rt · 2024-02-09T15:25:34Z

@neonbhai In step 12 you are referring to the wrong step (should be 8 not 10)

neonbhai · 2024-02-09T15:27:46Z

ah right, fixed!

s77rt · 2024-02-09T15:28:47Z

Verify the Tag violation can be seen as: La etiqueta ya no es válida

I don't think that's the case yet, still getting La etiqueta Tag ya no es válida Looks like the BE change are not live yet. If you are getting same thing just omit that test step

neonbhai · 2024-02-09T15:43:31Z

Right, BE change doesn't seem to be live yet. Updated tests!

luacmartins · 2024-02-09T16:46:55Z

@cead22 all yours!

OSBotify · 2024-02-09T17:57:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-12T14:20:22Z

🚀 Deployed to staging by https://github.com/cead22 in version: 1.4.40-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	failure ❌

OSBotify · 2024-02-13T18:25:43Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.40-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	failure ❌

neonbhai added 2 commits January 24, 2024 13:48

Update tagOutOfPolicy violation copy

cb77b60

We update the copy to use 'Tag' when tagName is not available

Update taxOutOfPolicy violation copy

e366109

We update the copy to use 'Tax' when taxName is not available

neonbhai requested a review from a team as a code owner January 24, 2024 10:52

melvin-bot bot removed the request for review from a team January 24, 2024 10:52

melvin-bot bot requested a review from s77rt January 24, 2024 10:52

neonbhai changed the title ~~Tag and tax policy violations copy update~~ [Violations] Update tagOutOfPolicy and taxOutOfPolicy Jan 24, 2024

s77rt suggested changes Jan 24, 2024

View reviewed changes

src/languages/en.ts Outdated Show resolved Hide resolved

cead22 previously approved these changes Jan 25, 2024

View reviewed changes

neonbhai and others added 2 commits February 7, 2024 14:16

Merge branch 'Expensify:main' into tag-and-tax-policy-violations-copy…

b1568d5

…-update

Update spanish translation for taxOutOfPolicy

b68dee1

neonbhai dismissed cead22’s stale review via b68dee1 February 7, 2024 09:36

twisterdotcom mentioned this pull request Feb 7, 2024

[HOLD for payment 2024-02-20] [$500] [MEDIUM] IOU - Inconsistency of disabled category and tag message #34539

Closed

6 tasks

s77rt suggested changes Feb 7, 2024

View reviewed changes

src/languages/es.ts Outdated Show resolved Hide resolved

Merge branch 'Expensify:main' into tag-and-tax-policy-violations-copy…

0c3b4a7

…-update

Update spanish translation for tagOutOfPolicy

8e04559

s77rt approved these changes Feb 9, 2024

View reviewed changes

melvin-bot bot requested a review from luacmartins February 9, 2024 15:51

luacmartins approved these changes Feb 9, 2024

View reviewed changes

cead22 approved these changes Feb 9, 2024

View reviewed changes

cead22 merged commit 4f45a67 into Expensify:main Feb 9, 2024
21 checks passed

github-actions bot mentioned this pull request Feb 12, 2024

Deploy Checklist: New Expensify 2024-02-12 #36335

Closed

90 tasks

kbecciv mentioned this pull request Feb 12, 2024

[$500] IOU - Missing Tag violation on IOU details page when tag was disabled in OD #36380

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Violations] Update tagOutOfPolicy and taxOutOfPolicy #35048

[Violations] Update tagOutOfPolicy and taxOutOfPolicy #35048

neonbhai commented Jan 24, 2024 •

edited

Loading

melvin-bot bot commented Jan 24, 2024

cead22 commented Jan 25, 2024 •

edited

Loading

s77rt commented Jan 27, 2024

s77rt commented Jan 29, 2024 •

edited

Loading

s77rt commented Jan 29, 2024

s77rt commented Feb 5, 2024

cead22 commented Feb 5, 2024

neonbhai commented Feb 6, 2024

cead22 commented Feb 6, 2024

s77rt commented Feb 6, 2024

cead22 commented Feb 7, 2024

s77rt commented Feb 7, 2024

neonbhai commented Feb 7, 2024

cead22 commented Feb 7, 2024

neonbhai commented Feb 8, 2024

cead22 commented Feb 8, 2024

neonbhai commented Feb 9, 2024

s77rt commented Feb 9, 2024

neonbhai commented Feb 9, 2024

s77rt commented Feb 9, 2024

neonbhai commented Feb 9, 2024

s77rt commented Feb 9, 2024

neonbhai commented Feb 9, 2024

luacmartins commented Feb 9, 2024

OSBotify commented Feb 9, 2024

OSBotify commented Feb 12, 2024

OSBotify commented Feb 13, 2024

[Violations] Update tagOutOfPolicy and taxOutOfPolicy #35048

[Violations] Update tagOutOfPolicy and taxOutOfPolicy #35048

Conversation

neonbhai commented Jan 24, 2024 • edited Loading

Details

Fixed Issues

Tests

For Tag Out Of Policy:

For Tax Out Of Policy:

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 24, 2024

cead22 commented Jan 25, 2024 • edited Loading

s77rt commented Jan 27, 2024

s77rt commented Jan 29, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

s77rt commented Jan 29, 2024

s77rt commented Feb 5, 2024

cead22 commented Feb 5, 2024

neonbhai commented Feb 6, 2024

cead22 commented Feb 6, 2024

s77rt commented Feb 6, 2024

cead22 commented Feb 7, 2024

s77rt commented Feb 7, 2024

neonbhai commented Feb 7, 2024

cead22 commented Feb 7, 2024

neonbhai commented Feb 8, 2024

cead22 commented Feb 8, 2024

neonbhai commented Feb 9, 2024

s77rt commented Feb 9, 2024

neonbhai commented Feb 9, 2024

s77rt commented Feb 9, 2024

neonbhai commented Feb 9, 2024

s77rt commented Feb 9, 2024

neonbhai commented Feb 9, 2024

luacmartins commented Feb 9, 2024

OSBotify commented Feb 9, 2024

OSBotify commented Feb 12, 2024

OSBotify commented Feb 13, 2024

neonbhai commented Jan 24, 2024 •

edited

Loading

cead22 commented Jan 25, 2024 •

edited

Loading

s77rt commented Jan 29, 2024 •

edited

Loading