-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Make redirects work for help and use dot #35116
Conversation
@alitoshmatov @ One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] NOTE: It looks like |
A preview of your ExpensifyHelp changes have been deployed to https://043286e1.helpdot.pages.dev ⚡️ |
@AndrewGable Should review this PR or c+ review is not needed? |
No need for C+, thanks for asking! |
Reviewer Checklist
Screenshots/VideosAndroid: NativeN/A - Help site Android: mWeb ChromeN/A - Help site iOS: NativeN/A - Help site iOS: mWeb SafariN/A - Help site MacOS: Chrome / SafariN/A - Help site MacOS: DesktopN/A - Help site |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.4.33-0 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.4.33-5 🚀
|
@AndrewGable Please review. This makes it so redirects can be from helpDot to useDot, which we need because we are deleting some helpDot pages in favor of their useDot equivalents. I also cleaned up the redirects.csv to remove the google search tag at the end of the URLs since we turned that feature off.
Fixed Issues
$ #35088
Tests
I added entires to redirects.csv for the new URLs and ensured they passed, and added bad entries and insured they failed:
Offline tests
N/A
QA Steps
No QA
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videosundefined