Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change style of header skeleton view to match with HeaderWithBackButton #35126

Merged
merged 5 commits into from
Jan 30, 2024
Merged

Change style of header skeleton view to match with HeaderWithBackButton #35126

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
220d45b
change style of header skeleton view to match with HeaderWithBackButton
dukenv0307 Jan 25, 2024
44c8b50
Merge branch 'main' into fix/34915
dukenv0307 Jan 28, 2024
f1ab769
consist left space of back button
dukenv0307 Jan 28, 2024
9eca9d5
Merge branch 'main' into fix/34915
dukenv0307 Jan 29, 2024
863f4f0
fix lint
dukenv0307 Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/HeaderWithBackButton/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ function HeaderWithBackButton({
// Hover on some part of close icons will not work on Electron if dragArea is true
// https://github.com/Expensify/App/issues/29598
dataSet={{dragArea: false}}
style={[styles.headerBar, shouldShowBorderBottom && styles.borderBottom, shouldShowBackButton && styles.pl2, shouldOverlay && StyleSheet.absoluteFillObject]}
style={[styles.headerBar, shouldShowBorderBottom && styles.borderBottom, shouldShowBackButton && styles.pl0, shouldOverlay && StyleSheet.absoluteFillObject]}
>
<View style={[styles.dFlex, styles.flexRow, styles.alignItemsCenter, styles.flexGrow1, styles.justifyContentBetween, styles.overflowHidden]}>
{shouldShowBackButton && (
Expand All @@ -87,7 +87,7 @@ function HeaderWithBackButton({
onBackButtonPress();
}
}}
style={[styles.touchableButtonImage]}
style={[styles.LHNToggle]}
role="button"
accessibilityLabel={translate('common.back')}
nativeID={CONST.BACK_BUTTON_NATIVE_ID}
Expand Down
Loading