Context Menu rendering

[parasharrajat]

Details

Fixed Issues

Fixes #2967

Tests | QA Steps (Web | desktop)

1. Open Any conversation on E.cash.
2. Open the Context menu on any message.
3. Now try to open the context menu for another message. The previous message should close and a new one should open.
4. Open the context menu on any message.
5. Click somewhere outside the context menu. A context menu should close.

Tests | QA Steps (Mobile | Mweb)

1. open Any conversation on E.cash
2. Hold press any message to open the context menu.
3. Click in the empty area should close the menu.
4. There should be no apparent changes and the context menu should behave as before.

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

context-menu-w.mp4

Mobile Web

1623342349136.mp4

Desktop

context-menu-d.mp4

iOS

Android

1623342349131.mp4

[Dal-Papa]

This LGTM but I'd rather have @marcaaron or @Julesssss review the code than me.

[Julesssss]

Sorry, I'm unable to take additional reviews today.

[parasharrajat]

@marcaaron any thoughts. Do you see any gotchas to component composition here?

[marcaaron]

Do you see any gotchas to component composition here?

Hmm sorry, can you ask that in another way? I'm not so sure what you meant.

[parasharrajat]

Sorry, Could you please review it, and do you think is there any better way of reusing the popover as I feel we have added a couple of wrappers around the baseModal.

[marcaaron]

Perhaps request in the Slack channel to see if someone else can provide a second opinion?

[parasharrajat]

@Beamanator All yours. Thanks.

[parasharrajat]

Full refactor. Thanks.

[Beamanator]

Looks awesome, tested and works well 👍 Will let Rory check it before merging

[roryabraham]

Nice, looks great!

[Beamanator]

#LGTM!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging in version: 1.0.69-1🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[isagoico]

@parasharrajat We were still able to reproduce this issue #3636 in mWeb. Should we check this PR off? It was a pass in all the other platforms. (and seems this issue will be fixed in #3635

[parasharrajat]

@isagoico Yeah there as accidentally bad merge of two PR which resulted in this behaviour. You are correct that other PR is going yo fix all the issues with context menu. I believe it will be merge today. So let's wait. Otherwise you can check it off, if that is a good option at the moment.

[OSBotify]

🚀 Deployed to production in version: 1.0.73-3🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅