-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pare back the parallax animation on empty chats #35232
Changes from 8 commits
e9023f0
78218a5
f0f1144
7fe93d8
20930ac
cfc6291
7e6042d
9acae68
ee64a29
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -619,7 +619,7 @@ function ReportActionItem(props) { | |
if (ReportUtils.isTaskReport(props.report)) { | ||
if (ReportUtils.isCanceledTaskReport(props.report, parentReportAction)) { | ||
return ( | ||
<> | ||
<View style={[StyleUtils.getReportWelcomeContainerStyle(props.isSmallScreenWidth, true)]}> | ||
<AnimatedEmptyStateBackground /> | ||
<View style={[StyleUtils.getReportWelcomeTopMarginStyle(props.isSmallScreenWidth)]}> | ||
<ReportActionItemSingle | ||
|
@@ -631,19 +631,19 @@ function ReportActionItem(props) { | |
</ReportActionItemSingle> | ||
<View style={styles.reportHorizontalRule} /> | ||
</View> | ||
</> | ||
</View> | ||
); | ||
} | ||
return ( | ||
<> | ||
<View style={[StyleUtils.getReportWelcomeContainerStyle(props.isSmallScreenWidth, true)]}> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The meaning of 2nd param is There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wanted to reuse the function in order to increase the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok let's rename then There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done :) |
||
<AnimatedEmptyStateBackground /> | ||
<View style={[StyleUtils.getReportWelcomeTopMarginStyle(props.isSmallScreenWidth)]}> | ||
<TaskView | ||
report={props.report} | ||
shouldShowHorizontalRule={!props.shouldHideThreadDividerLine} | ||
/> | ||
</View> | ||
</> | ||
</View> | ||
); | ||
} | ||
if (ReportUtils.isExpenseReport(props.report) || ReportUtils.isIOUReport(props.report)) { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,6 +43,7 @@ jest.mock('react-native/Libraries/LogBox/LogBox', () => ({ | |
jest.mock('react-native-reanimated', () => ({ | ||
...jest.requireActual('react-native-reanimated/mock'), | ||
createAnimatedPropAdapter: jest.fn, | ||
useReducedMotion: jest.fn, | ||
Comment on lines
45
to
+46
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FYI these missing mocks will be added to Reanimated in software-mansion/react-native-reanimated#5372 |
||
})); | ||
|
||
/** | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's regression: