Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NO QA]Feature: Critical Error Handling #3527

Merged
merged 8 commits into from
Jun 11, 2021
Merged

[NO QA]Feature: Critical Error Handling #3527

merged 8 commits into from
Jun 11, 2021

Commits on Jun 10, 2021

  1. feat: Crate ErrorBoundary component

    @kidroca
    kidroca committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    4de2896 View commit details
    Browse the repository at this point in the history

  2. feat: wrap the root component with an error boundary

    @kidroca
    kidroca committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    52102f0 View commit details
    Browse the repository at this point in the history

  3. refactor: extract platform specific implementation due to crashlytics… 

    … logging

@react-native-firebase/crashlytics does not work for web and desktop
    @kidroca
    kidroca committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    5100744 View commit details
    Browse the repository at this point in the history

  4. refactor: use Log.alert instead of Log.info

    @kidroca
    kidroca committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    48eb85d View commit details
    Browse the repository at this point in the history

  5. test: fix failing "loginTest"

    @kidroca
    kidroca committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    c021123 View commit details
    Browse the repository at this point in the history

  6. refactor: update parameters because the error message is not logging 

    The error logs as "{}" in the log, probably because it's a special object
Updated to pass the error message instead
    @kidroca
    kidroca committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    80d5309 View commit details
    Browse the repository at this point in the history

  7. refactor: remove stack trace and set captured messages 

    The stack trace is not interesting as it just traces to
the moment we call `Log.alert` in `logError`
Also the `errorInfo` contains the actual stack from React
    @kidroca
    kidroca committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    570845a View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2021

  1. refactor: address PR comments

    @kidroca
    kidroca committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    d01196e View commit details
    Browse the repository at this point in the history