-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cancel request where isDarkMode=true #35034 #35301
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: NativeisDarkModeAndroid.mp4Android: mWeb ChromeisDarkModeAndroidChrome.mp4iOS: NativeisDarkModeiOS.mp4iOS: mWeb SafariisDarkModeiOSSafari.mp4MacOS: Chrome / SafariisDarkModeChrome.mp4MacOS: DesktopisDarkModeDesktop.mp4 |
Your test steps do not include what is expected. Please add a step
Also please do not make a new PR when |
please refer to this comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/tgolen in version: 1.4.33-0 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.4.33-5 🚀
|
Details
Fixed Issues
$ #34669
PROPOSAL:#34669 (comment)
Tests
I've tested the scenarios with MacOS / Chrome / Safari
Steps to follow:
Open the Expensify URL in web browser and follow below steps:
in any 1:1 chat
Offline tests
QA Steps
Open the Expensify URL in web browser and follow below steps:
in any 1:1 chat
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
statement.mp4
MacOS: Desktop
desktopvideo.mp4