-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HelpDot] Add platform tabs #35329
[HelpDot] Add platform tabs #35329
Conversation
@dubielzyk-expensify @abdulrahuman5196 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
This reverts commit 97a7a4c.
delpoy expensify help workflow is expected to fail on forks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple very small comments, tested and works well!
Co-authored-by: Nikki Wines <nikkiwines@expensify.com>
@NikkiWines ready for review again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
deploy workflow is expected to fail on forks because cloudflare doesn't have permission to my fork |
Yep, that's expected. I believe we're still waiting on the C+ review for this one though 🙂 |
@NikkiWines i believe for helpdot, we don't have C+ reviews. This project is done under a flat fee. Correct me if im wrong @maddylewis. |
Oh, if that's the case then ok! |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
Thanks for the help 😃 @NikkiWines ! |
Np! Sorry for the delay and also now you've got conflicts 😢 |
nw! fixed the conflicts and tested! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NikkiWines looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
deploy workflow is expected to fail on forks. |
🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.36-5 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
1 similar comment
🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.36-5 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.37-7 🚀
|
Details
This PR implements platform switcher tabs between
Expensify classic
andNew expensify
.All articles in future will have this switcher. But for now, I've added them to a single article only to lay the foundation.
Scenarios
Expensify classic
andNew expensify
.Expensify classic
orNew expensify
.https://expensify.slack.com/archives/C02QSAC6BJ8/p1706560215383069
Fixed Issues
$ #34462
PROPOSAL: N.A.
Tests
npm run createDocsRoutes && bundle exec jekyll serve --livereload --safe
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Screen.Recording.2024-01-30.at.01.39.19.mov
Both platforms
Switcher in action
Only one platform
Mobile
Note that existing articles haven't been modified