Add missing `CFBundleExecutable` key and value in Info.plist #35336

francoisl · 2024-01-29T23:10:09Z

Details

Fixes the upload_to_testflight step for fastlane.

[22:58:57]: ERROR: [ContentDelivery.Uploader] Asset validation failed (90171) Invalid bundle structure. The “New Expensify.app/PlugIns/NotificationServiceExtension.appex/NotificationServiceExtension” binary file is not permitted. Your app cannot contain standalone executables or libraries, other than a valid CFBundleExecutable of supported bundles. For details, visit: https://developer.apple.com/documentation/bundleresources/placing_content_in_a_bundle (ID: 8b3b50dc-ac99-4c45-95f5-82959ea90346)

[22:58:57]: ERROR: [ContentDelivery.Uploader] Asset validation failed (90360) Missing Info.plist value. A value for the key 'CFBundleExecutable' in bundle New Expensify.app/PlugIns/NotificationServiceExtension.appex is required. (ID: 3febd13e-c2fb-4382-aa17-23a9d7c03f85)

[22:58:57]: ERROR: [ContentDelivery.Uploader] Asset validation failed (90360) Missing Info.plist value. A value for the key 'CFBundleName' in bundle New Expensify.app/PlugIns/NotificationServiceExtension.appex is required. (ID: 4763f239-f8d5-4a34-bdeb-2e23bf32244b)

[22:58:57]: ERROR: [ContentDelivery.Uploader] Asset validation failed (90360) Missing Info.plist value. A value for the key 'CFBundleDisplayName' in bundle New Expensify.app/PlugIns/NotificationServiceExtension.appex is required. (ID: 419e1047-eb72-41f9-9d52-1b79e93ef6dd)

[22:58:57]: Error uploading '/var/folders/58/w5_rvf3s4mb5xzhhyy69wrmw0000gn/T/e205e7bc-5132-47db-bf05-27d93f467e5d.ipa'.

[22:58:57]: Asset validation failed Invalid bundle structure. The “New Expensify.app/PlugIns/NotificationServiceExtension.appex/NotificationServiceExtension” binary file is not permitted. Your app cannot contain standalone executables or libraries, other than a valid CFBundleExecutable of supported bundles. For details, visit: https://developer.apple.com/documentation/bundleresources/placing_content_in_a_bundle (ID: 8b3b50dc-ac99-4c45-95f5-82959ea90346) (90171)

[22:58:57]: Asset validation failed Missing Info.plist value. A value for the key 'CFBundleExecutable' in bundle New Expensify.app/PlugIns/NotificationServiceExtension.appex is required. (ID: 3febd13e-c2fb-4382-aa17-23a9d7c03f85) (90360)

[22:58:57]: Asset validation failed Missing Info.plist value. A value for the key 'CFBundleName' in bundle New Expensify.app/PlugIns/NotificationServiceExtension.appex is required. (ID: 4763f239-f8d5-4a34-bdeb-2e23bf32244b) (90360)

[22:58:57]: Asset validation failed Missing Info.plist value. A value for the key 'CFBundleDisplayName' in bundle New Expensify.app/PlugIns/NotificationServiceExtension.appex is required. (ID: 419e1047-eb72-41f9-9d52-1b79e93ef6dd) (90360)

[22:58:57]: The call to the altool completed with a non-zero exit status: 1. This indicates a failure.
[22:58:57]: Could not download/upload from App Store Connect!

Fixed Issues

N/A, iOS builds are failing, e.g. https://github.com/Expensify/App/actions/runs/7703235964/job/20993994819

Tests

Cherry-puck this PR
Make sure fastlane doesn't throw the same error as in the action linked above

Verify that no errors appear in the JS console

Offline tests

QA Steps

No QA

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-01-29T23:13:22Z

@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

AndrewGable · 2024-01-29T23:37:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Tested via AdHoc

Android: mWeb Chrome

Tested via AdHoc

iOS: Native

Tested via AdHoc

iOS: mWeb Safari

Tested via AdHoc

MacOS: Chrome / Safari

Tested via AdHoc

MacOS: Desktop

Tested via AdHoc

…eExecutable Add missing `CFBundleExecutable` key and value in Info.plist (cherry picked from commit e8d6e15)

OSBotify · 2024-01-29T23:43:51Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-01-29T23:44:44Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/35336/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
❌ FAILED ❌	https://35336.pr-testing.expensify.com
The QR code can't be generated, because the Desktop build failed

👀 View the workflow run that generated this build 👀

OSBotify · 2024-01-30T00:13:21Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.4.33-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2024-01-30T00:43:51Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.4.33-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-01-31T02:34:15Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.33-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Add missing CFBundleExecutable key and value in Info.plist

03da30d

francoisl requested review from AndrewGable and arosiclair January 29, 2024 23:13

francoisl self-assigned this Jan 29, 2024

francoisl marked this pull request as ready for review January 29, 2024 23:13

francoisl requested a review from a team as a code owner January 29, 2024 23:13

melvin-bot bot removed the request for review from a team January 29, 2024 23:13

francoisl added the Ready To Build label Jan 29, 2024

Add missing CFBundleName and CFBundleDisplayName

715de67

AndrewGable approved these changes Jan 29, 2024

View reviewed changes

AndrewGable merged commit e8d6e15 into main Jan 29, 2024
9 checks passed

AndrewGable deleted the francois-add-missing-CFBundleExecutable branch January 29, 2024 23:39

OSBotify pushed a commit that referenced this pull request Jan 29, 2024

Merge pull request #35336 from Expensify/francois-add-missing-CFBundl…

12599ef

…eExecutable Add missing `CFBundleExecutable` key and value in Info.plist (cherry picked from commit e8d6e15)

os-botify bot mentioned this pull request Jan 29, 2024

🍒 Cherry pick PR #35336 to staging 🍒 #35343

Merged

github-actions bot mentioned this pull request Jan 29, 2024

Deploy Checklist: New Expensify 2024-01-29 #35328

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add missing `CFBundleExecutable` key and value in Info.plist #35336

Add missing `CFBundleExecutable` key and value in Info.plist #35336

francoisl commented Jan 29, 2024 •

edited

Loading

melvin-bot bot commented Jan 29, 2024

AndrewGable commented Jan 29, 2024 •

edited

Loading

OSBotify commented Jan 29, 2024

github-actions bot commented Jan 29, 2024

OSBotify commented Jan 30, 2024

OSBotify commented Jan 30, 2024

OSBotify commented Jan 31, 2024

Add missing CFBundleExecutable key and value in Info.plist #35336

Add missing CFBundleExecutable key and value in Info.plist #35336

Conversation

francoisl commented Jan 29, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 29, 2024

AndrewGable commented Jan 29, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

OSBotify commented Jan 29, 2024

github-actions bot commented Jan 29, 2024

OSBotify commented Jan 30, 2024

OSBotify commented Jan 30, 2024

OSBotify commented Jan 31, 2024

Add missing `CFBundleExecutable` key and value in Info.plist #35336

Add missing `CFBundleExecutable` key and value in Info.plist #35336

francoisl commented Jan 29, 2024 •

edited

Loading

AndrewGable commented Jan 29, 2024 •

edited

Loading