Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix red dot error doesn't show on LHN #35356

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Fix red dot error doesn't show on LHN #35356

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1609194
fix rbr doesn't show
bernhardoj Jan 30, 2024
4eabcb2
Merge branch 'main' into fix/35061-rbr-doesn't-show
bernhardoj Feb 1, 2024
8229f33
Merge branch 'main' into fix/35061-rbr-doesn't-show
bernhardoj Feb 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/libs/SidebarUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ function getOptionData({
const result: ReportUtils.OptionData = {
text: '',
alternateText: null,
allReportErrors: undefined,
allReportErrors: OptionsListUtils.getAllReportErrors(report, reportActions),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to init it here as it's cleaner to me.

brickRoadIndicator: null,
tooltipText: null,
subtitle: null,
Expand Down Expand Up @@ -318,7 +318,6 @@ function getOptionData({
result.isMoneyRequestReport = ReportUtils.isMoneyRequestReport(report);
result.shouldShowSubscript = ReportUtils.shouldReportShowSubscript(report);
result.pendingAction = report.pendingFields ? report.pendingFields.addWorkspaceRoom || report.pendingFields.createChat : undefined;
result.allReportErrors = OptionsListUtils.getAllReportErrors(report, reportActions);
result.brickRoadIndicator = hasErrors || hasViolations ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : '';
result.ownerAccountID = report.ownerAccountID;
result.managerID = report.managerID;
Expand Down
Loading