-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix enter doesn't work after going back from referral page #35415
Fix enter doesn't work after going back from referral page #35415
Conversation
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Additional video to show the shortcut still works Screen.Recording.2024-01-31.at.00.23.33.mov |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb Chromemchrome.moviOS: Nativeios.moviOS: mWeb Safarimsafari.movMacOS: Chrome / Safariweb.movMacOS: Desktopdesktop.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
I think that PR was solving a similar problem to this right? Personally I think this PR is less confusing and does less to effectively prevent the double even listeners so if you want to fix the conflict and clean up anything that isn't needed from https://github.com/Expensify/App/pull/36396/files then I'll merge |
Yep, they achieve the same thing. Fixed the conflict and cleaned https://github.com/Expensify/App/pull/36396/files changes. Confirmed the issue #36396 is fixing doesn't happen. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/bondydaa in version: 1.4.42-0 🚀
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.42-5 🚀
|
Details
After going back from the referral page, an ENTER shortcut is registered twice and only one is unregistered when we close the page.
Fixed Issues
$ #35373
PROPOSAL: #35373 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-01-31.at.00.13.02.mov
Android: mWeb Chrome
Screen.Recording.2024-01-31.at.00.10.09.mov
iOS: Native
Screen.Recording.2024-01-31.at.00.05.09.mov
iOS: mWeb Safari
Screen.Recording.2024-01-31.at.00.04.01.mov
MacOS: Chrome / Safari
Screen.Recording.2024-01-31.at.00.01.24.mov
MacOS: Desktop
Screen.Recording.2024-01-31.at.00.02.04.mov