-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] fix crash on tapping enable wallet in android #35440
Conversation
Works for me on a physical Android device (with https://ad-hoc-expensify-cash.s3.amazonaws.com/android/35440/v1.4.33-4_b1001043304/app-adhoc-release.apk) 👍 screen-20240130-140712.mp4 |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
Co-authored-by: Francois Laithier <francois@expensify.com>
Reviewer Checklist
Screenshots/VideosAndroid: Nativerecording-2.mp4Android: mWeb ChromeN/a iOS: NativeN/a iOS: mWeb SafariN/a MacOS: Chrome / SafariN/a MacOS: DesktopN/a |
Works well, i am trying to check if this change increases the APK size. |
I'm not noticing any changes in size compared to #34218 (comment) |
(cherry picked from commit 578a0b9)
🚀 Cherry-picked to staging by https://github.com/francoisl in version: 1.4.33-5 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/francoisl in version: 1.4.33-5 🚀
|
Details
Fixed Issues
$ #35344
PROPOSAL: #35344 (comment)
Tests
Same as QA step
Offline tests
Same as QA step
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop