fix: Approved expense preview does not show GBR when submitter needs to add a bank account #35486

tienifr · 2024-01-31T15:59:09Z

Details

Fixed Issues

$ #34278
PROPOSAL: #34278 (comment)

Prerequisite:

Go to default WS on New Dot
Go to setting WS -> Bank Account -> Connect Online with Plaid
Follow the instruction to enable bank account on new dot
Go to Old dot -> create the collect WS
Open the created collect WS
Go to Report
Change the currency to USD
Go to Reimbursement
Change to direct and update Default Business Bank Account to the above bank account
Go to members -> add any members

Tests

Create a money request and submit it to a Collect workspace. Approve and pay as the workspace admin.
Verify that after an expense is approved, the submitting user should see a GBR in the expense preview which prompts them to add a bank account by clicking in to reveal the Add bank account CTA.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Create a money request and submit it to a Collect workspace. Approve and pay as the workspace admin.
Verify that after an expense is approved, the submitting user should see a GBR in the expense preview which prompts them to add a bank account by clicking in to reveal the Add bank account CTA.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-01.at.16.36.19.mov

Android: mWeb Chrome

Screen.Recording.2024-02-01.at.16.41.21.mov

iOS: Native

Screen.Recording.2024-02-01.at.16.25.45.mov

iOS: mWeb Safari

Screen.Recording.2024-02-01.at.16.37.14.mov

MacOS: Chrome / Safari

web-resize.mp4

MacOS: Desktop

Screen.Recording.2024-02-01.at.15.54.48.mov

…to add a bank account

melvin-bot · 2024-02-01T09:08:15Z

@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/ReportUtils.ts

tienifr · 2024-02-13T16:05:44Z

@cubuspl42 Sorry for this delay. I'm in Lunar New Year holiday. I'll take a look at it tmr

tienifr · 2024-02-14T14:34:37Z

Added some feedback

src/libs/ReportUtils.ts

cubuspl42 · 2024-02-20T09:59:37Z

I'm having trouble testing this. Would you post a video including both the admin's and the employee's side? I didn't manage to trigger the "Add bank account" prompt so far.

tienifr · 2024-02-21T04:53:29Z

@cubuspl42 I just mock the data for testing. You can try:

Onyx.merge('reportActions_5279572281778544', {'5279572281778541':{
  actionName : "REIMBURSEMENTQUEUED",
actorAccountID: 16324969,
automatic: false,
avatar: "https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_15.png",
childReportID: 6799068073121782,
childReportNotificationPreference: "hidden",
childType: "chat",
created: "2024-01-31 15:32:56.375",
isAttachment: false,
lastModified: "2024-01-31 15:32:56.375",

message : [
  {
    html: "₫123 request",
isDeletedParentAction: false,
isEdited: false,
reactions: [],
text: "₫123 request",
type: "COMMENT",
whisperedTo: [],
}
  ],
person: [
  {
    style: "strong",
text: "tienifr032022+12346@gmail.com",
type: "TEXT",
  }
  ],
  
  previousReportActionID: "6771885160789988443",
reportActionID: "4570058827618751666",
reportActionTimestamp: 1706715176375,
sequenceNumber: 1,
shouldShow: true,
timestamp: 1706775966,
whisperedToAccountIDs: []

}})

I add the mock report action to render the add bank account button. Of course, we need to update these fields above accordingly

cubuspl42 · 2024-02-21T08:28:17Z

@tienifr

You didn't follow your own testing steps from the "Tests" section. This is not fine. Please don't do that again.

Mocking during final testing is the last resort when testing the actual user scenario is impossible or extremely difficult. Is this such a case?

Please fix this. Update the testing steps if necessary. Re-record the video(s) again at least for one platform, let's say MacOS: Chrome / Safari. Include both sides of the user interaction (admin and non-admin).

tienifr · 2024-02-23T09:45:17Z

@cubuspl42 I just recorded the video for Mac: Chrome within full steps. I also mocked the report action since I didn't know how to reproduce (maybe we need the Expensify account). Is it fit for you? Thanks

cubuspl42 · 2024-02-23T11:54:20Z

This statement must be true in the context of the Expensify project:

The Contributor, the author of the PR, describes the steps they performed to test that the solution works in the "Tests" section of the PR description. They are the same steps they performed when recording the videos in the "Screenshot/Videos" of the PR description.

Is this news?

Make this true ☝️

Either update the "Tests" steps to match what you actually did (including the mocking details), or actually do what you described in the "Tests" section.

Both options would be better from the current state. The latter would be much preferred. Please clarify how to reproduce the original issue on GH issue/Slack.

tienifr · 2024-02-24T10:57:10Z

Asked on Slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1708772104743519

tienifr · 2024-03-05T03:12:46Z

@cubuspl42 how about your test?

cubuspl42 · 2024-03-05T10:46:03Z

I have a weird issue...

I can't see my Collect Workspace on NewDot Dev (on main / 9c49ab65db3f40e719c75516d5655f11b68c0f87)

On staging / prod it is available:

Is it some recent change or regression? 🤔

tienifr · 2024-03-06T03:56:12Z

@cubuspl42 I still can add the collect WS on main. Can you help check it soon?

Screen.Recording.2024-03-06.at.10.53.27.mp4

cubuspl42 · 2024-03-06T07:46:04Z

@cubuspl42 I still can add the collect WS on main. Can you help check it soon?
Screen.Recording.2024-03-06.at.10.53.27.mp4

Oh, I get it. So as I understand it, it's not available anymore in the Workspace Switcher, but can be accessed by searching. Thanks, I'll resume the testing!

cubuspl42 · 2024-03-06T08:03:05Z

Maybe my IQ level is not high enough for this issue.

I can only approve the request from the admin's side:

What are your currency settings for your Collect workspace on the OldDot side? Do I understand correctly that you use your local currency?

What are you Reimbursement settings for your Collect workspace on the OldDot side?

Also, changing currency doesn't work for me on the NewDot side:

Maybe a recent regression, I don't know... Not strictly related, but I wanted to test with USD to see if it changes anything.

tienifr · 2024-03-08T04:46:34Z

Do I understand correctly that you use your local currency?

Yes I use my local currency

What are you Reimbursement settings for your Collect workspace on the OldDot side?

What's your next step? Should we raise it in slack channel to hear some advices?

cubuspl42 · 2024-03-08T09:35:20Z

How are you able to "Pay with Expensify" if the app says that you don't have the "Direct" method enabled or the business bank account connected? Is it expected to work like this?

cubuspl42 · 2024-03-08T09:47:01Z

New Slack thread

cubuspl42 · 2024-03-11T09:40:49Z

Conflicts
In the Slack thread, we concluded that the "Pay with Expensify" option shouldn't be available for the "Indirect" configuration. Would you re-test, double ensuring that you do that on a branch with a recent main merged-in? There is no need to re-record all videos; the Web platform video will be enough.

If you still observe "Pay with Expensify" on the "Indirect" config, we can report this as a problem/regression in the context of #36814.

I'm sorry to drag you through this, but we need to ensure this is end-to-end tested if possible.

tienifr · 2024-03-12T04:04:27Z

I'm checking

tienifr · 2024-03-12T08:40:29Z

@cubuspl42 Pls follow these steps to reproduce

Prerequisite:

Go to default WS on New Dot
Go to setting WS -> Bank Account -> Connect Online with Plaid
Follow the instruction to enable bank account on new dot
Go to Old dot -> create the collect WS
Open the created collect WS
Go to Report
Change the currency to USD
Go to Reimbursement
Change to direct and update Default Business Bank Account to the above bank account
Go to members -> add any members

Test steps:

As the member Create a money request and submit it to a Collect workspace.
Approve and pay as the workspace admin.
Verify that after an expense is approved, the submitting user should see a GBR in the expense preview which prompts them to add a bank account by clicking in to reveal the Add bank account CTA.

Videos:

web-resize.mp4

tienifr · 2024-03-12T08:42:29Z

I updated video for chrome and Prerequisite steps as well

tienifr · 2024-03-12T08:42:51Z

Hope this helps and we can merge this PR soon

cubuspl42 · 2024-03-12T09:39:41Z

Thanks for the update! I'm on it.

Hope this helps and we can merge this PR soon

So do I! Still, pushing the working and tested changes is the highest priority

cubuspl42 · 2024-03-12T10:48:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

add-bank-account-gbr-android-compressed.mp4

Android: mWeb Chrome

add-bank-account-gbr-android-web-compressed.mp4

iOS: Native

add-bank-account-gbr-ios-compressed.mp4

iOS: mWeb Safari

add-bank-account-gbr-ios-web-compressed.mp4

MacOS: Chrome / Safari

add-bank-account-gbr-web-converted.mp4

MacOS: Desktop

blimpich

Looks great!

OSBotify · 2024-03-12T19:34:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-13T19:59:00Z

🚀 Deployed to staging by https://github.com/blimpich in version: 1.4.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-15T10:15:21Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.52-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

tienifr added 3 commits January 31, 2024 22:56

fix: Approved expense preview does not show GBR when submitter needs …

1057dd6

…to add a bank account

create util function

9ffd082

resolve conflict

98ddc8d

tienifr marked this pull request as ready for review February 1, 2024 09:08

tienifr requested a review from a team as a code owner February 1, 2024 09:08

melvin-bot bot requested review from cubuspl42 and removed request for a team February 1, 2024 09:08

cubuspl42 reviewed Feb 1, 2024

View reviewed changes

src/libs/ReportUtils.ts Outdated Show resolved Hide resolved

tienifr added 4 commits February 2, 2024 17:04

Merge branch 'main' into fix/34278

3e38e93

Merge branch 'main' into fix/34278

284e441

refactor code

3b9eb00

lint fix

652298d

cubuspl42 reviewed Feb 5, 2024

View reviewed changes

src/libs/ReportUtils.ts Outdated Show resolved Hide resolved

remove casting

76254c1

tienifr added 3 commits February 14, 2024 21:35

lint fix

58bb076

Merge branch 'main' into fix/34278

d7ebeba

fix: refactor

ee483b5

cubuspl42 reviewed Feb 19, 2024

View reviewed changes

src/libs/ReportUtils.ts Outdated Show resolved Hide resolved

edit comment

c7e9cd6

Merge branch 'main' into fix/34278

f31689a

Merge branch 'main' into fix/34278

2ad674d

tienifr added 2 commits March 5, 2024 09:54

Merge branch 'main' into fix/34278

4876373

fix typecheck

9f8dd2d

Merge branch 'main' into fix/34278

abc547c

resolve conflicts

3a5e398

fix lint

aaeda77

resolve conflicts

52740f4

cubuspl42 approved these changes Mar 12, 2024

View reviewed changes

melvin-bot bot requested a review from blimpich March 12, 2024 10:49

blimpich approved these changes Mar 12, 2024

View reviewed changes

blimpich merged commit 46f1f1e into Expensify:main Mar 12, 2024
17 checks passed

github-actions bot mentioned this pull request Mar 13, 2024

Deploy Checklist: New Expensify 2024-03-13 #38257

Closed

74 tasks

melvin-bot bot mentioned this pull request Mar 15, 2024

[HOLD for payment 2024-03-22] [$500] [MEDIUM] Approved expense preview does not show GBR when submitter needs to add a bank account #34278

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Approved expense preview does not show GBR when submitter needs to add a bank account #35486

fix: Approved expense preview does not show GBR when submitter needs to add a bank account #35486

tienifr commented Jan 31, 2024 •

edited

Loading

melvin-bot bot commented Feb 1, 2024

tienifr commented Feb 13, 2024

tienifr commented Feb 14, 2024

cubuspl42 commented Feb 20, 2024

tienifr commented Feb 21, 2024

cubuspl42 commented Feb 21, 2024

tienifr commented Feb 23, 2024

cubuspl42 commented Feb 23, 2024

tienifr commented Feb 24, 2024

tienifr commented Mar 5, 2024

cubuspl42 commented Mar 5, 2024

tienifr commented Mar 6, 2024 •

edited

Loading

cubuspl42 commented Mar 6, 2024

cubuspl42 commented Mar 6, 2024

tienifr commented Mar 8, 2024

cubuspl42 commented Mar 8, 2024

cubuspl42 commented Mar 8, 2024

cubuspl42 commented Mar 11, 2024

tienifr commented Mar 12, 2024

tienifr commented Mar 12, 2024

tienifr commented Mar 12, 2024

tienifr commented Mar 12, 2024

cubuspl42 commented Mar 12, 2024

cubuspl42 commented Mar 12, 2024

blimpich left a comment

OSBotify commented Mar 12, 2024

OSBotify commented Mar 13, 2024

OSBotify commented Mar 15, 2024

fix: Approved expense preview does not show GBR when submitter needs to add a bank account #35486

fix: Approved expense preview does not show GBR when submitter needs to add a bank account #35486

Conversation

tienifr commented Jan 31, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 1, 2024

tienifr commented Feb 13, 2024

tienifr commented Feb 14, 2024

cubuspl42 commented Feb 20, 2024

tienifr commented Feb 21, 2024

cubuspl42 commented Feb 21, 2024

tienifr commented Feb 23, 2024

cubuspl42 commented Feb 23, 2024

tienifr commented Feb 24, 2024

tienifr commented Mar 5, 2024

cubuspl42 commented Mar 5, 2024

tienifr commented Mar 6, 2024 • edited Loading

cubuspl42 commented Mar 6, 2024

cubuspl42 commented Mar 6, 2024

tienifr commented Mar 8, 2024

cubuspl42 commented Mar 8, 2024

cubuspl42 commented Mar 8, 2024

cubuspl42 commented Mar 11, 2024

tienifr commented Mar 12, 2024

tienifr commented Mar 12, 2024

tienifr commented Mar 12, 2024

tienifr commented Mar 12, 2024

cubuspl42 commented Mar 12, 2024

cubuspl42 commented Mar 12, 2024

Reviewer Checklist

Screenshots/Videos

blimpich left a comment

Choose a reason for hiding this comment

OSBotify commented Mar 12, 2024

OSBotify commented Mar 13, 2024

OSBotify commented Mar 15, 2024

tienifr commented Jan 31, 2024 •

edited

Loading

tienifr commented Mar 6, 2024 •

edited

Loading