Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace invalid prop for drawer #3552

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Jun 11, 2021

Details

A good explanation of the changes and related issue can be found here

Fixed Issues

Fixes #3537

Tests | QA Steps

  1. Open E.cash mobile app.
  2. Login into the app.
  3. you should see LHN instead of report messages.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

login-m-web.mp4

Desktop

iOS

login-ios.mp4

Android

1623712491058.mp4

@parasharrajat parasharrajat marked this pull request as ready for review June 14, 2021 23:15
@parasharrajat parasharrajat requested a review from a team as a code owner June 14, 2021 23:15
@MelvinBot MelvinBot requested review from MariaHCD and removed request for a team June 14, 2021 23:16
@MariaHCD MariaHCD merged commit 384aa5e into Expensify:main Jun 15, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.68-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.73-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After logging in, chat is displayed instead of LHN
3 participants