Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix random warnings #3579

Merged
merged 3 commits into from
Jun 14, 2021
Merged

Fix random warnings #3579

merged 3 commits into from
Jun 14, 2021

Conversation

roryabraham
Copy link
Contributor

Details

Just killing some annoying console warnings – not really fixing any known bugs.

Fixed Issues

Fixes n/a

Tests

  1. Run the iOS app, verify that you don't see the aggravating setTranslucent is android-only warning.
  2. Go to the various settings pages, verify that you don't see List items should have a unique key warnings.

QA Steps

None (covered by regression tests)

@roryabraham roryabraham self-assigned this Jun 14, 2021
@roryabraham roryabraham requested a review from a team as a code owner June 14, 2021 17:01
@MelvinBot MelvinBot requested review from nickmurray47 and removed request for a team June 14, 2021 17:01
@roryabraham roryabraham merged commit d0e5fb1 into main Jun 14, 2021
@roryabraham roryabraham deleted the Rory-FixRandomWarnings branch June 14, 2021 18:00
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.68-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.73-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants